From 8ec05f9fa47f28740f92905a8614118a93835789 Mon Sep 17 00:00:00 2001 From: Adam Cohen Date: Sun, 13 Oct 2013 12:29:03 -0700 Subject: Fix bugs / jank with folder creation feedback (issue 11195148) Change-Id: Ia53438a7724c95d304f08a4c16382a9b9e8bdfea --- src/com/android/launcher3/Workspace.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/com/android/launcher3/Workspace.java b/src/com/android/launcher3/Workspace.java index 1d5b5ac90..da0416235 100644 --- a/src/com/android/launcher3/Workspace.java +++ b/src/com/android/launcher3/Workspace.java @@ -3046,7 +3046,9 @@ public class Workspace extends SmoothPagedView private void cleanupFolderCreation() { if (mDragFolderRingAnimator != null) { mDragFolderRingAnimator.animateToNaturalState(); + mDragFolderRingAnimator = null; } + mFolderCreationAlarm.setOnAlarmListener(null); mFolderCreationAlarm.cancelAlarm(); } @@ -3390,9 +3392,11 @@ public class Workspace extends SmoothPagedView } public void onAlarm(Alarm alarm) { - if (mDragFolderRingAnimator == null) { - mDragFolderRingAnimator = new FolderRingAnimator(mLauncher, null); + if (mDragFolderRingAnimator != null) { + // This shouldn't happen ever, but just in case, make sure we clean up the mess. + mDragFolderRingAnimator.animateToNaturalState(); } + mDragFolderRingAnimator = new FolderRingAnimator(mLauncher, null); mDragFolderRingAnimator.setCell(cellX, cellY); mDragFolderRingAnimator.setCellLayout(layout); mDragFolderRingAnimator.animateToAcceptState(); -- cgit v1.2.3