diff options
author | Sunny Goyal <sunnygoyal@google.com> | 2017-09-13 10:13:21 -0700 |
---|---|---|
committer | Sunny Goyal <sunnygoyal@google.com> | 2017-09-18 10:04:37 -0700 |
commit | adaf210794f49669cac4c794638ae0718e13412a (patch) | |
tree | 60e066f939eb21526285f82f756eac5a0574538a /src | |
parent | 465435d16d8021859fe228a057e8fecbfc510fbd (diff) | |
download | android_packages_apps_Trebuchet-adaf210794f49669cac4c794638ae0718e13412a.tar.gz android_packages_apps_Trebuchet-adaf210794f49669cac4c794638ae0718e13412a.tar.bz2 android_packages_apps_Trebuchet-adaf210794f49669cac4c794638ae0718e13412a.zip |
Fixing widgets not getting restored when the corresponding system app is enabled
Bug: 64723295
Change-Id: I143b554087e6ff8cfbdb5f02d53fdcc7a1ce3b12
Diffstat (limited to 'src')
-rw-r--r-- | src/com/android/launcher3/model/PackageUpdatedTask.java | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/src/com/android/launcher3/model/PackageUpdatedTask.java b/src/com/android/launcher3/model/PackageUpdatedTask.java index 292f23c29..78ecbc621 100644 --- a/src/com/android/launcher3/model/PackageUpdatedTask.java +++ b/src/com/android/launcher3/model/PackageUpdatedTask.java @@ -178,6 +178,9 @@ public class PackageUpdatedTask extends BaseModelUpdateTask { if (mOp == OP_ADD || flagOp != FlagOp.NO_OP) { final ArrayList<ShortcutInfo> updatedShortcuts = new ArrayList<>(); final ArrayList<LauncherAppWidgetInfo> widgets = new ArrayList<>(); + + // For system apps, package manager send OP_UPDATE when an app is enabled. + final boolean isNewApkAvailable = mOp == OP_ADD || mOp == OP_UPDATE; synchronized (dataModel) { for (ItemInfo info : dataModel.itemsIdMap) { if (info instanceof ShortcutInfo && mUser.equals(info.user)) { @@ -206,9 +209,7 @@ public class PackageUpdatedTask extends BaseModelUpdateTask { } } - // For system apps, package manager send OP_UPDATE when an - // app is enabled. - if (si.isPromise() && (mOp == OP_ADD || mOp == OP_UPDATE)) { + if (si.isPromise() && isNewApkAvailable) { if (si.hasStatusFlag(ShortcutInfo.FLAG_AUTOINSTALL_ICON)) { // Auto install icon LauncherAppsCompat launcherApps @@ -237,7 +238,7 @@ public class PackageUpdatedTask extends BaseModelUpdateTask { } } - if ((mOp == OP_ADD || mOp == OP_UPDATE) && + if (isNewApkAvailable && si.itemType == Favorites.ITEM_TYPE_APPLICATION) { iconCache.getTitleAndIcon(si, si.usingLowResIcon); infoUpdated = true; @@ -256,7 +257,7 @@ public class PackageUpdatedTask extends BaseModelUpdateTask { if (infoUpdated) { getModelWriter().updateItemInDatabase(si); } - } else if (info instanceof LauncherAppWidgetInfo && mOp == OP_ADD) { + } else if (info instanceof LauncherAppWidgetInfo && isNewApkAvailable) { LauncherAppWidgetInfo widgetInfo = (LauncherAppWidgetInfo) info; if (mUser.equals(widgetInfo.user) && widgetInfo.hasRestoreFlag(LauncherAppWidgetInfo.FLAG_PROVIDER_NOT_READY) @@ -346,7 +347,8 @@ public class PackageUpdatedTask extends BaseModelUpdateTask { } }); } else if (Utilities.ATLEAST_OREO && mOp == OP_ADD) { - // Load widgets for the new package. + // Load widgets for the new package. Changes due to app updates are handled through + // AppWidgetHost events, this is just to initialize the long-press options. for (int i = 0; i < N; i++) { dataModel.widgetsModel.update(app, new PackageUserKey(packages[i], mUser)); } |