diff options
author | Vadim Tryshev <vadimt@google.com> | 2018-05-18 18:41:34 -0700 |
---|---|---|
committer | Vadim Tryshev <vadimt@google.com> | 2018-05-18 18:41:34 -0700 |
commit | 98913d0c95d0eb0be706cc70b1edb44283d9d8f3 (patch) | |
tree | 68a89ea8db7fef806a5182b66c852a01ef6360a7 /src | |
parent | b05b489f040b8c3bb9ec044fd764a906c538b682 (diff) | |
download | android_packages_apps_Trebuchet-98913d0c95d0eb0be706cc70b1edb44283d9d8f3.tar.gz android_packages_apps_Trebuchet-98913d0c95d0eb0be706cc70b1edb44283d9d8f3.tar.bz2 android_packages_apps_Trebuchet-98913d0c95d0eb0be706cc70b1edb44283d9d8f3.zip |
Remove code duplication
Bug: 72222505
Test: Manual
Change-Id: I6ae6ac7474b44c16bd765635e32d2e843bc02cac
Diffstat (limited to 'src')
-rw-r--r-- | src/com/android/launcher3/PagedView.java | 36 | ||||
-rw-r--r-- | src/com/android/launcher3/Workspace.java | 12 |
2 files changed, 22 insertions, 26 deletions
diff --git a/src/com/android/launcher3/PagedView.java b/src/com/android/launcher3/PagedView.java index a71fbf161..efbd00489 100644 --- a/src/com/android/launcher3/PagedView.java +++ b/src/com/android/launcher3/PagedView.java @@ -1495,12 +1495,20 @@ public abstract class PagedView<T extends View & PageIndicator> extends ViewGrou return Math.abs(delta) > 0; } - public void scrollLeft() { - if (getNextPage() > 0) snapToPage(getNextPage() - 1); + public boolean scrollLeft() { + if (getNextPage() > 0) { + snapToPage(getNextPage() - 1); + return true; + } + return false; } - public void scrollRight() { - if (getNextPage() < getChildCount() -1) snapToPage(getNextPage() + 1); + public boolean scrollRight() { + if (getNextPage() < getChildCount() - 1) { + snapToPage(getNextPage() + 1); + return true; + } + return false; } @Override @@ -1551,22 +1559,6 @@ public abstract class PagedView<T extends View & PageIndicator> extends ViewGrou event.setScrollable(getPageCount() > 1); } - private boolean accessibilityScrollLeft() { - if (getCurrentPage() > 0) { - scrollLeft(); - return true; - } - return false; - } - - private boolean accessibilityScrollRight() { - if (getCurrentPage() < getPageCount() - 1) { - scrollRight(); - return true; - } - return false; - } - @Override public boolean performAccessibilityAction(int action, Bundle arguments) { if (super.performAccessibilityAction(action, arguments)) { @@ -1575,12 +1567,12 @@ public abstract class PagedView<T extends View & PageIndicator> extends ViewGrou final boolean pagesFlipped = isPageOrderFlipped(); switch (action) { case AccessibilityNodeInfo.ACTION_SCROLL_FORWARD: { - if (pagesFlipped ? accessibilityScrollLeft() : accessibilityScrollRight()) { + if (pagesFlipped ? scrollLeft() : scrollRight()) { return true; } } break; case AccessibilityNodeInfo.ACTION_SCROLL_BACKWARD: { - if (pagesFlipped ? accessibilityScrollRight() : accessibilityScrollLeft()) { + if (pagesFlipped ? scrollRight() : scrollLeft()) { return true; } } diff --git a/src/com/android/launcher3/Workspace.java b/src/com/android/launcher3/Workspace.java index 2df34d51f..6631f771c 100644 --- a/src/com/android/launcher3/Workspace.java +++ b/src/com/android/launcher3/Workspace.java @@ -2961,25 +2961,29 @@ public class Workspace extends PagedView<WorkspacePageIndicator> } @Override - public void scrollLeft() { + public boolean scrollLeft() { + boolean result = false; if (!workspaceInModalState() && !mIsSwitchingState) { - super.scrollLeft(); + result = super.scrollLeft(); } Folder openFolder = Folder.getOpen(mLauncher); if (openFolder != null) { openFolder.completeDragExit(); } + return result; } @Override - public void scrollRight() { + public boolean scrollRight() { + boolean result = false; if (!workspaceInModalState() && !mIsSwitchingState) { - super.scrollRight(); + result = super.scrollRight(); } Folder openFolder = Folder.getOpen(mLauncher); if (openFolder != null) { openFolder.completeDragExit(); } + return result; } /** |