diff options
author | Michael Jurka <mikejurka@google.com> | 2011-07-22 18:00:21 -0700 |
---|---|---|
committer | Michael Jurka <mikejurka@google.com> | 2011-07-23 12:48:57 -0700 |
commit | 19e0fc53c43a7746d7ae3d7c6027166bded33f0f (patch) | |
tree | 42c7129fdf4e6d7e04dd1f9a5a45d6ce52b50e9d /src/com | |
parent | 1228b3bc8e523ad07bcac602d89890690c9f06ef (diff) | |
download | android_packages_apps_Trebuchet-19e0fc53c43a7746d7ae3d7c6027166bded33f0f.tar.gz android_packages_apps_Trebuchet-19e0fc53c43a7746d7ae3d7c6027166bded33f0f.tar.bz2 android_packages_apps_Trebuchet-19e0fc53c43a7746d7ae3d7c6027166bded33f0f.zip |
Fix two crashes
- NPE: bug #4984219
- IllegalStateException: bug #4969695
Change-Id: Iaf02e669b26f9277388e0e7bffd532220ebf9bb1
Diffstat (limited to 'src/com')
-rw-r--r-- | src/com/android/launcher2/AppsCustomizeTabHost.java | 5 | ||||
-rw-r--r-- | src/com/android/launcher2/Launcher.java | 18 |
2 files changed, 15 insertions, 8 deletions
diff --git a/src/com/android/launcher2/AppsCustomizeTabHost.java b/src/com/android/launcher2/AppsCustomizeTabHost.java index ed408df48..d3215f093 100644 --- a/src/com/android/launcher2/AppsCustomizeTabHost.java +++ b/src/com/android/launcher2/AppsCustomizeTabHost.java @@ -207,7 +207,10 @@ public class AppsCustomizeTabHost extends TabHost implements LauncherTransitiona /* LauncherTransitionable overrides */ @Override public void onLauncherTransitionStart(Animator animation) { - if (animation != null) { + // isHardwareAccelerated() checks if we're attached to a window and if that + // window is HW accelerated-- we were sometimes not attached to a window + // and buildLayer was throwing an IllegalStateException + if (animation != null && isHardwareAccelerated()) { // Turn on hardware layers for performance setLayerType(LAYER_TYPE_HARDWARE, null); diff --git a/src/com/android/launcher2/Launcher.java b/src/com/android/launcher2/Launcher.java index af8d986b9..e318960f8 100644 --- a/src/com/android/launcher2/Launcher.java +++ b/src/com/android/launcher2/Launcher.java @@ -2593,14 +2593,18 @@ public final class Launcher extends Activity ImageView button = (ImageView) findViewById(buttonId); Drawable toolbarIcon = getExternalPackageToolbarIcon(activityName); - // If we were unable to find the icon via the meta-data, use a generic one - if (toolbarIcon == null) { - button.setImageResource(fallbackDrawableId); - return null; - } else { - button.setImageDrawable(toolbarIcon); - return toolbarIcon.getConstantState(); + if (button != null) { + // If we were unable to find the icon via the meta-data, use a + // generic one + if (toolbarIcon == null) { + button.setImageResource(fallbackDrawableId); + } else { + button.setImageDrawable(toolbarIcon); + } } + + return toolbarIcon != null ? toolbarIcon.getConstantState() : null; + } private void updateTextButtonWithDrawable(int buttonId, Drawable.ConstantState d) { |