summaryrefslogtreecommitdiffstats
path: root/src/com/android/launcher2/AppsCustomizePagedView.java
diff options
context:
space:
mode:
authorWinson Chung <winsonc@google.com>2012-04-12 14:04:41 -0700
committerWinson Chung <winsonc@google.com>2012-04-12 16:21:17 -0700
commita5c9636f563a2fa5bd3c97266894e002453b13dc (patch)
tree7a4a719f462036435cf656894331825d6e434f9d /src/com/android/launcher2/AppsCustomizePagedView.java
parent2c2b28ae557f83b3d114afeedb61c546a503eb99 (diff)
downloadandroid_packages_apps_Trebuchet-a5c9636f563a2fa5bd3c97266894e002453b13dc.tar.gz
android_packages_apps_Trebuchet-a5c9636f563a2fa5bd3c97266894e002453b13dc.tar.bz2
android_packages_apps_Trebuchet-a5c9636f563a2fa5bd3c97266894e002453b13dc.zip
Preventing widgets that don't fit from showing in tray. (Bug 6331357)
Change-Id: I9cbe85bed5c633f2be9b420eecbbee9a1b171e51
Diffstat (limited to 'src/com/android/launcher2/AppsCustomizePagedView.java')
-rw-r--r--src/com/android/launcher2/AppsCustomizePagedView.java16
1 files changed, 12 insertions, 4 deletions
diff --git a/src/com/android/launcher2/AppsCustomizePagedView.java b/src/com/android/launcher2/AppsCustomizePagedView.java
index 67ae1f112..3d5d06a11 100644
--- a/src/com/android/launcher2/AppsCustomizePagedView.java
+++ b/src/com/android/launcher2/AppsCustomizePagedView.java
@@ -480,7 +480,15 @@ public class AppsCustomizePagedView extends PagedViewWithDraggableItems implemen
List<ResolveInfo> shortcuts = mPackageManager.queryIntentActivities(shortcutsIntent, 0);
for (AppWidgetProviderInfo widget : widgets) {
if (widget.minWidth > 0 && widget.minHeight > 0) {
- mWidgets.add(widget);
+ // Ensure that all widgets we show can be added on a workspace of this size
+ int[] spanXY = mLauncher.getSpanForWidget(widget);
+ int[] minSpanXY = mLauncher.getMinSpanForWidget(widget);
+ int minSpanX = Math.min(spanXY[0], minSpanXY[0]);
+ int minSpanY = Math.min(spanXY[1], minSpanXY[1]);
+ if (minSpanX < LauncherModel.getCellCountX() &&
+ minSpanY < LauncherModel.getCellCountY()) {
+ mWidgets.add(widget);
+ }
} else {
Log.e(LOG_TAG, "Widget " + widget.provider + " has invalid dimensions (" +
widget.minWidth + ", " + widget.minHeight + ")");
@@ -1205,12 +1213,12 @@ public class AppsCustomizePagedView extends PagedViewWithDraggableItems implemen
createItemInfo = new PendingAddWidgetInfo(info, null, null);
// Determine the widget spans and min resize spans.
- int[] spanXY = mLauncher.getSpanForWidget(info, null);
+ int[] spanXY = mLauncher.getSpanForWidget(info);
int[] size = mLauncher.getWorkspace().estimateItemSize(spanXY[0],
spanXY[1], createItemInfo, true);
createItemInfo.spanX = spanXY[0];
createItemInfo.spanY = spanXY[1];
- int[] minSpanXY = mLauncher.getMinSpanForWidget(info, null);
+ int[] minSpanXY = mLauncher.getMinSpanForWidget(info);
createItemInfo.minSpanX = minSpanXY[0];
createItemInfo.minSpanY = minSpanXY[1];
@@ -1297,7 +1305,7 @@ public class AppsCustomizePagedView extends PagedViewWithDraggableItems implemen
Object rawInfo = items.get(i);
if (rawInfo instanceof AppWidgetProviderInfo) {
AppWidgetProviderInfo info = (AppWidgetProviderInfo) rawInfo;
- int[] cellSpans = mLauncher.getSpanForWidget(info, null);
+ int[] cellSpans = mLauncher.getSpanForWidget(info);
int maxWidth = Math.min(data.maxImageWidth,
mWidgetSpacingLayout.estimateCellWidth(cellSpans[0]));