diff options
author | Zak Cohen <zakcohen@google.com> | 2018-10-24 13:26:47 -0700 |
---|---|---|
committer | Zak Cohen <zakcohen@google.com> | 2018-10-26 11:25:58 -0700 |
commit | cc4c61472e53838946af48de926b76dbf6bc4a36 (patch) | |
tree | 03d2198b99a7c2c250aa37400024fd250b0f9aec /res | |
parent | 2c8927889544556a3b13d77130076e2d0f862f43 (diff) | |
download | android_packages_apps_Trebuchet-cc4c61472e53838946af48de926b76dbf6bc4a36.tar.gz android_packages_apps_Trebuchet-cc4c61472e53838946af48de926b76dbf6bc4a36.tar.bz2 android_packages_apps_Trebuchet-cc4c61472e53838946af48de926b76dbf6bc4a36.zip |
DeepShortcut - show loading placeholder before content is available.
Sometimes the deep shortcuts can take time to load, show an initial loading
state before any text is set.
Note: changed singleLine to lines=1 as the former causes issues with RTL
layout and is deprecated.
Bug: 78620208
Tested: manual test on pixel 3
Change-Id: I782addb8d64425a1a95cee4f104fc0bd44809815
Diffstat (limited to 'res')
-rw-r--r-- | res/drawable-v26/ic_deepshortcut_placeholder.xml | 20 | ||||
-rw-r--r-- | res/drawable/deep_shortcuts_text_placeholder.xml | 21 | ||||
-rw-r--r-- | res/drawable/ic_deepshortcut_placeholder.xml | 22 | ||||
-rw-r--r-- | res/layout/deep_shortcut.xml | 3 | ||||
-rw-r--r-- | res/values/styles.xml | 2 |
5 files changed, 66 insertions, 2 deletions
diff --git a/res/drawable-v26/ic_deepshortcut_placeholder.xml b/res/drawable-v26/ic_deepshortcut_placeholder.xml new file mode 100644 index 000000000..3fa85065b --- /dev/null +++ b/res/drawable-v26/ic_deepshortcut_placeholder.xml @@ -0,0 +1,20 @@ +<?xml version="1.0" encoding="utf-8"?> +<!-- + Copyright (C) 2017 The Android Open Source Project + + Licensed under the Apache License, Version 2.0 (the "License"); + you may not use this file except in compliance with the License. + You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android"> + <background android:drawable="?attr/popupColorSecondary"/> + <foreground android:drawable="?attr/popupColorSecondary"/> +</adaptive-icon> diff --git a/res/drawable/deep_shortcuts_text_placeholder.xml b/res/drawable/deep_shortcuts_text_placeholder.xml new file mode 100644 index 000000000..99da50fdc --- /dev/null +++ b/res/drawable/deep_shortcuts_text_placeholder.xml @@ -0,0 +1,21 @@ +<?xml version="1.0" encoding="utf-8"?> +<!-- Copyright (C) 2016 The Android Open Source Project + + Licensed under the Apache License, Version 2.0 (the "License"); + you may not use this file except in compliance with the License. + You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<shape xmlns:android="http://schemas.android.com/apk/res/android" + android:shape="rectangle"> + <solid android:color="?attr/popupColorSecondary" /> + <corners android:radius="8dp" /> + <size android:height="16dp" /> +</shape> diff --git a/res/drawable/ic_deepshortcut_placeholder.xml b/res/drawable/ic_deepshortcut_placeholder.xml new file mode 100644 index 000000000..85a969450 --- /dev/null +++ b/res/drawable/ic_deepshortcut_placeholder.xml @@ -0,0 +1,22 @@ +<?xml version="1.0" encoding="utf-8"?> +<!-- Copyright (C) 2016 The Android Open Source Project + + Licensed under the Apache License, Version 2.0 (the "License"); + you may not use this file except in compliance with the License. + You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<shape xmlns:android="http://schemas.android.com/apk/res/android" + android:shape="oval"> + <solid android:color="?attr/popupColorSecondary" /> + <size + android:height="32dp" + android:width="32dp" /> +</shape> diff --git a/res/layout/deep_shortcut.xml b/res/layout/deep_shortcut.xml index 4a2ad4225..92f70e661 100644 --- a/res/layout/deep_shortcut.xml +++ b/res/layout/deep_shortcut.xml @@ -43,7 +43,8 @@ android:layout_width="@dimen/deep_shortcut_icon_size" android:layout_height="@dimen/deep_shortcut_icon_size" android:layout_marginStart="@dimen/popup_padding_start" - android:layout_gravity="start|center_vertical" /> + android:layout_gravity="start|center_vertical" + android:background="@drawable/ic_deepshortcut_placeholder"/> <View android:id="@+id/divider" diff --git a/res/values/styles.xml b/res/values/styles.xml index 7b11891a6..e6791aa29 100644 --- a/res/values/styles.xml +++ b/res/values/styles.xml @@ -144,7 +144,7 @@ <item name="android:layout_gravity">center</item> <item name="android:focusable">true</item> <item name="android:gravity">center_horizontal</item> - <item name="android:singleLine">true</item> + <item name="android:lines">1</item> <item name="android:textColor">?android:attr/textColorSecondary</item> <item name="android:fontFamily">sans-serif-condensed</item> <item name="android:defaultFocusHighlightEnabled">false</item> |