summaryrefslogtreecommitdiffstats
path: root/quickstep/src
diff options
context:
space:
mode:
authorWinson Chung <winsonc@google.com>2018-10-29 10:45:25 -0700
committerWinson Chung <winsonc@google.com>2018-10-29 10:51:10 -0700
commitf107c9ef6ddc59763c1b60507c6ea7b09ecee8f9 (patch)
tree5265571e8ba54b675785ad3294ae564d58b1f3e2 /quickstep/src
parentd4dc9545c3a39d283e138cdb88a44f28521b786e (diff)
downloadandroid_packages_apps_Trebuchet-f107c9ef6ddc59763c1b60507c6ea7b09ecee8f9.tar.gz
android_packages_apps_Trebuchet-f107c9ef6ddc59763c1b60507c6ea7b09ecee8f9.tar.bz2
android_packages_apps_Trebuchet-f107c9ef6ddc59763c1b60507c6ea7b09ecee8f9.zip
Fixing regression in background task loading.
Bug: 117603579 Test: Take systrace, ensure that we aren't loading thumbnails on the UI thread Change-Id: I4b522246a5ab12dc37c1dffdccd05232bbc1f6fe
Diffstat (limited to 'quickstep/src')
-rw-r--r--quickstep/src/com/android/quickstep/RecentsModel.java2
-rw-r--r--quickstep/src/com/android/quickstep/TaskThumbnailCache.java5
2 files changed, 4 insertions, 3 deletions
diff --git a/quickstep/src/com/android/quickstep/RecentsModel.java b/quickstep/src/com/android/quickstep/RecentsModel.java
index e184a9bb1..2e4d4d2b8 100644
--- a/quickstep/src/com/android/quickstep/RecentsModel.java
+++ b/quickstep/src/com/android/quickstep/RecentsModel.java
@@ -143,8 +143,8 @@ public class RecentsModel extends TaskStackChangeListener {
}
// Keep the cache up to date with the latest thumbnails
+ int runningTaskId = RecentsModel.getRunningTaskId();
mTaskList.getTasks(mThumbnailCache.getCacheSize(), true /* keysOnly */, (tasks) -> {
- int runningTaskId = RecentsModel.getRunningTaskId();
for (Task task : tasks) {
if (task.key.id == runningTaskId) {
// Skip the running task, it's not going to have an up-to-date snapshot by the
diff --git a/quickstep/src/com/android/quickstep/TaskThumbnailCache.java b/quickstep/src/com/android/quickstep/TaskThumbnailCache.java
index c47101b82..61a191f3f 100644
--- a/quickstep/src/com/android/quickstep/TaskThumbnailCache.java
+++ b/quickstep/src/com/android/quickstep/TaskThumbnailCache.java
@@ -108,8 +108,9 @@ public class TaskThumbnailCache {
Preconditions.assertUIThread();
// Fetch the thumbnail for this task and put it in the cache
- mCache.put(task.key, ActivityManagerWrapper.getInstance().getTaskThumbnail(
- task.key.id, true /* reducedResolution */));
+ updateThumbnailInBackground(task, true /* reducedResolution */, (t) -> {
+ mCache.put(task.key, t.thumbnail);
+ });
}