diff options
| author | James O'Leary <jamesoleary@google.com> | 2019-07-25 10:22:02 -0400 |
|---|---|---|
| committer | James O'Leary <jamesoleary@google.com> | 2019-07-25 10:22:02 -0400 |
| commit | 74ece6b021eaf824ebf9219383d86e6860ac6088 (patch) | |
| tree | 6b2c15f7cd31022f9d63e188d9b85401a139454f /quickstep/recents_ui_overrides/src/com/android/quickstep/FallbackActivityControllerHelper.java | |
| parent | 11b5535556cc3d53d7e521715178ddcd4b708daf (diff) | |
| download | android_packages_apps_Trebuchet-74ece6b021eaf824ebf9219383d86e6860ac6088.tar.gz android_packages_apps_Trebuchet-74ece6b021eaf824ebf9219383d86e6860ac6088.tar.bz2 android_packages_apps_Trebuchet-74ece6b021eaf824ebf9219383d86e6860ac6088.zip | |
Fix QSB becoming invisible
This could not be reproduced until I removed a line that wouldn't call
onAssistantVisiblityChanged if the argument was the same value as the
argument as the previous call.
After that, the bug became readily reproducible. I traced through
Launcher till I found that FallbackActivityControllerHelper
.onAssistantVisibilityChanged was being called while the screen was
locked, proving that onAssistantVisiblityChanged was _not_ reaching
launcher.
Test: Verify bug no longer reproduces.
Bug: 134981174
Bug: 135247753
Bug: 135572849
Bug: 135733393
Bug: 136386749
Bug: 136776987
Bug: 137534772
Bug: 137764419
Change-Id: Ib5e8df3b5030a77c5df351a1fcd993db6bd602fc
Diffstat (limited to 'quickstep/recents_ui_overrides/src/com/android/quickstep/FallbackActivityControllerHelper.java')
| -rw-r--r-- | quickstep/recents_ui_overrides/src/com/android/quickstep/FallbackActivityControllerHelper.java | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/quickstep/recents_ui_overrides/src/com/android/quickstep/FallbackActivityControllerHelper.java b/quickstep/recents_ui_overrides/src/com/android/quickstep/FallbackActivityControllerHelper.java index c43155b73..8c5a78823 100644 --- a/quickstep/recents_ui_overrides/src/com/android/quickstep/FallbackActivityControllerHelper.java +++ b/quickstep/recents_ui_overrides/src/com/android/quickstep/FallbackActivityControllerHelper.java @@ -80,7 +80,9 @@ public final class FallbackActivityControllerHelper implements @Override public void onAssistantVisibilityChanged(float visibility) { - // TODO: + // This class becomes active when the screen is locked. + // Rather than having it handle assistant visibility changes, the assistant visibility is + // set to zero prior to this class becoming active. } @NonNull |