diff options
author | Kevin <kevhan@google.com> | 2019-03-04 10:55:13 -0800 |
---|---|---|
committer | Kevin <kevhan@google.com> | 2019-03-13 12:59:39 -0700 |
commit | 100e1263e245654f9889b5a370093dd24fdd19ac (patch) | |
tree | 30f9ab0b3fd5b12bfe8d366ccff16a71646ade56 /go | |
parent | a086df004759d2003143294c55f5968bdea378a1 (diff) | |
download | android_packages_apps_Trebuchet-100e1263e245654f9889b5a370093dd24fdd19ac.tar.gz android_packages_apps_Trebuchet-100e1263e245654f9889b5a370093dd24fdd19ac.tar.bz2 android_packages_apps_Trebuchet-100e1263e245654f9889b5a370093dd24fdd19ac.zip |
Add thumbnails to the task view.
This CL adds thumbnails to the task view so that the labels are next to
a combined view with the thumbnail to the left and the icon at the
bottom right.
Due to the way launcher creates shadows on icons, the icons are actually
smaller than desired, so there need to be further changes to determine
the appropriate scale in order to have the bottom of the icons be flush
with the snapshot's bottom.
Bug: 114136250
Test: Launch l3GoIconRecents, see thumbnails + icon
Change-Id: Ief1cf54634544b9e310c68588998901871efda44
Diffstat (limited to 'go')
-rw-r--r-- | go/quickstep/res/layout/task_item_view.xml | 20 | ||||
-rw-r--r-- | go/quickstep/res/values/dimens.xml | 21 | ||||
-rw-r--r-- | go/quickstep/src/com/android/quickstep/TaskHolder.java | 1 | ||||
-rw-r--r-- | go/quickstep/src/com/android/quickstep/views/TaskItemView.java | 19 |
4 files changed, 55 insertions, 6 deletions
diff --git a/go/quickstep/res/layout/task_item_view.xml b/go/quickstep/res/layout/task_item_view.xml index 90940c495..ee67d49fc 100644 --- a/go/quickstep/res/layout/task_item_view.xml +++ b/go/quickstep/res/layout/task_item_view.xml @@ -19,12 +19,24 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:orientation="horizontal"> - <ImageView + <FrameLayout android:id="@+id/task_icon_and_thumbnail" - android:layout_width="@dimen/task_thumbnail_icon_size" - android:layout_height="@dimen/task_thumbnail_icon_size" + android:layout_width="@dimen/task_item_height" + android:layout_height="@dimen/task_item_height" android:layout_gravity="center_vertical" - android:layout_marginHorizontal="8dp"/> + android:layout_marginHorizontal="8dp" + android:layout_marginVertical="@dimen/task_item_half_vert_margin"> + <ImageView + android:id="@+id/task_thumbnail" + android:layout_width="wrap_content" + android:layout_height="match_parent" + android:layout_gravity="top|start"/> + <ImageView + android:id="@+id/task_icon" + android:layout_width="@dimen/task_icon_size" + android:layout_height="@dimen/task_icon_size" + android:layout_gravity="bottom|end"/> + </FrameLayout> <TextView android:id="@+id/task_label" android:layout_width="wrap_content" diff --git a/go/quickstep/res/values/dimens.xml b/go/quickstep/res/values/dimens.xml new file mode 100644 index 000000000..28cc1ebe6 --- /dev/null +++ b/go/quickstep/res/values/dimens.xml @@ -0,0 +1,21 @@ +<?xml version="1.0" encoding="utf-8"?> +<!-- + Copyright (C) 2019 The Android Open Source Project + + Licensed under the Apache License, Version 2.0 (the "License"); + you may not use this file except in compliance with the License. + You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<resources> + <dimen name="task_item_height">60dp</dimen> + <dimen name="task_item_half_vert_margin">8dp</dimen> + <dimen name="task_icon_size">36dp</dimen> +</resources>
\ No newline at end of file diff --git a/go/quickstep/src/com/android/quickstep/TaskHolder.java b/go/quickstep/src/com/android/quickstep/TaskHolder.java index 67e8ece22..8d5e4d55f 100644 --- a/go/quickstep/src/com/android/quickstep/TaskHolder.java +++ b/go/quickstep/src/com/android/quickstep/TaskHolder.java @@ -45,6 +45,7 @@ final class TaskHolder extends ViewHolder { mTask = task; mTaskItemView.setLabel(task.titleDescription); mTaskItemView.setIcon(task.icon); + mTaskItemView.setThumbnail(task.thumbnail.thumbnail); } /** diff --git a/go/quickstep/src/com/android/quickstep/views/TaskItemView.java b/go/quickstep/src/com/android/quickstep/views/TaskItemView.java index ce3947d24..3818965b7 100644 --- a/go/quickstep/src/com/android/quickstep/views/TaskItemView.java +++ b/go/quickstep/src/com/android/quickstep/views/TaskItemView.java @@ -16,6 +16,7 @@ package com.android.quickstep.views; import android.content.Context; +import android.graphics.Bitmap; import android.graphics.drawable.Drawable; import android.util.AttributeSet; import android.widget.ImageView; @@ -31,6 +32,7 @@ public final class TaskItemView extends LinearLayout { private TextView mLabelView; private ImageView mIconView; + private ImageView mThumbnailView; public TaskItemView(Context context, AttributeSet attrs) { super(context, attrs); @@ -40,7 +42,8 @@ public final class TaskItemView extends LinearLayout { protected void onFinishInflate() { super.onFinishInflate(); mLabelView = findViewById(R.id.task_label); - mIconView = findViewById(R.id.task_icon_and_thumbnail); + mThumbnailView = findViewById(R.id.task_thumbnail); + mIconView = findViewById(R.id.task_icon); } /** @@ -58,7 +61,19 @@ public final class TaskItemView extends LinearLayout { * @param icon task icon */ public void setIcon(Drawable icon) { + // TODO: Scale the icon up based off the padding on the side + // The icon proper is actually smaller than the drawable and has "padding" on the side for + // the purpose of drawing the shadow, allowing the icon to pop up, so we need to scale the + // view if we want the icon to be flush with the bottom of the thumbnail. mIconView.setImageDrawable(icon); - // TODO: Add in combination drawable for icon + thumbnail + } + + /** + * Set the task thumbnail for the task. + * + * @param thumbnail task thumbnail for the task + */ + public void setThumbnail(Bitmap thumbnail) { + mThumbnailView.setImageBitmap(thumbnail); } } |