summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAdam Cohen <adamcohen@google.com>2011-09-29 17:33:15 -0700
committerAdam Cohen <adamcohen@google.com>2011-09-29 17:33:15 -0700
commit36cc09b07b19198f4ea886583cef462ade27192c (patch)
treebac89b3841ec196aa3015fdea3dbfa06c996a6a4
parent57e1beecacad725fcfd1a55faf3cfc3930b9f877 (diff)
downloadandroid_packages_apps_Trebuchet-36cc09b07b19198f4ea886583cef462ade27192c.tar.gz
android_packages_apps_Trebuchet-36cc09b07b19198f4ea886583cef462ade27192c.tar.bz2
android_packages_apps_Trebuchet-36cc09b07b19198f4ea886583cef462ade27192c.zip
Fixing issue with cancelled drag blocking cell spaces (Issue 5386523)
Change-Id: I9cfc728edeeee2237c21935517107e7a2af49646
-rw-r--r--src/com/android/launcher2/DragController.java1
-rw-r--r--src/com/android/launcher2/DropTarget.java3
-rw-r--r--src/com/android/launcher2/Workspace.java3
3 files changed, 7 insertions, 0 deletions
diff --git a/src/com/android/launcher2/DragController.java b/src/com/android/launcher2/DragController.java
index afbf80d17..ca7e55b64 100644
--- a/src/com/android/launcher2/DragController.java
+++ b/src/com/android/launcher2/DragController.java
@@ -361,6 +361,7 @@ public class DragController {
if (mLastDropTarget != null) {
mLastDropTarget.onDragExit(mDragObject);
}
+ mDragObject.cancelled = true;
mDragObject.dragComplete = true;
mDragObject.dragSource.onDropCompleted(null, mDragObject, false);
}
diff --git a/src/com/android/launcher2/DropTarget.java b/src/com/android/launcher2/DropTarget.java
index 34fa89316..4172da243 100644
--- a/src/com/android/launcher2/DropTarget.java
+++ b/src/com/android/launcher2/DropTarget.java
@@ -52,6 +52,9 @@ public interface DropTarget {
/** Post drag animation runnable */
public Runnable postAnimationRunnable = null;
+ /** Indicates that the drag operation was cancelled */
+ public boolean cancelled = false;
+
public DragObject() {
}
}
diff --git a/src/com/android/launcher2/Workspace.java b/src/com/android/launcher2/Workspace.java
index 44c533b95..873c03841 100644
--- a/src/com/android/launcher2/Workspace.java
+++ b/src/com/android/launcher2/Workspace.java
@@ -3051,6 +3051,9 @@ public class Workspace extends SmoothPagedView
}
cellLayout.onDropChild(mDragInfo.cell);
}
+ if (d.cancelled && mDragInfo.cell != null) {
+ mDragInfo.cell.setVisibility(VISIBLE);
+ }
mDragOutline = null;
mDragInfo = null;
}