diff options
author | Sunny Goyal <sunnygoyal@google.com> | 2017-08-15 12:54:42 -0700 |
---|---|---|
committer | Sunny Goyal <sunnygoyal@google.com> | 2017-08-15 12:55:16 -0700 |
commit | 1fe0c2ca085a284936ac04fdb32b0cd9b82e9c4d (patch) | |
tree | d2122c8bb755482cd17e067b267ac265392c0101 | |
parent | 492617f4c48155c2efc4f07464c8f86625590367 (diff) | |
download | android_packages_apps_Trebuchet-1fe0c2ca085a284936ac04fdb32b0cd9b82e9c4d.tar.gz android_packages_apps_Trebuchet-1fe0c2ca085a284936ac04fdb32b0cd9b82e9c4d.tar.bz2 android_packages_apps_Trebuchet-1fe0c2ca085a284936ac04fdb32b0cd9b82e9c4d.zip |
Simpifying uninstall drop target to check item type instead of class instance
Bug: 64719848
Change-Id: I34c13b461e204fbdc2c5b4ed6fa92564ebd5439a
-rw-r--r-- | src/com/android/launcher3/UninstallDropTarget.java | 20 |
1 files changed, 6 insertions, 14 deletions
diff --git a/src/com/android/launcher3/UninstallDropTarget.java b/src/com/android/launcher3/UninstallDropTarget.java index 45c14d6bb..e15cf9f50 100644 --- a/src/com/android/launcher3/UninstallDropTarget.java +++ b/src/com/android/launcher3/UninstallDropTarget.java @@ -42,7 +42,7 @@ public class UninstallDropTarget extends ButtonDropTarget { return supportsDrop(getContext(), info); } - public static boolean supportsDrop(Context context, Object info) { + public static boolean supportsDrop(Context context, ItemInfo info) { UserManager userManager = (UserManager) context.getSystemService(Context.USER_SERVICE); Bundle restrictions = userManager.getUserRestrictions(); if (restrictions.getBoolean(UserManager.DISALLOW_APPS_CONTROL, false) @@ -56,21 +56,13 @@ public class UninstallDropTarget extends ButtonDropTarget { /** * @return the component name that should be uninstalled or null. */ - private static ComponentName getUninstallTarget(Context context, Object item) { + private static ComponentName getUninstallTarget(Context context, ItemInfo item) { Intent intent = null; UserHandle user = null; - if (item instanceof AppInfo) { - AppInfo info = (AppInfo) item; - intent = info.intent; - user = info.user; - } else if (item instanceof ShortcutInfo) { - ShortcutInfo info = (ShortcutInfo) item; - if (info.itemType == LauncherSettings.BaseLauncherColumns.ITEM_TYPE_APPLICATION) { - // Do not use restore/target intent here as we cannot uninstall an app which is - // being installed/restored. - intent = info.intent; - user = info.user; - } + if (item != null && + item.itemType == LauncherSettings.BaseLauncherColumns.ITEM_TYPE_APPLICATION) { + intent = item.getIntent(); + user = item.user; } if (intent != null) { LauncherActivityInfo info = LauncherAppsCompat.getInstance(context) |