diff options
author | Michael Jurka <mikejurka@google.com> | 2013-10-23 15:21:32 +0200 |
---|---|---|
committer | Danesh M <daneshm90@gmail.com> | 2014-06-05 23:03:34 -0700 |
commit | fd53a2f6d262566ae09e17f65146664e22a488b3 (patch) | |
tree | 1e04d9e5035894c03b44a3d2fe943408fe6b6c37 | |
parent | 19d82288407405b6ff7823a8821390c09b2e5f09 (diff) | |
download | android_packages_apps_Trebuchet-fd53a2f6d262566ae09e17f65146664e22a488b3.tar.gz android_packages_apps_Trebuchet-fd53a2f6d262566ae09e17f65146664e22a488b3.tar.bz2 android_packages_apps_Trebuchet-fd53a2f6d262566ae09e17f65146664e22a488b3.zip |
Prevent memory leaks coming from LauncherAnimUtils
Use weak references for global animation list
Bug: 11322014
Change-Id: I38bb9184e45840113129781fa83ab40ec96d3868
-rw-r--r-- | src/com/android/launcher3/LauncherAnimUtils.java | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/com/android/launcher3/LauncherAnimUtils.java b/src/com/android/launcher3/LauncherAnimUtils.java index 5d4f9c67e..e6c220b2a 100644 --- a/src/com/android/launcher3/LauncherAnimUtils.java +++ b/src/com/android/launcher3/LauncherAnimUtils.java @@ -25,12 +25,13 @@ import android.view.View; import android.view.ViewTreeObserver; import java.util.HashSet; +import java.util.WeakHashMap; public class LauncherAnimUtils { - static HashSet<Animator> sAnimators = new HashSet<Animator>(); + static WeakHashMap<Animator, Object> sAnimators = new WeakHashMap<Animator, Object>(); static Animator.AnimatorListener sEndAnimListener = new Animator.AnimatorListener() { public void onAnimationStart(Animator animation) { - sAnimators.add(animation); + sAnimators.put(animation, null); } public void onAnimationRepeat(Animator animation) { @@ -74,13 +75,12 @@ public class LauncherAnimUtils { } public static void onDestroyActivity() { - HashSet<Animator> animators = new HashSet<Animator>(sAnimators); + HashSet<Animator> animators = new HashSet<Animator>(sAnimators.keySet()); for (Animator a : animators) { if (a.isRunning()) { a.cancel(); - } else { - sAnimators.remove(a); } + sAnimators.remove(a); } } |