From a78d012468101b86c3937c5d4c6cb6ef48d04745 Mon Sep 17 00:00:00 2001 From: Jay Wang Date: Thu, 12 Nov 2015 18:43:02 -0800 Subject: SnapdragonCamera: Fix crash issue when changing TNR setting Move the UI setting change to the UI thread instead of in Camera thread. CRs-Fixed: 931802 Change-Id: Ia38d0adf426c4ef7b3424df9649392ead9b0e604 --- src/com/android/camera/PhotoModule.java | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) (limited to 'src/com') diff --git a/src/com/android/camera/PhotoModule.java b/src/com/android/camera/PhotoModule.java index 3615d948a..dc372a303 100644 --- a/src/com/android/camera/PhotoModule.java +++ b/src/com/android/camera/PhotoModule.java @@ -3058,15 +3058,26 @@ public class PhotoModule pref_camera_tnr_value_off))) { mParameters.set(CameraSettings.KEY_QC_CDS_MODE, mActivity.getString(R.string.pref_camera_cds_value_off)); - mUI.overrideSettings(CameraSettings.KEY_QC_CDS_MODE, - mActivity.getString(R.string.pref_camera_cds_value_off)); + mActivity.runOnUiThread(new Runnable() { + @Override + public void run() { + mUI.overrideSettings(CameraSettings.KEY_QC_CDS_MODE, + mActivity.getString(R.string.pref_camera_cds_value_off)); + } + }); if (cds != null) { mPrevSavedCDS = cds; } isTNREnabled = true; } else if (isTNREnabled) { mParameters.set(CameraSettings.KEY_QC_CDS_MODE, mPrevSavedCDS); - mUI.overrideSettings(CameraSettings.KEY_QC_CDS_MODE, mPrevSavedCDS); + mActivity.runOnUiThread(new Runnable() { + @Override + public void run() { + mUI.overrideSettings(CameraSettings.KEY_QC_CDS_MODE, + mPrevSavedCDS); + } + }); isTNREnabled = false; } mParameters.set(CameraSettings.KEY_QC_TNR_MODE, tnr); -- cgit v1.2.3