From da4de5aa86b49be455efe396455b77be44dec684 Mon Sep 17 00:00:00 2001 From: nicolasroard Date: Mon, 28 Jan 2013 16:36:46 -0800 Subject: Refactor filters parameters - introduce FilterRepresentations - change filters lifecycle Change-Id: I9416fca47a334d532a347cd5577795738c870933 --- .../gallery3d/filtershow/filters/ImageFilterHue.java | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) (limited to 'src/com/android/gallery3d/filtershow/filters/ImageFilterHue.java') diff --git a/src/com/android/gallery3d/filtershow/filters/ImageFilterHue.java b/src/com/android/gallery3d/filtershow/filters/ImageFilterHue.java index 6b9869be3..51c476d6d 100644 --- a/src/com/android/gallery3d/filtershow/filters/ImageFilterHue.java +++ b/src/com/android/gallery3d/filtershow/filters/ImageFilterHue.java @@ -21,14 +21,21 @@ import com.android.gallery3d.filtershow.editors.BasicEditor; import android.graphics.Bitmap; -public class ImageFilterHue extends ImageFilter { +public class ImageFilterHue extends SimpleImageFilter { private ColorSpaceMatrix cmatrix = null; public ImageFilterHue() { mName = "Hue"; cmatrix = new ColorSpaceMatrix(); - mMaxParameter = 180; - mMinParameter = -180; + } + + public FilterRepresentation getDefaultRepresentation() { + FilterBasicRepresentation representation = (FilterBasicRepresentation) super.getDefaultRepresentation(); + representation.setName("Hue"); + representation.setFilterClass(ImageFilterHue.class); + representation.setMinimum(-180); + representation.setMaximum(180); + return representation; } @Override @@ -57,10 +64,12 @@ public class ImageFilterHue extends ImageFilter { @Override public Bitmap apply(Bitmap bitmap, float scaleFactor, boolean highQuality) { + if (getParameters() == null) { + return bitmap; + } int w = bitmap.getWidth(); int h = bitmap.getHeight(); - float p = mParameter; - float value = p; + float value = getParameters().getValue(); cmatrix.identity(); cmatrix.setHue(value); -- cgit v1.2.3