From ff0dba310d010dc19ee6968bc6a9ac7fc3615cbc Mon Sep 17 00:00:00 2001 From: John Reck Date: Wed, 26 Sep 2012 16:20:09 -0700 Subject: Only create debugTag if necessary Bug: 7238418 String concatenation isn't free Change-Id: I510a89ef8b673efb631d6f8929ab3d9d9b454931 --- src/com/android/gallery3d/data/ImageCacheRequest.java | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/com/android/gallery3d/data/ImageCacheRequest.java b/src/com/android/gallery3d/data/ImageCacheRequest.java index b977b1016..3f937e365 100644 --- a/src/com/android/gallery3d/data/ImageCacheRequest.java +++ b/src/com/android/gallery3d/data/ImageCacheRequest.java @@ -41,11 +41,14 @@ abstract class ImageCacheRequest implements Job { mTargetSize = targetSize; } + private String debugTag() { + return mPath + "," + + ((mType == MediaItem.TYPE_THUMBNAIL) ? "THUMB" : + (mType == MediaItem.TYPE_MICROTHUMBNAIL) ? "MICROTHUMB" : "?"); + } + @Override public Bitmap run(JobContext jc) { - String debugTag = mPath + "," + - ((mType == MediaItem.TYPE_THUMBNAIL) ? "THUMB" : - (mType == MediaItem.TYPE_MICROTHUMBNAIL) ? "MICROTHUMB" : "?"); ImageCacheService cacheService = mApplication.getImageCacheService(); BytesBuffer buffer = MediaItem.getBytesBufferPool().get(); @@ -66,7 +69,7 @@ abstract class ImageCacheRequest implements Job { MediaItem.getThumbPool()); } if (bitmap == null && !jc.isCancelled()) { - Log.w(TAG, "decode cached failed " + debugTag); + Log.w(TAG, "decode cached failed " + debugTag()); } return bitmap; } @@ -77,7 +80,7 @@ abstract class ImageCacheRequest implements Job { if (jc.isCancelled()) return null; if (bitmap == null) { - Log.w(TAG, "decode orig failed " + debugTag); + Log.w(TAG, "decode orig failed " + debugTag()); return null; } -- cgit v1.2.3