From f7a65f9be424a0f2de57556d69f97cc171889a67 Mon Sep 17 00:00:00 2001 From: Danny Baumann Date: Fri, 25 Mar 2016 13:02:27 +0100 Subject: Protect against multiple shutter callbacks per frame in longshot mode. Some devices send multiple shutter callbacks for one captured frame in longshot mode. As this causes mismatch between the calculated number of captured frames and the calculated number of JPEGs received for those, which in turn leads to longshot mode never being ended properly, protect against that scenario by discarding all but the first callback. Change-Id: I0c3a270f664a0cd16354fb0a13c5941a52001650 --- src/com/android/camera/PhotoModule.java | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/com/android/camera/PhotoModule.java b/src/com/android/camera/PhotoModule.java index e41eda475..57779445c 100644 --- a/src/com/android/camera/PhotoModule.java +++ b/src/com/android/camera/PhotoModule.java @@ -1100,6 +1100,11 @@ public class PhotoModule private final class LongshotShutterCallback implements CameraShutterCallback { + private int mExpectedLongshotSnapNum; + + public LongshotShutterCallback() { + mExpectedLongshotSnapNum = mLongshotSnapNum; + } @Override public void onShutter(CameraProxy camera) { @@ -1107,6 +1112,9 @@ public class PhotoModule mShutterLag = mShutterCallbackTime - mCaptureStartTime; Log.e(TAG, "[KPI Perf] PROFILE_SHUTTER_LAG mShutterLag = " + mShutterLag + "ms"); synchronized(mCameraDevice) { + if (mExpectedLongshotSnapNum != mLongshotSnapNum) { + return; + } if (++mLongshotSnapNum >= mLongShotMaxSnap && (mLongShotMaxSnap != -1)) { -- cgit v1.2.3