From c584b55146c51feda057bb0faa455f57cda76c8b Mon Sep 17 00:00:00 2001 From: Danny Baumann Date: Wed, 10 Feb 2016 13:08:59 +0100 Subject: De-uglify menu. Change-Id: I19d8a3d5a12c4be06bced056b80ad1a354c6b761 --- res/drawable/list_border.xml | 2 +- res/drawable/list_selector.xml | 34 ---------------------- res/drawable/scene_filter_item_bg.xml | 34 ++++++++++++++++++++++ res/drawable/scene_mode_view_border.xml | 36 ------------------------ res/drawable/scene_mode_view_border_selected.xml | 36 ------------------------ res/drawable/setting_list_item_bg.xml | 36 ++++++++++++++++++++++++ res/drawable/setting_picker.xml | 21 -------------- res/layout/camera_filmstrip.xml | 3 -- res/layout/filter_mode_view.xml | 11 +++----- res/layout/horiz_grid.xml | 1 - res/layout/list_menu.xml | 1 - res/layout/list_menu_item.xml | 8 ++---- res/layout/list_sub_menu.xml | 5 +--- res/layout/list_sub_menu_item.xml | 4 --- res/layout/scene_mode_view.xml | 8 +----- res/layout/vertical_grid.xml | 1 - res/values/colors.xml | 9 +++--- res/values/styles.xml | 6 ++-- src/com/android/camera/PhotoMenu.java | 21 +++++--------- src/com/android/camera/PhotoUI.java | 5 ++-- src/com/android/camera/VideoMenu.java | 11 +++----- src/com/android/camera/VideoUI.java | 4 +-- src/com/android/camera/ui/ListMenu.java | 7 ++--- 23 files changed, 105 insertions(+), 199 deletions(-) delete mode 100644 res/drawable/list_selector.xml create mode 100644 res/drawable/scene_filter_item_bg.xml delete mode 100644 res/drawable/scene_mode_view_border.xml delete mode 100644 res/drawable/scene_mode_view_border_selected.xml create mode 100644 res/drawable/setting_list_item_bg.xml delete mode 100644 res/drawable/setting_picker.xml diff --git a/res/drawable/list_border.xml b/res/drawable/list_border.xml index 1ab11ddfe..7d05a087f 100644 --- a/res/drawable/list_border.xml +++ b/res/drawable/list_border.xml @@ -29,7 +29,7 @@ - + - - - - - - - diff --git a/res/drawable/scene_filter_item_bg.xml b/res/drawable/scene_filter_item_bg.xml new file mode 100644 index 000000000..2e2b06343 --- /dev/null +++ b/res/drawable/scene_filter_item_bg.xml @@ -0,0 +1,34 @@ + + + + + + + + diff --git a/res/drawable/scene_mode_view_border.xml b/res/drawable/scene_mode_view_border.xml deleted file mode 100644 index 68431ece6..000000000 --- a/res/drawable/scene_mode_view_border.xml +++ /dev/null @@ -1,36 +0,0 @@ - - - - - - - diff --git a/res/drawable/scene_mode_view_border_selected.xml b/res/drawable/scene_mode_view_border_selected.xml deleted file mode 100644 index 535e2d168..000000000 --- a/res/drawable/scene_mode_view_border_selected.xml +++ /dev/null @@ -1,36 +0,0 @@ - - - - - - - diff --git a/res/drawable/setting_list_item_bg.xml b/res/drawable/setting_list_item_bg.xml new file mode 100644 index 000000000..079f036c0 --- /dev/null +++ b/res/drawable/setting_list_item_bg.xml @@ -0,0 +1,36 @@ + + + + + + + + + + diff --git a/res/drawable/setting_picker.xml b/res/drawable/setting_picker.xml deleted file mode 100644 index c3bff41ea..000000000 --- a/res/drawable/setting_picker.xml +++ /dev/null @@ -1,21 +0,0 @@ - - - - - - - diff --git a/res/layout/camera_filmstrip.xml b/res/layout/camera_filmstrip.xml index df6b7a267..30da433a3 100644 --- a/res/layout/camera_filmstrip.xml +++ b/res/layout/camera_filmstrip.xml @@ -51,9 +51,6 @@ android:text="@string/rendering_photo_sphere" android:textColor="@color/white" android:textSize="14sp" - android:shadowDx="0" - android:shadowDy="0" - android:shadowRadius="2" android:layout_width="wrap_content" android:layout_height="wrap_content" android:visibility="visible" diff --git a/res/layout/filter_mode_view.xml b/res/layout/filter_mode_view.xml index 558d7ce77..d4128f533 100644 --- a/res/layout/filter_mode_view.xml +++ b/res/layout/filter_mode_view.xml @@ -35,24 +35,21 @@ + android:background="@drawable/scene_filter_item_bg" + android:orientation="vertical" + android:padding="2dp"> + android:layout_gravity="center" /> diff --git a/res/layout/list_menu.xml b/res/layout/list_menu.xml index e110fd571..dd4354456 100644 --- a/res/layout/list_menu.xml +++ b/res/layout/list_menu.xml @@ -29,7 +29,6 @@ diff --git a/res/layout/list_menu_item.xml b/res/layout/list_menu_item.xml index f8addf82c..025bb607d 100644 --- a/res/layout/list_menu_item.xml +++ b/res/layout/list_menu_item.xml @@ -29,7 +29,7 @@ @@ -44,7 +45,6 @@ android:id="@+id/title" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:layout_alignTop="@+id/list_image" android:layout_toRightOf="@+id/list_image" android:textColor="@android:color/white" android:textStyle="bold" /> @@ -56,10 +56,6 @@ android:layout_below="@id/title" android:layout_marginTop="1dip" android:layout_toRightOf="@+id/list_image" - android:shadowColor="@android:color/black" - android:shadowDx="1" - android:shadowDy="1" - android:shadowRadius="2" android:text="@string/crop_save" android:textColor="@color/white" android:textSize="10dip" diff --git a/res/layout/list_sub_menu.xml b/res/layout/list_sub_menu.xml index eaab0948e..6d4ff1aff 100644 --- a/res/layout/list_sub_menu.xml +++ b/res/layout/list_sub_menu.xml @@ -29,11 +29,8 @@ diff --git a/res/layout/list_sub_menu_item.xml b/res/layout/list_sub_menu_item.xml index f2b043692..472462885 100644 --- a/res/layout/list_sub_menu_item.xml +++ b/res/layout/list_sub_menu_item.xml @@ -42,10 +42,6 @@ diff --git a/res/layout/scene_mode_view.xml b/res/layout/scene_mode_view.xml index d4c2a259c..88d6e89d4 100644 --- a/res/layout/scene_mode_view.xml +++ b/res/layout/scene_mode_view.xml @@ -30,15 +30,13 @@ android:layout_width="wrap_content" android:layout_height="match_parent" android:layout_gravity="center" - android:orientation="vertical" android:padding="@dimen/scene_mode_padding" > @@ -54,10 +52,6 @@ android:layout_height="wrap_content" android:layout_gravity="center" android:gravity="center" - android:shadowColor="@android:color/black" - android:shadowDx="1" - android:shadowDy="1" - android:shadowRadius="2" android:singleLine="true" android:textColor="@android:color/white" android:textSize="13sp" diff --git a/res/layout/vertical_grid.xml b/res/layout/vertical_grid.xml index 0754d0483..9c746f9ed 100644 --- a/res/layout/vertical_grid.xml +++ b/res/layout/vertical_grid.xml @@ -29,7 +29,6 @@ diff --git a/res/values/colors.xml b/res/values/colors.xml index 780110544..4fdc3e3f9 100644 --- a/res/values/colors.xml +++ b/res/values/colors.xml @@ -56,7 +56,7 @@ @color/grey @color/black @color/blue - @color/black + #c0212121 @color/black #33525E @color/blue @@ -71,9 +71,10 @@ #ffffffff @color/grey - @color/black - @color/white - @color/black + #40fafafa + #60fafafa + #e0212121 + @color/setting_list_selected @color/black #40212121 diff --git a/res/values/styles.xml b/res/values/styles.xml index e20b69913..b3ee810e1 100644 --- a/res/values/styles.xml +++ b/res/values/styles.xml @@ -114,7 +114,7 @@ @dimen/setting_row_height @dimen/setting_item_list_margin @dimen/setting_item_list_margin - @drawable/setting_picker + @drawable/setting_list_item_bg