From b270df4d01b459d445bd861c8cea52cdf90ed441 Mon Sep 17 00:00:00 2001 From: nicolasroard Date: Wed, 26 Jun 2013 16:56:31 -0700 Subject: ImagePreset cleanup Get rid of remaining ivars related to history Change-Id: Ic106ef6a96f4727c6dd46d7be3d059bdc42e5a2a --- .../gallery3d/filtershow/presets/ImagePreset.java | 68 ---------------------- 1 file changed, 68 deletions(-) diff --git a/src/com/android/gallery3d/filtershow/presets/ImagePreset.java b/src/com/android/gallery3d/filtershow/presets/ImagePreset.java index 1c4463062..9c5e2ae65 100644 --- a/src/com/android/gallery3d/filtershow/presets/ImagePreset.java +++ b/src/com/android/gallery3d/filtershow/presets/ImagePreset.java @@ -49,39 +49,20 @@ public class ImagePreset { private static final String LOGTAG = "ImagePreset"; - public static final int STYLE_ICON = 3; - public static final String PRESET_NAME = "PresetName"; - private ImageLoader mImageLoader = null; private Vector mFilters = new Vector(); - protected String mName = "Original"; - private String mHistoryName = "Original"; - protected boolean mIsFxPreset = false; - private boolean mDoApplyGeometry = true; private boolean mDoApplyFilters = true; private boolean mPartialRendering = false; private Rect mPartialRenderingBounds; private static final boolean DEBUG = false; - private Bitmap mPreviewImage; public ImagePreset() { } - public ImagePreset(String historyName) { - setHistoryName(historyName); - } - - public ImagePreset(ImagePreset source, String historyName) { - this(source); - if (historyName != null) { - setHistoryName(historyName); - } - } - public ImagePreset(ImagePreset source) { try { for (int i = 0; i < source.mFilters.size(); i++) { @@ -101,11 +82,7 @@ public class ImagePreset { } catch (java.lang.CloneNotSupportedException e) { Log.v(LOGTAG, "Exception trying to clone: " + e); } - mName = source.name(); - mHistoryName = source.name(); - mIsFxPreset = source.isFx(); mImageLoader = source.getImageLoader(); - mPreviewImage = source.getPreviewImage(); } public FilterRepresentation getFilterRepresentation(int position) { @@ -244,23 +221,6 @@ public class ImagePreset { } } - public boolean isFx() { - return mIsFxPreset; - } - - public void setIsFx(boolean value) { - mIsFxPreset = value; - } - - public void setName(String name) { - mName = name; - mHistoryName = name; - } - - public void setHistoryName(String name) { - mHistoryName = name; - } - public ImageLoader getImageLoader() { return mImageLoader; } @@ -294,10 +254,6 @@ public class ImagePreset { return false; } - if (!mName.equalsIgnoreCase(preset.name())) { - return false; - } - if (mDoApplyGeometry != preset.mDoApplyGeometry) { return false; } @@ -351,14 +307,6 @@ public class ImagePreset { return preset.mFilters.size(); } - public String name() { - return mName; - } - - public String historyName() { - return mHistoryName; - } - public void showFilters() { Log.v(LOGTAG, "\\\\\\ showFilters -- " + mFilters.size() + " filters"); int n = 0; @@ -394,7 +342,6 @@ public class ImagePreset { } } } - setHistoryName("Remove"); } public void addFilter(FilterRepresentation representation) { @@ -405,7 +352,6 @@ public class ImagePreset { if (representation.getFilterType() == FilterRepresentation.TYPE_BORDER) { removeFilter(representation); mFilters.add(representation); - setHistoryName(representation.getName()); } else if (representation.getFilterType() == FilterRepresentation.TYPE_FX) { boolean found = false; for (int i = 0; i < mFilters.size(); i++) { @@ -419,17 +365,14 @@ public class ImagePreset { if (type == FilterRepresentation.TYPE_FX) { mFilters.remove(i); mFilters.add(i, representation); - setHistoryName(representation.getName()); found = true; } } if (!found) { mFilters.add(representation); - setHistoryName(representation.getName()); } } else { mFilters.add(representation); - setHistoryName(representation.getName()); } } @@ -618,14 +561,6 @@ public class ImagePreset { return mPartialRenderingBounds; } - public Bitmap getPreviewImage() { - return mPreviewImage; - } - - public void setPreviewImage(Bitmap previewImage) { - mPreviewImage = previewImage; - } - public Vector getUsedFilters(BaseFiltersManager filtersManager) { Vector usedFilters = new Vector(); for (int i = 0; i < mFilters.size(); i++) { @@ -652,7 +587,6 @@ public class ImagePreset { int numFilters = mFilters.size(); try { writer.beginObject(); - writer.name(PRESET_NAME).value(name); GeometryMetadata geoData = getGeometry(); writer.name(geoData.getSerializationName()); writer.beginObject(); @@ -719,8 +653,6 @@ public class ImagePreset { */ public boolean readJson(JsonReader sreader) throws IOException { sreader.beginObject(); - sreader.nextName(); - mName = sreader.nextString(); while (sreader.hasNext()) { String name = sreader.nextName(); -- cgit v1.2.3