From 98c87f001e0593183237404e73460c43130bf47f Mon Sep 17 00:00:00 2001 From: Jay Wang Date: Tue, 5 Jul 2016 13:51:01 -0700 Subject: SnapdragonCamera: Resolve integer overflow issue The video bit rate calculation can cause integer overflow due to multiplying two huge numbers. To resolve the issue, do the division before the multiplication. Change-Id: I8b077fd68ed3e4f22cc5a2f9cb2a1490d0ed3376 CRs-Fixed: 1030274 --- src/com/android/camera/VideoModule.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/com/android/camera/VideoModule.java b/src/com/android/camera/VideoModule.java index 9cb48eb0f..0f40702ce 100644 --- a/src/com/android/camera/VideoModule.java +++ b/src/com/android/camera/VideoModule.java @@ -1548,7 +1548,7 @@ public class VideoModule implements CameraModule, // Profiles advertizes bitrate corresponding to published framerate. // In case framerate is different, scale the bitrate - int scaledBitrate = mProfile.videoBitRate * targetFrameRate / mProfile.videoFrameRate; + int scaledBitrate = mProfile.videoBitRate * (targetFrameRate / mProfile.videoFrameRate); Log.i(TAG, "Scaled Video bitrate : " + scaledBitrate); mMediaRecorder.setVideoEncodingBitRate(scaledBitrate); } -- cgit v1.2.3