summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* SnapdragonCamera: Make copy of location before altering timestampJay Wang2017-06-131-1/+3
| | | | | | | | Make a copy of saved location object before altering timestamp since we may end up re-using the same location object down the line. CRs-Fixed: 1007285 Change-Id: Ifa8b7cd3ecfe2dede5cfa155818f48f51f4405f1
* Add orientation correction for landscape devicesandralex82017-06-125-6/+23
| | | | | | | | | | | | | Snap does not correctly handle devices with a landscape screen as rotation is 0 when device is in landscape while Snap assume that 0 is portrait. This lead to a rotated gui and a deformed preview. This commit: - Solve the gui rotation for Photo, Video and Panorama modules - Solve the deformed preview for Photo and Video (Panorama preview was ok with gui fix) - Solve the PhotoMenu rotation (all devices, it was also broken on portrait devices) Change-Id: Ic0b95904da6e13946c7e46e2e571b26da498db02
* Snap: Simulate back button press when menu back button is pressedGabriele M2017-06-071-8/+2
| | | | | | | | | | | | Launching Gallery when the home button (shown as back button) is pressed makes no sense, especially because it's only shown in Snap's own gallery. In addition to that, if Gallery is disabled, Snap closes itself. Fix both the issues by simply simulating a back button press when the menu back button is pressed. REGRESSION-607 Change-Id: I0b2b6ee074715e2866bcebb009118b8271b1efdf
* SnapdragonCamera: Fix torch mode with continuous shotJay Wang2017-05-301-9/+38
| | | | | | | | | Flash torch mode sometime doesn't work because the flash mode is overwritten by repeating preview request. To resolve the issue, re-configure the preview request with new flash mode. CRs-Fixed: 1077543 Change-Id: I614bac704562925cc843a9b8db2852c71368f4e5
* Revert "Snap: CaptureModule: lock exposure also when precapture trigger is ↵codeworkx2017-05-301-4/+1
| | | | | | | | started" This reverts commit 48f0e427c4d60f597235954d9bc910c5c8980dbe. Change-Id: Ie77b36e1770b2ce8999e3d98fb2cf811f2764fd1
* SnapdragonCamera: Camera2 force close after focusedweijiew2017-05-301-0/+1
| | | | | | | | | | Handler message leaks the camera id, the camera id is set to 0 when handleing Message.As we known, rear camera id is 0 and front camera id is 1. Focus action runs normall when switching to rear camera, but focus action will lead to force close when switching to fornt camera. Change-Id: I7795b7cd0c34c256d1ad0066d13a51ed54cec67d CRs-Fixed: 1094009
* SnapdragonCamera: GPS location can't be turn On in camera settingsweijiew2017-05-304-13/+18
| | | | | | | | | In Camera2, SharedPreferences persistes GPS location value by key(pref_camera2_recordlocation_key), but gets GPS location value by key(pref_camera_recordlocation_key). CRs-Fixed: 1088262 Change-Id: I33ddeb8f20fed03449bded2760c0ad1b8e36c91c
* Fixed camera crash on exitValerio Pilo2017-05-291-0/+7
| | | | | | | | | | | | | | | | This is just a copy of a fix already done long time ago (commit c3d5c2c5) only for videos, now also for photos. Original description follows: CameraNext: don't call Glide to load image after Camera exits There is a race condition where the filmstrip can still be trying to load a new image just as the camera exit, and Glide gets upset if it is handed a destroyed activity context to work with. So just check for that condition and go home. Change-Id: If7f2b2e4d23189d3c6876d47d5f2046d9e02c7b0
* Snap: Fix crash switching from back to front cam in video modeArne Coucheron2017-05-081-0/+1
| | | | | | | | | | | | | | | | | | | | E CAM_VideoModule: startPreview paused=false device=false params=false E CAM_VideoModule: java.lang.Throwable E CAM_VideoModule: at com.android.camera.VideoModule.startPreview(VideoModule.java:1324) E CAM_VideoModule: at com.android.camera.VideoModule.switchCamera(VideoModule.java:3067) E CAM_VideoModule: at com.android.camera.VideoModule.onCameraPickerClicked(VideoModule.java:3251) E CAM_VideoModule: at com.android.camera.VideoMenu$4.onClick(VideoMenu.java:504) E CAM_VideoModule: at android.view.View.performClick(View.java:5637) E CAM_VideoModule: at android.view.View$PerformClick.run(View.java:22433) E CAM_VideoModule: at android.os.Handler.handleCallback(Handler.java:751) E CAM_VideoModule: at android.os.Handler.dispatchMessage(Handler.java:95) E CAM_VideoModule: at android.os.Looper.loop(Looper.java:154) E CAM_VideoModule: at android.app.ActivityThread.main(ActivityThread.java:6186) E CAM_VideoModule: at java.lang.reflect.Method.invoke(Native Method) E CAM_VideoModule: at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889) E CAM_VideoModule: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779) Change-Id: I2005b09737fd4d739e1415a457b05d575da95582
* Fix some inconsistencies of the HDR buttonGabriele M2017-04-101-9/+12
| | | | | | | | | | | | Issues fixed: - The HDR button disappeared and never came back when switching from a camera without HDR support and one with HDR support. - The HDR button disappeared upon disabling HDR on a device without auto-HDR support. - The filter mode button was not re-enabled upon disabling HDR. Change-Id: Ie7dbf91efa2d6bffc810ca79c73bb0edaa8d56ca
* CameraControls: Toggle the status of disabled viewsGabriele M2017-04-101-3/+15
| | | | | | | | If we toggle the status of all the visible views, we might enable views that were disabled for some specific reason. Save the list of views that we disabled and re-enable only those views. Change-Id: I50fad8e93f89fd9e872ab2fb4f1cb6cd6c9c3f9f
* Never remove unsupported controlsGabriele M2017-04-102-14/+15
| | | | | | | | | | | | | | Different cameras support different features. If we remove certain controls because the current camera doesn't support them, they won't be available for the other camera once we switch to it, even if it supports them. Disable the controls instead of removing them. This completes commit a8285adbba49868378f795a6f37401b9334061c4 ("Snap: Fix effect and picture program overlay buttons") and also changes the way buttons are hidden so that each button stays in its initial position. Change-Id: I7af9655265163b00495af5aa0bb745aa4cc1ed47
* WideAnglePanoramaUI: Correctly position the progressbarGabriele M2017-04-101-4/+14
| | | | | | | | | The progressbar is not visible on devices with the navbar and the cancel button that appears when generating the final picture overlaps with the home button. Take into account the presence of the navbar when calculating the position of the progressbar. Change-Id: I81551477c426244531342e81c595ee020fe066c6
* Snap: CaptureModule: set switcher index on resumecodeworkx2017-04-091-0/+1
| | | | | | Fixes showing wrong drawable on module switcher when switching from other modules. Change-Id: Ia2a4971c79d13c12434a4abfbcf926ebd078172f
* Snap: CaptureUI: fix ModuleSwitcher being invisibleJay Wang2017-04-092-4/+46
| | | | Change-Id: If0a88140a1e73b3f8a7281274896af047af2abde
* CaptureUI: fix crash on setOrientationJay Wang2017-04-041-0/+2
| | | | | | Wrong child node Change-Id: I502eaaa5b011b6c07540032a56184af8e1757716
* Snap: Fix effect and picture program overlay buttonsDominggoes Isakh2017-04-041-2/+4
| | | | | | | | | | When you switch between front and back camera, the camera with the least features removes the overlay buttons causing the other camera not able to use the supported features. BUGBASH-320 Change-Id: I500d48c42ac5797aa1a44664f58057ad4f8189c3
* Always apply frame size reduction to panorama picturesGabriele M2017-04-041-7/+1
| | | | | | | | | | | | | | | | Panorama mode requires quite some memory, especially after the frame num bump done with commit aa0733567c30 ("Make panorama able to go 270 degrees in landscape"). Some devices run out of memory while taking a panorama picture and force close Snap before the picture is complete. We have a config to reduce the memory requirements that reduces the size of each frame, but it's applied only if ro.config.low_ram is true. Bump the default value to 100 and always respect it. Devices having ro.config.low_ram set to true will have to override this config from their device tree. BUGBASH-326 Change-Id: Ic6d24b17b2293adf8d715904c8c1874a4c624e99
* Never ignore finger swipes in gallery modeGabriele M2017-04-042-8/+0
| | | | | | | | | | | | | | Under certain conditions finger swipes are ignored. Steps to reproduce the bug: - Open left menu - Close menu choosing an option or tapping out of the preview - Tap preview of last picture in bottom left corner Swipes in the gallry should now be ignored until a right to left swipe is performed in the preview. Change-Id: I3928d84360266cca368265553a037192aa5d6780
* Fix record time sometimes not seencb2017-04-041-0/+1
| | | | Change-Id: I63a3df10c64a0141cfda161310c3a404349d5c70
* Revert "SnapdragonCamera: Camera switches from bayer and mono on switching ↵Rashed Abdel-Tawab2017-03-081-4/+0
| | | | | | | | | | | to front camera" Some devices (ex. LG G5, V20, and G6) have perfectly functional dual rear camera's that work fine. No reason to force the number of camera's to 2 This reverts commit fab321f61b6fe4e1296806ff5b04bac19d1e4de6. Change-Id: I1ffb0defa299e107b7f193b7b72af3567c4947df
* Focus only when tapping the previewGabriele M2017-02-261-2/+2
| | | | | | | | Calling onSingleTapUp() from onScroll() is causing Snap to issue a focus request for every touch movement, including the gestures to open the menu and the gallery. Change-Id: If913607735add13c1af8e0882748d4800e4e10f9
* Snap: CaptureModule: lock exposure also when precapture trigger is startedcodeworkx2017-02-251-1/+4
| | | | | | Fixes camera hang on LG G4 when flash mode is auto and flash is required. Change-Id: I258fed2364e37f6b40ee5e13f3359167ce13ff8f
* Snap: Allow switching beyond just 2 camerasChristian Frisson2017-02-203-3/+8
| | | | | | | | Some devices have dual rear cameras, which means that they will have more than just 2 camera ID's (0 and 1). For example, the LG G5 has 0, 1 and 2. Allow Snap to run cycle through more than just 0 and 1 Change-Id: I50d8b6c02c97961990b1fbf69b9cf706c422381c
* Snap: CaptureModule: fix preview being invisible on first startcodeworkx2017-02-181-3/+1
| | | | Change-Id: I6c8a015f3cf7c9c47a3d57a433445424642175ed
* CaptureModule: Fix UI.Danny Baumann2017-02-181-127/+75
| | | | | | | | Track changes made to PhotoUI and VideoUI in commits 2bf3a05c66d350e253956503a9388946c1be1c1c and 7bcdf0a9801cfbdc2d170b8d840c8dec672976d0. Change-Id: Ic47181eae09d8a094d367751194d13ac4d1c2785
* Snap: CaptureModule: re-apply flash setting when disabling manual isocodeworkx2017-02-181-2/+3
| | | | Change-Id: I98663a2a99239751c84116640bc9abf841665a73
* Snap: CaptureModule: check if ZSL is supported before using itcodeworkx2017-02-183-33/+70
| | | | Change-Id: Ifde34ce367ceeb19ad71bcff0c4518d578bb52a5
* Snap: CaptureModule: enable noise reductioncodeworkx2017-02-181-1/+1
| | | | Change-Id: I8c743a2d99ec4ed9d4023a81062bfe47e888fcf5
* Snap: CaptureModule: enable redeye reductioncodeworkx2017-02-181-1/+1
| | | | Change-Id: Ia427865449025c840716d526829a8e57b64c16be
* Snap: CaptureModule: enable and fix manual iso controlcodeworkx2017-02-182-3/+10
| | | | Change-Id: Ibf2cbed99f0205c9dc4eadc422096b03a35f0a43
* Snap: CaptureUI: remove camera2 optioncodeworkx2017-02-181-1/+0
| | | | Change-Id: I4b51bca345f54b057dd2efb32ccda7991064932c
* Snap: detect and use Camera2 if availablecodeworkx2017-02-172-7/+44
| | | | | | Also add overlay option to enable support for Camera2 to retain current behaviour. Change-Id: I20939e33f4bb687e4abea11bbcdb9bf246b156e4
* Snap: Replace noisy debug linestaging/cm-14.1-cafrebaseGabriele M2017-02-111-1/+1
| | | | | Change-Id: I378fc4d5fc102ec1c23995532114355b1dcdb3d6 (cherry picked from commit 75de9ea72239a662f5070be38d231a8602877d05)
* Snap: VideoModule: Restore check on mPreferenceReadGabriele M2017-02-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes the following crash when switching from picture mode to video mode for the first time: FATAL EXCEPTION: main Process: org.cyanogenmod.snap, PID: 4243 java.lang.NullPointerException: Attempt to read from field 'int android.media.CamcorderProfile.videoFrameWidth' on a null object reference at com.android.camera.VideoModule.updateCameraParametersInitialize(VideoModule.java:2778) at com.android.camera.VideoModule.setCameraParameters(VideoModule.java:2822) at com.android.camera.VideoModule.startPreview(VideoModule.java:1353) at com.android.camera.VideoModule.onPreviewUIReady(VideoModule.java:3260) at com.android.camera.VideoUI.surfaceCreated(VideoUI.java:956) at android.view.SurfaceView.updateWindow(SurfaceView.java:618) at android.view.SurfaceView$3.onPreDraw(SurfaceView.java:161) at android.view.ViewTreeObserver.dispatchOnPreDraw(ViewTreeObserver.java:944) at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2205) at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1254) at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:6343) at android.view.Choreographer$CallbackRecord.run(Choreographer.java:874) at android.view.Choreographer.doCallbacks(Choreographer.java:686) at android.view.Choreographer.doFrame(Choreographer.java:621) at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:860) at android.os.Handler.handleCallback(Handler.java:751) at android.os.Handler.dispatchMessage(Handler.java:95) at android.os.Looper.loop(Looper.java:154) at android.app.ActivityThread.main(ActivityThread.java:6126) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776) Change-Id: I8f449aaa943636a9b3ce590425e8611def8df590 (cherry picked from commit 342b6177119011ecfa2a7f97fceb4027186944e1)
* Snap: VideoModule: Update flash status on preference changeGabriele M2017-02-111-0/+2
| | | | | | | | The flash preference was read only during initialization. Do it whenever the preferences change. Change-Id: I32c0d96f6c71dca98953a7bb29dbfa2f59ac4b07 (cherry picked from commit 84752f915ee31ee5f2426474eb58ee4e05874dc6)
* Snap: Fix filtering of unsupported HFR/HSR modesMichael Bestas2017-02-111-3/+25
| | | | | Change-Id: I7721613f10a24cbd36eb0a3c5b0a46a98e828679 (cherry picked from commit 678971d123ba3255e47f6f5a7911fef6d69e3821)
* Snap: Fix max brightness and power shutter settingsGabriele M2017-02-111-2/+4
| | | | | | | | | | Checking the value of arePreviewControlsVisible() doesn't allow to reliably determine whether we are using the app or not, so do it as we used to: set a local flag as soon as we show/hide the controls and check its value. Change-Id: Iadfa86d49b74bc811006e1b477b60fc487772219 (cherry picked from commit fe100c6e50feeda676ec470e70c90621dbc57585)
* Snap: Fix NPE when parameters.getSupportedVideoSizes() is nullMichael Bestas2017-02-111-102/+22
| | | | | | | | | * Older devices do not support parameters.getSupportedVideoSizes() * Assume that the device reports valid profiles in media_profiles * Remove dead code Change-Id: Ic3488b6762496bd9498bc6bf8b48b2a2212bad51 (cherry picked from commit 2bc50511221788bf6a5815f92a07d95380e3d8ad)
* Fix shutter button pressed state tracking issues.Danny Baumann2017-02-112-3/+22
| | | | | | | | | | | - Setting pressed state to false on enabling touch caused ripples to be displayed too early - Make sure pressed state is set to true on down event and set to false on up event - Correctly set ripple hotspot Change-Id: I64bbd3be21f19f3027243514239733b57cebb81a (cherry picked from commit 7cf0bf375ea7a06f02e922f1c205ffba92935695)
* Snap: store module indexcodeworkx2017-02-111-0/+5
| | | | | | | | | | | | | Store the module index so we can use it the next time the Camera starts up. Looks like this code got lost in space during one of the recent merges. Probably somewhere around the black hole in andromeda galaxy. Credits to codeaurora Change-Id: I1be5f643fbeb985fbc4734d03498deeac3ed841b (cherry picked from commit a425da8101c4c3567b407016551b791d279fbdfe)
* Fix thumbnail sometimes not being shown initially in video mode.Danny Baumann2017-02-111-13/+13
| | | | | | | | Happened due to a race condition between surface creation and view initialization. Change-Id: I701eaa16c09a246806f5d148d0ce90f1d132e3f3 (cherry picked from commit 9936197ae3607b0fec5eb343725d6056b6d86b67)
* Snap: VideoModule: properly update focus settings when switching between camerasFlex19112017-02-111-0/+1
| | | | | Change-Id: I4c769bb4f080b8144b2571d218807bf197187a54 (cherry picked from commit 8613b0502046742d80cb9eee7cd5e9eea2ee356f)
* Snap: Fix zoom in video modeGabriele M2017-02-111-1/+1
| | | | | | | The zoom parameter was changed but never applied. Change-Id: Ibed445179835e7b6ed146058320ab5c2db0d8179 (cherry picked from commit 8c64fae391fff390bac978c6bd639434bc1b19a5)
* Snap: Remove touch AF/AEC optionSteve Kondik2017-02-093-50/+11
| | | | | | | | * Drop the use of the touchaf-aec parameter entirely. No camera needs this anymore. Change-Id: I83154a75e5375901dc6c0fc93aef23637cfdf425 (cherry picked from commit 8ba41f452222c87a733fd2d045f9c513fd8d7799)
* Correctly return to film strip after editing a picture.Danny Baumann2017-01-246-17/+24
| | | | | Change-Id: Icd4e47474f871d427d10ab2575e0d9622f1b4369 (cherry picked from commit e0a3c03cf912c6b437dd2bf96f486b88c699fb9c)
* Fix camera controls rotation.Danny Baumann2017-01-131-8/+13
| | | | Change-Id: I949b30becc8b69268ff30a0dca57e234fd078204
* Snap: Remove storage menu if no external storage availablemaxwen2017-01-041-2/+9
| | | | | Change-Id: I9807c7f9303f17eb971ff1a82fbd35dfbdbfa529 Signed-off-by: Zdrowy Gosciu <ZdrowyGosciu+GITHUB@gmail.com>
* Snap: make openLegacy an optioncodeworkx2017-01-042-11/+39
| | | | | | | Using openLegacy on QCamera3 forces it to use QCamera2 and fall back to api v1 which is not what we want on v2 devices. Change-Id: Ic392a4ae9403ebae36940ddf0727237d9cb9e8f0
* Snap: prevent NPE when checking if controls are visibleJoey Rizzoli2017-01-041-0/+3
| | | | | Change-Id: Id054ccc9445722bcb08953fd40e43a82bdd13ae2 Signed-off-by: Joey Rizzoli <joey@cyanogenmoditalia.it>