| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
* Create a new custom focus view that interacts with physical lens diopter changes.
* Replace all occurances of the old focus indicator with the new one.
Change-Id: Ia02646ce4d1eb059ecb8a1dfccc15dfc9c167e1b
|
|
|
|
|
|
| |
https://github.com/LineageOS/android_packages_apps_Snap/commit/70dbc05d00a5e6011f532d029c50bfb4a17a2e57
Change-Id: I9bee85c9a454dad074fec688974cc84b629cd62d
|
|
|
|
| |
Change-Id: I61c04c7cb8d344573ab7fb11f7114f09aaf24fb7
|
|
|
|
|
|
| |
* fixes ArrayIndexOutOfBoundsException on setUpCameraOutputs
Change-Id: I1565576b604bdcebea85d65f3c7a2b332292ed2d
|
|
|
|
| |
Change-Id: I179e2a430b6ea790d6b4a68b124944e09f4b1715
|
|
|
|
|
|
| |
* Fixes I0f0a91fa3cd1abe17c9d3eef453c4ed706a6fb25
Change-Id: Ib4f2aa3854127ffd96bfa744987adfd65fa306fe
|
|
|
|
|
|
|
|
|
| |
* Saving 1 vs saving several can be a different string in other languages
(e.g. German: "1 von 10 Bildern wird gespeichert[...]"
vs "2 von 10 Bildern werden gespeichert[...]")
* Also fixes a missing "be" in the source string ("will _be_ deleted")
Change-Id: I0f0a91fa3cd1abe17c9d3eef453c4ed706a6fb25
|
|
|
|
|
|
| |
https://review.lineageos.org/#/c/200740/
Change-Id: I674de05dfb46fb714979ac66c16a85825af13c95
|
|
|
|
|
|
|
|
| |
No reason to do use caf ones
This reverts commit a465e3a0cf7a81c7cb9a0e80cbfa7527e7d7de77.
Change-Id: I611351ddfa0b24087cc58466dcba95ab4999d1bd
|
|
|
|
|
| |
Change-Id: I7cc33c7ebc6de35d19979a9a70f198029e46d88f
Signed-off-by: Joey Rizzoli <joey@lineageos.org>
|
|
|
|
|
|
|
| |
MessageQueue-JNI: java.lang.IllegalArgumentException: Could not find tag for key
'org.codeaurora.qcamera3.saturation.use_saturation')
Change-Id: Ia42c67552f9d4574e5f86af2ac5aea853198d0ed
|
|
|
|
|
|
|
|
|
|
| |
* This breaks HDR on every device that has this param, because this
makes the camera HAL return *1* e*x*tra frame at 0 exposure, and
since Snap doesn't know what to do with this extra frame, it
erroneously saves it as a second picture on device storage
* Remove this option entirely to make HDR great again
Change-Id: I8ef4072eb030f4ab6e608a0da268274a3dc58e34
|
|
|
|
| |
Change-Id: I843ba306053ea7f14fbf805c8633c02a854f84df
|
|
|
|
|
|
| |
Loosely based on old cyngn patches.
Change-Id: I7fdb6ba82243f2f28e8ea655f83f0339d49de5ad
|
|
|
|
| |
Change-Id: I3bd89db44663594871a992e6856f55fef8a70c85
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert "SnapdragonCamera: Add help menu to camera2"
This reverts commit 0dbfdffc9994a17e60c57b17c3cc5743cc75e155.
Change-Id: Icb4e4bbc2b7883fa232483615a18d3197b2577bd
Revert "SnapdragonCamera: Move help menu string to ressource"
This reverts commit 901130273dbfc753ef883941a4e93b50056177e4.
Change-Id: I82815ee7ef80985c88315c40d6b222f688fd6b75
Revert "SnapdragonCamera: Adding help screen on first start"
This reverts commit 666692bf730a1c46210cc74781a56afb4b6fcf28.
Change-Id: I8f2ee58c263537c3a02248aa344516f5321de13f
|
|
|
|
| |
Change-Id: I24953691c020727900a8cd944e60c27a24ff62c9
|
|
|
|
| |
Change-Id: I74b9230e7c63813b3e8b716acf66b10c835f12b5
|
|
|
|
|
|
| |
Keep consistent with how filter mode menu behaves.
Change-Id: If53bdca075bf97e1f2ad3b8a3f494dcb720026dc
|
|
|
|
| |
Change-Id: I5a67ee329a46701629b017c57f640a5be1976288
|
|
|
|
|
|
| |
Also increase margin a bit.
Change-Id: Id8ddb1137094f03bd26b487575b555bbadd80432
|
|
|
|
|
|
|
|
|
| |
Add in a missing toast to warn a user when the wanted
HSR/HFR mode gets overriden due to the incompatibility
with image stabilization.
Change-Id: Ib81c50e8fad0bca075e6b33399321da42d77eb03
Signed-off-by: Alex Naidis <alex.naidis@linux.com>
|
|
|
|
|
|
|
|
| |
Don't process touch-to-focus for taps that are located on either the top
or bottom UI panes.
Change-Id: Iac4ccda8625080ff0bd1133ac339e53c423b626d
Signed-off-by: Sultanxda <sultanxda@gmail.com>
|
|
|
|
|
|
|
|
|
| |
Previously, the zoom circle was rendered in the center of the entire screen,
making it look unevenly placed due to the uneven sizes of the top and bottom
UI panes. The camera preview in this case is calculated to be the portion
of the screen between the top and bottom UI panes.
Change-Id: I67678f7bc227cf2b7a6eed3161805b2b107c488a
|
|
|
|
|
|
|
| |
To prevent unintentional duplicate photo captures.
Change-Id: I5b24d834ba6eb7e2f606d656a71f5878ab8d08f5
Signed-off-by: Alex Naidis <alex.naidis@linux.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Due to this check, the shutter button would be disabled until each photo
would finish processing. This results in the shutter button getting
disabled for quite a long time when ZSL isn't used, forcing the user to
wait until the previous shot is finished before requesting a new shot.
Fix the HDR check so that shutter button clicks in quick succession work.
There is code in place to handle button clicks in rapid succession, so this
is fine.
Change-Id: Ifc36a22e4ec3a1be24e5a9b40c3fc682e82605b3
Signed-off-by: Alex Naidis <alex.naidis@linux.com>
|
|
|
|
|
|
| |
Change-Id: Ic5e429c16792af7f3af0155f50c162487ffa4ef7
(cherry picked from commit 460c0f207ad453473a1d2d5f0f94651578f5eccb)
Signed-off-by: Alex Naidis <alex.naidis@linux.com>
|
|
|
|
|
|
| |
* Index value is not allowed to be higher/equal to the array length
Change-Id: Iff361603f337e4e77085717fce6227815ea06fc7
|
|
|
|
|
|
|
|
|
|
| |
Some devices send multiple shutter callbacks for one captured frame in
longshot mode. As this causes mismatch between the calculated number of
captured frames and the calculated number of JPEGs received for those,
which in turn leads to longshot mode never being ended properly,
protect against that scenario by discarding all but the first callback.
Change-Id: I0c3a270f664a0cd16354fb0a13c5941a52001650
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a new Longshot feature where in the snapshot frames
captured at ISP is @ 3fps and output JPEG encoded rate is @ 1.2 fps.
This can be enabled by setting following setprop with
the maximum number of snapshots.
adb shell setprop persist.camera.longshot.max <max_number>
e.g.:adb shell setprop persist.camera.longshot.max 10
If the number is -1, then the existing Longshot will be used.
Main changes:
1) The number of Snapshot/Preview/Metadata buffers are increased to
make sure no frames will be dropped @ ISP and to maintain burst fps.
e.g.: For max number of 10 snapshots, Snapshot buffers are increased to 9
from existing 6.
This buffer numbers are derived considering snapshot YUV frames @ 3 fps
and JPEG encoding @ 1.2 fps.
2) Shutter will be played after receiving YUV frame instead of reprocess frame.
3) New Longshot stop command is sent after receiving all the required YUV
callbacks or releasing the shutter before reaching Max number.
4) Existing Longshot off command is sent after receiving all JPEG CB.s for the issued
TakePictures() and also shutter button will be disabled until all the JPEG
callbacks are received.
Change-Id: Id0c21aeb67245530768bf3ab859d39dea7e2bc40
|
|
|
|
|
|
|
|
|
|
| |
Instead of using preview fps range API during
preview framerate reset use the fixed fps API.
This is to avoid any inconsistent behavior that
can be triggered when using both APIs from
MediaRecorder and Snapdragon application side.
Change-Id: Ib5251d8ea4d697db9bdea4e5ebf20606b286f54f
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Camera open and preview start are currently
executed in a separate thread different from the
main handler thread. If the main thread tries to
switch the camera immediately after the open camera
thread starts a race condition is possible. This
race condition can lead to a failing assert in
CameraHolder which can receive two camera open
requests one after another. To resolve this
the main handler thread needs to check whether
an open camera thread got initialized and started
previously. If the check is positive, it needs
to wait until the separate thread finishes before
proceeding with the camera switch sequence.
Change-Id: I409e3158bc976120de31540351ea8e55fddbca46
|
|
|
|
|
|
|
|
| |
4k DCI recorded FPS is getting picked up from profile and not
getting reset to preview FPS after stop recording.
Fix made to set the preview FPS range after stop recording.
Change-Id: I4892e6fcee3eefbcbd6ca9426e56e2303cdad844
|
|
|
|
|
|
|
|
|
|
|
| |
Camera open thread initializes the focus overlay manager
after opening camera. In a rare scenario above background
thread had not initialized focus overlay manager by the
time UI thread start acessesing it, so we see a crash.
Initialize focus overlay manager from UI thread if it is
not initialized already.
Change-Id: I1635c8759d0e0647fe61fe975a0cc24df40df529
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Under certain conditions finger swipes are ignored.
Steps to reproduce the bug:
- Open left menu
- Close menu choosing an option or tapping out of the preview
- Tap preview of last picture in bottom left corner
Swipes in the gallry should now be ignored until a right to left
swipe is performed in the preview.
Change-Id: I3928d84360266cca368265553a037192aa5d6780
|
|
|
|
|
|
|
|
| |
Calling onSingleTapUp() from onScroll() is causing Snap to issue
a focus request for every touch movement, including the gestures
to open the menu and the gallery.
Change-Id: If913607735add13c1af8e0882748d4800e4e10f9
|
|
|
|
| |
Change-Id: I95eb7237b101b73d66fe231a11d0c8d5156bfe47
|
|
|
|
|
|
|
|
|
|
|
|
| |
Launching Gallery when the home button (shown as back button) is
pressed makes no sense, especially because it's only shown in Snap's
own gallery. In addition to that, if Gallery is disabled, Snap closes
itself. Fix both the issues by simply simulating a back button press
when the menu back button is pressed.
REGRESSION-607
Change-Id: I0b2b6ee074715e2866bcebb009118b8271b1efdf
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Panorama mode requires quite some memory, especially after the frame
num bump done with commit aa0733567c30 ("Make panorama able to go 270
degrees in landscape"). Some devices run out of memory while taking a
panorama picture and force close Snap before the picture is complete.
We have a config to reduce the memory requirements that reduces the
size of each frame, but it's applied only if ro.config.low_ram is
true. Bump the default value to 100 and always respect it. Devices
having ro.config.low_ram set to true will have to override this
config from their device tree.
BUGBASH-326
Change-Id: Ic6d24b17b2293adf8d715904c8c1874a4c624e99
|
|
|
|
|
|
|
|
| |
Some devices have dual rear cameras, which means that they will have
more than just 2 camera ID's (0 and 1). For example, the LG G5 has
0, 1 and 2. Allow Snap to run cycle through more than just 0 and 1
Change-Id: I50d8b6c02c97961990b1fbf69b9cf706c422381c
|
|
|
|
| |
Change-Id: Ifde34ce367ceeb19ad71bcff0c4518d578bb52a5
|
|
|
|
|
|
| |
Also add overlay option to enable support for Camera2 to retain current behaviour.
Change-Id: I20939e33f4bb687e4abea11bbcdb9bf246b156e4
|
|
|
|
|
| |
Change-Id: Id054ccc9445722bcb08953fd40e43a82bdd13ae2
Signed-off-by: Joey Rizzoli <joey@cyanogenmoditalia.it>
|
|
|
|
|
|
|
|
|
|
|
| |
Since commit 87b4a40d588a7ae8a61cb353c4cff8df37f7b483 moved camera
initialization (and focus manager initialization with it) to a
background thread, the focus manager initialization now races against
the onPreviewRectChanged() call triggered by SurfaceView initialization
in the main thread, potentially leaving the focus manager in an
uninitialized state that prevented taking pictures.
Change-Id: I8cf650d6a67768acd131b3cddad175ed198e0838
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes this crash:
11-29 13:02:30.837 18338 18338 E AndroidRuntime:
java.lang.IllegalArgumentException: You cannot start a load for a
destroyed activity
11-29 13:02:30.837 18338 18338 E AndroidRuntime: at
com.bumptech.glide.manager.RequestManagerRetriever.assertNotDestroyed(RequestManagerRetriever.java:136)
11-29 13:02:30.837 18338 18338 E AndroidRuntime: at
com.bumptech.glide.manager.RequestManagerRetriever.get(RequestManagerRetriever.java:127)
11-29 13:02:30.837 18338 18338 E AndroidRuntime: at
com.bumptech.glide.manager.RequestManagerRetriever.get(RequestManagerRetriever.java:88)
11-29 13:02:30.837 18338 18338 E AndroidRuntime: at
com.bumptech.glide.Glide.with(Glide.java:587)
11-29 13:02:30.837 18338 18338 E AndroidRuntime: at
com.android.camera.data.LocalMediaData$PhotoData.loadUri(LocalMediaData.java:535)
11-29 13:02:30.837 18338 18338 E AndroidRuntime: at
com.android.camera.data.LocalMediaData$PhotoData.loadImage(LocalMediaData.java:507)
11-29 13:02:30.837 18338 18338 E AndroidRuntime: at
com.android.camera.data.LocalMediaData$PhotoData.fillImageView(LocalMediaData.java:485)
11-29 13:02:30.837 18338 18338 E AndroidRuntime: at
com.android.camera.data.LocalMediaData.getView(LocalMediaData.java:232)
11-29 13:02:30.837 18338 18338 E AndroidRuntime: at
com.android.camera.data.CameraDataAdapter.getView(CameraDataAdapter.java:101)
11-29 13:02:30.837 18338 18338 E AndroidRuntime: at
com.android.camera.data.FixedFirstDataAdapter.getView(FixedFirstDataAdapter.java:117)
11-29 13:02:30.837 18338 18338 E AndroidRuntime: at
com.android.camera.ui.FilmStripView.buildItemFromData(FilmStripView.java:928)
11-29 13:02:30.837 18338 18338 E AndroidRuntime: at
com.android.camera.ui.FilmStripView.update(FilmStripView.java:2072)
11-29 13:02:30.837 18338 18338 E AndroidRuntime: at
com.android.camera.ui.FilmStripView.-wrap12(FilmStripView.java)
11-29 13:02:30.837 18338 18338 E AndroidRuntime: at
com.android.camera.ui.FilmStripView$4.onDataUpdated(FilmStripView.java:1803)
11-29 13:02:30.837 18338 18338 E AndroidRuntime: at
com.android.camera.data.FixedFirstDataAdapter.onDataLoaded(FixedFirstDataAdapter.java:152)
11-29 13:02:30.837 18338 18338 E AndroidRuntime: at
com.android.camera.data.CameraDataAdapter.replaceData(CameraDataAdapter.java:269)
11-29 13:02:30.837 18338 18338 E AndroidRuntime: at
com.android.camera.data.CameraDataAdapter.-wrap1(CameraDataAdapter.java)
11-29 13:02:30.837 18338 18338 E AndroidRuntime: at
com.android.camera.data.CameraDataAdapter$QueryTask.onPostExecute(CameraDataAdapter.java:359)
11-29 13:02:30.837 18338 18338 E AndroidRuntime: at
com.android.camera.data.CameraDataAdapter$QueryTask.onPostExecute(CameraDataAdapter.java:358)
11-29 13:02:30.837 18338 18338 E AndroidRuntime: at
android.os.AsyncTask.finish(AsyncTask.java:660)
11-29 13:02:30.837 18338 18338 E AndroidRuntime: at
android.os.AsyncTask.-wrap1(AsyncTask.java)
11-29 13:02:30.837 18338 18338 E AndroidRuntime: at
android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:677)
11-29 13:02:30.837 18338 18338 E AndroidRuntime: at
android.os.Handler.dispatchMessage(Handler.java:102)
11-29 13:02:30.837 18338 18338 E AndroidRuntime: at
android.os.Looper.loop(Looper.java:154)
11-29 13:02:30.837 18338 18338 E AndroidRuntime: at
android.app.ActivityThread.main(ActivityThread.java:6095)
11-29 13:02:30.837 18338 18338 E AndroidRuntime: at
java.lang.reflect.Method.invoke(Native Method)
11-29 13:02:30.837 18338 18338 E AndroidRuntime: at
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886)
11-29 13:02:30.837 18338 18338 E AndroidRuntime: at
com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)
Change-Id: I43c6eb85651e5ee69647114a5ec819ed98c61720
|
|
|
|
|
|
|
|
|
|
| |
Panorama was using Infinity for the focus mode all the time for
panoramas. Change to use continuous-picture in viewfinder before
the actual mosaic is started then change to fixed to lock in.
This allows indoor panoramas to not suck.
Change-Id: Ida01ca1ded1e1058d76da851cd20e5b7072e15be
(cherry picked from commit 33ece020c28796f004f28843fda28092e315c9dc)
|
|
|
|
|
|
| |
Change-Id: Icfab44c674bcc59c1d369af64985956ccaf63ccc
issue-id: SAMBAR-869
(cherry picked from commit e0ca697b97ef2d872f682d2b357d7233762cfafd)
|
|
|
|
|
|
|
|
|
|
|
| |
Current implementation of video capture UI configured MediaRecorder to
output directly into supplied URI, which per recommendation should be
a content: URI. We pass this URI to another app to play back the video,
and should pass along the read permission.
Bug: 19675889
Change-Id: Idfc0ee42422dde5d921e81f098d4697e652ac689
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes a NPE if a panorama is rendering when the user pauses the activity,
then launches the camera from the lockscreen and enters panorama mode.
With this patch, the user is shown a message "previous panorama is
rendering" instead of the progress bar.
FEIJ-533
Change-Id: I3247e4bd96aa3aa67e9b1ff75d747d8be0c3c633
|
|
|
|
|
|
|
|
|
|
|
| |
MediaScanner should be notified when a file is created or changed. Add
an explicit call at the end of the async task writing saving the
bitmap.
Fixes FEIJ-479 where the cropped file was being shown as a 0 byte file
over MTP.
Change-Id: I2220654a75f502089f44e1cb24682b73516c43b0
|