| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
| |
When it's focusing, don't cancel auto foucus.
Change-Id: Ib1d660ac6a99da56d70cf437dad3126a641956d1
|
|
|
|
|
|
|
|
|
|
|
|
| |
CaptureModule and CaptureUI have register listeners in
SettingsManager, but forget unregiseter when UI destroy.
This makes the too many RenderNode objects exist and never GC.
At last, the weak reference of RenderNode at native layer exceed
the 51200 limitation and crash.
Unregister the listener of SettingsManager will fix it.
Change-Id: I2aca795c813177fd34ed18e88f5c9b929a749bff
CRs-Fixed: 1103907
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In monkey test, set defaultValue operation in xml file, parsing
XML in framework code, pref.getValue() return null when
defaultValue not ready. When findIndexOfValue() failed to get
the index of the value, it will return -1, but -1 can`t be the
index of the array, it will cause exception. So if can`t find
the index of the value, just go back and don`t execute the
following code.
Change-Id: I2b5595d7d558e3ab3863287e3d1424df141c5d59
CRs-Fixed: 1063228
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Permission without the case of granted, through the mms
to add attachments to enter the Camera, it will lead to
call two times PermissionActivity, which led to FC and
the wrong interface.
Add a logical judgment to call one time
PermissionActivity
Change-Id: I8b3f287eecb1dfc8f8c5a26a9f0b9dbe187d8ce6
CRs-Fixed: 1069373
|
|
|
|
|
|
| |
When pause/resuming, reset zoom value to default value
Change-Id: Ib1313009cfd8c44daa2032d20da863fe10eeddf0
|
|
|
|
|
|
| |
Remove CONTROL_AF_STATE_PASSIVE_FOCUSED to make sure AF is ready
Change-Id: I581480e5a3f1a40062140eeed0c26d769c60e4db
|
|
|
|
|
|
|
|
|
|
| |
When clearSight is failed, handleTimeout() is invoked to
reset clearsight Engine, but ClearsightProcessHandler is still
working and try to access null pointer object.
By adding protect of null pointer can fix this issue.
Change-Id: I4722721f3715077ec8303c4d14693ae4c1484420
|
|
|
|
|
|
|
|
| |
Make a copy of saved location object before altering timestamp
since we may end up re-using the same location object down the line.
CRs-Fixed: 1007285
Change-Id: Ifa8b7cd3ecfe2dede5cfa155818f48f51f4405f1
|
|
|
|
|
|
|
| |
PackageManager: Not granting permission android.permission.INTERACT_ACROSS_USERS_FULL to package org.cyanogenmod.snap (protectionLevel=258 flags=0x3858bc45)
PackageManager: Not granting permission android.permission.SET_ORIENTATION to package org.cyanogenmod.snap (protectionLevel=2 flags=0x3858bc45)
Change-Id: I088ea4ee72c82732f372b1d698c9c046076cd499
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Snap does not correctly handle devices with a landscape screen as rotation
is 0 when device is in landscape while Snap assume that 0 is portrait.
This lead to a rotated gui and a deformed preview.
This commit:
- Solve the gui rotation for Photo, Video and Panorama modules
- Solve the deformed preview for Photo and Video (Panorama preview was ok with gui fix)
- Solve the PhotoMenu rotation (all devices, it was also broken on portrait devices)
Change-Id: Ic0b95904da6e13946c7e46e2e571b26da498db02
|
|
|
|
|
|
|
|
|
|
|
|
| |
Launching Gallery when the home button (shown as back button) is
pressed makes no sense, especially because it's only shown in Snap's
own gallery. In addition to that, if Gallery is disabled, Snap closes
itself. Fix both the issues by simply simulating a back button press
when the menu back button is pressed.
REGRESSION-607
Change-Id: I0b2b6ee074715e2866bcebb009118b8271b1efdf
|
|
|
|
| |
Change-Id: Icc291d4391d0b784b5876a6037c970f292066bae
|
|
|
|
|
|
|
|
|
| |
Flash torch mode sometime doesn't work because the flash mode
is overwritten by repeating preview request. To resolve the
issue, re-configure the preview request with new flash mode.
CRs-Fixed: 1077543
Change-Id: I614bac704562925cc843a9b8db2852c71368f4e5
|
|
|
|
|
|
|
|
| |
started"
This reverts commit 48f0e427c4d60f597235954d9bc910c5c8980dbe.
Change-Id: Ie77b36e1770b2ce8999e3d98fb2cf811f2764fd1
|
|
|
|
|
|
|
|
|
|
| |
Handler message leaks the camera id, the camera id is set to 0 when
handleing Message.As we known, rear camera id is 0 and front camera
id is 1. Focus action runs normall when switching to rear camera, but
focus action will lead to force close when switching to fornt camera.
Change-Id: I7795b7cd0c34c256d1ad0066d13a51ed54cec67d
CRs-Fixed: 1094009
|
|
|
|
|
|
|
|
|
| |
In Camera2, SharedPreferences persistes GPS location value by
key(pref_camera2_recordlocation_key), but gets GPS location value by
key(pref_camera_recordlocation_key).
CRs-Fixed: 1088262
Change-Id: I33ddeb8f20fed03449bded2760c0ad1b8e36c91c
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is just a copy of a fix already done long time ago
(commit c3d5c2c5) only for videos, now also for photos.
Original description follows:
CameraNext: don't call Glide to load image after Camera exits
There is a race condition where the filmstrip can still be trying
to load a new image just as the camera exit, and Glide gets
upset if it is handed a destroyed activity context to work with.
So just check for that condition and go home.
Change-Id: If7f2b2e4d23189d3c6876d47d5f2046d9e02c7b0
|
|
|
|
| |
Change-Id: Id0df8b8745242b9251b3c154fadfa32d76d1c661
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
E CAM_VideoModule: startPreview paused=false device=false params=false
E CAM_VideoModule: java.lang.Throwable
E CAM_VideoModule: at com.android.camera.VideoModule.startPreview(VideoModule.java:1324)
E CAM_VideoModule: at com.android.camera.VideoModule.switchCamera(VideoModule.java:3067)
E CAM_VideoModule: at com.android.camera.VideoModule.onCameraPickerClicked(VideoModule.java:3251)
E CAM_VideoModule: at com.android.camera.VideoMenu$4.onClick(VideoMenu.java:504)
E CAM_VideoModule: at android.view.View.performClick(View.java:5637)
E CAM_VideoModule: at android.view.View$PerformClick.run(View.java:22433)
E CAM_VideoModule: at android.os.Handler.handleCallback(Handler.java:751)
E CAM_VideoModule: at android.os.Handler.dispatchMessage(Handler.java:95)
E CAM_VideoModule: at android.os.Looper.loop(Looper.java:154)
E CAM_VideoModule: at android.app.ActivityThread.main(ActivityThread.java:6186)
E CAM_VideoModule: at java.lang.reflect.Method.invoke(Native Method)
E CAM_VideoModule: at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889)
E CAM_VideoModule: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779)
Change-Id: I2005b09737fd4d739e1415a457b05d575da95582
|
|
|
|
| |
Change-Id: Id6f2f610fe04e653f02fa1a6ecb96c98cf471681
|
|
|
|
| |
Change-Id: I43a8bc820f65e167509af1f0899f63874676bbe5
|
|
|
|
|
|
|
|
|
|
|
|
| |
Issues fixed:
- The HDR button disappeared and never came back when switching
from a camera without HDR support and one with HDR support.
- The HDR button disappeared upon disabling HDR on a device
without auto-HDR support.
- The filter mode button was not re-enabled upon disabling HDR.
Change-Id: Ie7dbf91efa2d6bffc810ca79c73bb0edaa8d56ca
|
|
|
|
|
|
|
|
| |
If we toggle the status of all the visible views, we might enable
views that were disabled for some specific reason. Save the list
of views that we disabled and re-enable only those views.
Change-Id: I50fad8e93f89fd9e872ab2fb4f1cb6cd6c9c3f9f
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Different cameras support different features. If we remove certain
controls because the current camera doesn't support them, they won't
be available for the other camera once we switch to it, even if it
supports them. Disable the controls instead of removing them.
This completes commit a8285adbba49868378f795a6f37401b9334061c4
("Snap: Fix effect and picture program overlay buttons") and also
changes the way buttons are hidden so that each button stays in
its initial position.
Change-Id: I7af9655265163b00495af5aa0bb745aa4cc1ed47
|
|
|
|
|
|
|
|
|
| |
The progressbar is not visible on devices with the navbar and the
cancel button that appears when generating the final picture overlaps
with the home button. Take into account the presence of the navbar
when calculating the position of the progressbar.
Change-Id: I81551477c426244531342e81c595ee020fe066c6
|
|
|
|
|
|
| |
Fixes showing wrong drawable on module switcher when switching from other modules.
Change-Id: Ia2a4971c79d13c12434a4abfbcf926ebd078172f
|
|
|
|
| |
Change-Id: If0a88140a1e73b3f8a7281274896af047af2abde
|
|
|
|
|
|
| |
Wrong child node
Change-Id: I502eaaa5b011b6c07540032a56184af8e1757716
|
|
|
|
|
|
|
|
|
|
| |
When you switch between front and back camera, the camera with the
least features removes the overlay buttons causing the other camera
not able to use the supported features.
BUGBASH-320
Change-Id: I500d48c42ac5797aa1a44664f58057ad4f8189c3
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Panorama mode requires quite some memory, especially after the frame
num bump done with commit aa0733567c30 ("Make panorama able to go 270
degrees in landscape"). Some devices run out of memory while taking a
panorama picture and force close Snap before the picture is complete.
We have a config to reduce the memory requirements that reduces the
size of each frame, but it's applied only if ro.config.low_ram is
true. Bump the default value to 100 and always respect it. Devices
having ro.config.low_ram set to true will have to override this
config from their device tree.
BUGBASH-326
Change-Id: Ic6d24b17b2293adf8d715904c8c1874a4c624e99
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Under certain conditions finger swipes are ignored.
Steps to reproduce the bug:
- Open left menu
- Close menu choosing an option or tapping out of the preview
- Tap preview of last picture in bottom left corner
Swipes in the gallry should now be ignored until a right to left
swipe is performed in the preview.
Change-Id: I3928d84360266cca368265553a037192aa5d6780
|
|
|
|
| |
Change-Id: I63a3df10c64a0141cfda161310c3a404349d5c70
|
|
|
|
| |
Change-Id: I33f654de17045dd88cb6bab0a46d16b6ab8d0022
|
|
|
|
| |
Change-Id: Idd754c9d82e5daf252be6c93f7d51fc526aaa118
|
|
|
|
| |
Change-Id: I5eb20d694d944f4ff486c1d0393480ecbd03e46c
|
|
|
|
| |
Change-Id: I2d98aea34658611afa63b80953ef13b95c3a6ca4
|
|
|
|
| |
Change-Id: Ibb62ad15d6f97d6e04b4f861f3dc7d238c696377
|
|
|
|
| |
Change-Id: Ib7c19a76567db2df0836fb9f99c52337ef4e1f18
|
|
|
|
|
|
|
|
|
|
|
| |
to front camera"
Some devices (ex. LG G5, V20, and G6) have perfectly functional dual rear camera's that
work fine. No reason to force the number of camera's to 2
This reverts commit fab321f61b6fe4e1296806ff5b04bac19d1e4de6.
Change-Id: I1ffb0defa299e107b7f193b7b72af3567c4947df
|
|
|
|
|
|
|
|
|
|
|
| |
Log:
03-07 13:00:45.697 2812 2830 W BroadcastQueue: Permission Denial:
receiving Intent { act=android.intent.action.BOOT_COMPLETED
flg=0x9000010 (has extras) } to
org.cyanogenmod.snap/com.android.camera.DisableCameraReceiver requires
android.permission.RECEIVE_BOOT_COMPLETED due to sender null (uid 1000)
Change-Id: I55cd1c96ac1a06b644fc207c235f694c8a60da99
|
|
|
|
| |
Change-Id: I99f4c26862ac9af014a2020ee326b62196d54696
|
|
|
|
|
|
|
|
| |
Calling onSingleTapUp() from onScroll() is causing Snap to issue
a focus request for every touch movement, including the gestures
to open the menu and the gallery.
Change-Id: If913607735add13c1af8e0882748d4800e4e10f9
|
|
|
|
|
|
|
|
|
| |
An <activity> with an <activity-alias> doesn't automatically set
"exported" to "true" if only <activity-alias> has intent filters.
As consequence, it's impossible to re-start <activity> from the
recent applications menu. Explicitly set exported to true to fix this.
Change-Id: Id9612d704e71b5fa8093462e893a964753d67d50
|
|
|
|
| |
Change-Id: Id036acb80669609e9ea3886ca5ec8df4a387034e
|
|
|
|
|
|
| |
Fixes camera hang on LG G4 when flash mode is auto and flash is required.
Change-Id: I258fed2364e37f6b40ee5e13f3359167ce13ff8f
|
|
|
|
| |
Change-Id: Idd699c976b633e85f815189d918194201977aa6b
|
|
|
|
|
|
|
|
| |
Some devices have dual rear cameras, which means that they will have
more than just 2 camera ID's (0 and 1). For example, the LG G5 has
0, 1 and 2. Allow Snap to run cycle through more than just 0 and 1
Change-Id: I50d8b6c02c97961990b1fbf69b9cf706c422381c
|
|
|
|
| |
Change-Id: I0517e5849c93d71fa906e84d97ef4a0cf037386c
|
|
|
|
| |
Change-Id: I6c8a015f3cf7c9c47a3d57a433445424642175ed
|
|
|
|
|
|
|
|
| |
Track changes made to PhotoUI and VideoUI in commits
2bf3a05c66d350e253956503a9388946c1be1c1c and
7bcdf0a9801cfbdc2d170b8d840c8dec672976d0.
Change-Id: Ic47181eae09d8a094d367751194d13ac4d1c2785
|