diff options
author | Sascha Haeberling <haeberling@google.com> | 2013-09-24 18:58:34 -0700 |
---|---|---|
committer | Sascha Haeberling <haeberling@google.com> | 2013-09-24 21:42:10 -0700 |
commit | 98f38bb04daa3db49a072718cd8b5005b8b73af1 (patch) | |
tree | 09f64d1dfdf0837a3f042fae987de58ccc54c625 /src | |
parent | 4601f5d987ad2f57db6b1b65a716f00308e5ae99 (diff) | |
download | android_packages_apps_Snap-98f38bb04daa3db49a072718cd8b5005b8b73af1.tar.gz android_packages_apps_Snap-98f38bb04daa3db49a072718cd8b5005b8b73af1.tar.bz2 android_packages_apps_Snap-98f38bb04daa3db49a072718cd8b5005b8b73af1.zip |
Add HQ option and use it to switch to GCam.
Bug: 10430748
Bug: 10785988
Change-Id: If824d1d1876d8434958b2a5bc97d2852da118a8b
Diffstat (limited to 'src')
-rw-r--r-- | src/com/android/camera/CameraActivity.java | 2 | ||||
-rw-r--r-- | src/com/android/camera/CameraSettings.java | 10 | ||||
-rw-r--r-- | src/com/android/camera/PhotoMenu.java | 6 | ||||
-rw-r--r-- | src/com/android/camera/PhotoModule.java | 10 | ||||
-rw-r--r-- | src/com/android/camera/ui/ModuleSwitcher.java | 4 | ||||
-rw-r--r-- | src/com/android/camera/util/ApiHelper.java | 1 |
6 files changed, 25 insertions, 8 deletions
diff --git a/src/com/android/camera/CameraActivity.java b/src/com/android/camera/CameraActivity.java index d4a72055d..55b3dd7c5 100644 --- a/src/com/android/camera/CameraActivity.java +++ b/src/com/android/camera/CameraActivity.java @@ -944,7 +944,7 @@ public class CameraActivity extends Activity SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(this); moduleIndex = prefs.getInt(PREF_STARTUP_MODULE_INDEX, -1); if ((moduleIndex == ModuleSwitcher.GCAM_MODULE_INDEX && - !GcamHelper.hasGcamCapture(this)) || moduleIndex < 0) { + !GcamHelper.hasGcamCapture()) || moduleIndex < 0) { moduleIndex = ModuleSwitcher.PHOTO_MODULE_INDEX; } } diff --git a/src/com/android/camera/CameraSettings.java b/src/com/android/camera/CameraSettings.java index 19d0fda56..6faabcd5b 100644 --- a/src/com/android/camera/CameraSettings.java +++ b/src/com/android/camera/CameraSettings.java @@ -61,6 +61,7 @@ public class CameraSettings { public static final String KEY_VIDEO_EFFECT = "pref_video_effect_key"; public static final String KEY_CAMERA_ID = "pref_camera_id_key"; public static final String KEY_CAMERA_HDR = "pref_camera_hdr_key"; + public static final String KEY_CAMERA_HQ = "pref_camera_hq_key"; public static final String KEY_CAMERA_FIRST_USE_HINT_SHOWN = "pref_camera_first_use_hint_shown_key"; public static final String KEY_VIDEO_FIRST_USE_HINT_SHOWN = "pref_video_first_use_hint_shown_key"; public static final String KEY_PHOTOSPHERE_PICTURESIZE = "pref_photosphere_picturesize_key"; @@ -170,6 +171,7 @@ public class CameraSettings { group.findPreference(KEY_VIDEOCAMERA_FLASH_MODE); ListPreference videoEffect = group.findPreference(KEY_VIDEO_EFFECT); ListPreference cameraHdr = group.findPreference(KEY_CAMERA_HDR); + ListPreference cameraHq = group.findPreference(KEY_CAMERA_HQ); // Since the screen could be loaded from different resources, we need // to check if the preference is available here @@ -216,10 +218,14 @@ public class CameraSettings { if (videoEffect != null) { filterUnsupportedOptions(group, videoEffect, null); } - if (cameraHdr != null && !GcamHelper.hasGcamAsHDRMode() - && (!ApiHelper.HAS_CAMERA_HDR || !CameraUtil.isCameraHdrSupported(mParameters))) { + if (cameraHdr != null && !ApiHelper.HAS_CAMERA_HDR + || !CameraUtil.isCameraHdrSupported(mParameters)) { removePreference(group, cameraHdr.getKey()); } + if (cameraHq != null && (!ApiHelper.HAS_CAMERA_HQ + | !GcamHelper.hasGcamAsHDRMode())) { + removePreference(group, cameraHq.getKey()); + } } private void buildExposureCompensation( diff --git a/src/com/android/camera/PhotoMenu.java b/src/com/android/camera/PhotoMenu.java index 6f47e136a..77e8de417 100644 --- a/src/com/android/camera/PhotoMenu.java +++ b/src/com/android/camera/PhotoMenu.java @@ -55,6 +55,12 @@ public class PhotoMenu extends PieController Locale locale = res.getConfiguration().locale; // the order is from left to right in the menu + // hq (GCam) + if (group.findPreference(CameraSettings.KEY_CAMERA_HQ) != null) { + item = makeSwitchItem(CameraSettings.KEY_CAMERA_HQ, true); + mRenderer.addItem(item); + } + // hdr if (group.findPreference(CameraSettings.KEY_CAMERA_HDR) != null) { item = makeSwitchItem(CameraSettings.KEY_CAMERA_HDR, true); diff --git a/src/com/android/camera/PhotoModule.java b/src/com/android/camera/PhotoModule.java index 915cbc8a5..fc23876cc 100644 --- a/src/com/android/camera/PhotoModule.java +++ b/src/com/android/camera/PhotoModule.java @@ -1619,12 +1619,16 @@ public class PhotoModule // Since changing scene mode may change supported values, set scene mode // first. HDR is a scene mode. To promote it in UI, it is stored in a // separate preference. + String onValue = mActivity.getString(R.string.setting_on_value); String hdr = mPreferences.getString(CameraSettings.KEY_CAMERA_HDR, mActivity.getString(R.string.pref_camera_hdr_default)); - boolean doGcamModeSwitch = false; - String onValue = mActivity.getString(R.string.setting_on_value); + String hq = mPreferences.getString(CameraSettings.KEY_CAMERA_HQ, + mActivity.getString(R.string.pref_camera_hq_default)); boolean hdrOn = onValue.equals(hdr); - if ( hdrOn && GcamHelper.hasGcamAsHDRMode()) { + boolean hqOn = onValue.equals(hq); + + boolean doGcamModeSwitch = false; + if (hqOn && GcamHelper.hasGcamCapture()) { // Kick off mode switch to gcam. doGcamModeSwitch = true; } else { diff --git a/src/com/android/camera/ui/ModuleSwitcher.java b/src/com/android/camera/ui/ModuleSwitcher.java index 7c74651f6..9493d98b7 100644 --- a/src/com/android/camera/ui/ModuleSwitcher.java +++ b/src/com/android/camera/ui/ModuleSwitcher.java @@ -108,7 +108,7 @@ public class ModuleSwitcher extends RotateImageView --numDrawIds; } - if (!GcamHelper.hasGcamCapture(context) || GcamHelper.hasGcamAsHDRMode()) { + if (!GcamHelper.hasGcamCapture() || GcamHelper.hasGcamAsHDRMode()) { --numDrawIds; } @@ -120,7 +120,7 @@ public class ModuleSwitcher extends RotateImageView continue; // not enabled, so don't add to UI } if (i == GCAM_MODULE_INDEX - && (!GcamHelper.hasGcamCapture(context) || GcamHelper.hasGcamAsHDRMode())) { + && (!GcamHelper.hasGcamCapture() || GcamHelper.hasGcamAsHDRMode())) { continue; // not enabled, so don't add to UI } moduleids[ix] = i; diff --git a/src/com/android/camera/util/ApiHelper.java b/src/com/android/camera/util/ApiHelper.java index 994687f84..46cfd6183 100644 --- a/src/com/android/camera/util/ApiHelper.java +++ b/src/com/android/camera/util/ApiHelper.java @@ -39,6 +39,7 @@ public class ApiHelper { public static final boolean HAS_SURFACE_TEXTURE_RECORDING = Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN; + public static final boolean HAS_CAMERA_HQ = isKitKatOrHigher(); public static final boolean HAS_CAMERA_HDR = Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1; public static final boolean HAS_DISPLAY_LISTENER = |