summaryrefslogtreecommitdiffstats
path: root/src/com
diff options
context:
space:
mode:
authorDanny Baumann <dannybaumann@web.de>2016-01-10 14:14:25 +0100
committerSteve Kondik <steve@cyngn.com>2016-11-02 12:22:29 -0700
commitd2fc03537902a6f5bb19645a35c4698d3cbfaf5f (patch)
tree0ef965b18f10c6470953e7a9d724a276069fd2f8 /src/com
parentdaea7de004eec7982b3f4021f4fb109836f7f2da (diff)
downloadandroid_packages_apps_Snap-d2fc03537902a6f5bb19645a35c4698d3cbfaf5f.tar.gz
android_packages_apps_Snap-d2fc03537902a6f5bb19645a35c4698d3cbfaf5f.tar.bz2
android_packages_apps_Snap-d2fc03537902a6f5bb19645a35c4698d3cbfaf5f.zip
Don't do touch-to-focus for touches outside of the preview.
Issue was twofold: - Preview size was updated from the root view instead of the preview surface view. As the preview rect is already correctly updated from the surface view, remove the redundant size update code. - Touches outside of the preview rect weren't discarded properly. Change-Id: I1c9a4398aa51a828b5362fcd7bcd5a7a7e4691db
Diffstat (limited to 'src/com')
-rw-r--r--src/com/android/camera/FocusOverlayManager.java2
-rwxr-xr-xsrc/com/android/camera/PhotoModule.java6
2 files changed, 1 insertions, 7 deletions
diff --git a/src/com/android/camera/FocusOverlayManager.java b/src/com/android/camera/FocusOverlayManager.java
index 875fe779f..24a2befbc 100644
--- a/src/com/android/camera/FocusOverlayManager.java
+++ b/src/com/android/camera/FocusOverlayManager.java
@@ -383,7 +383,7 @@ public class FocusOverlayManager {
mState == STATE_SUCCESS || mState == STATE_FAIL)) {
cancelAutoFocus();
}
- if (mPreviewRect.width() == 0 || mPreviewRect.height() == 0) return;
+ if (mPreviewRect.isEmpty() || !mPreviewRect.contains(x, y)) return;
// Initialize variables.
// Initialize mFocusArea.
if (mFocusAreaSupported) {
diff --git a/src/com/android/camera/PhotoModule.java b/src/com/android/camera/PhotoModule.java
index 4ec0a47c4..250e66d6a 100755
--- a/src/com/android/camera/PhotoModule.java
+++ b/src/com/android/camera/PhotoModule.java
@@ -2689,12 +2689,6 @@ public class PhotoModule
// we will update focus manager with proper UI.
if (mFocusManager != null && mUI != null) {
mFocusManager.setPhotoUI(mUI);
-
- View root = mUI.getRootView();
- // These depend on camera parameters.
- int width = root.getWidth();
- int height = root.getHeight();
- mFocusManager.setPreviewSize(width, height);
}
}