summaryrefslogtreecommitdiffstats
path: root/src/com/android/camera/VideoMenu.java
diff options
context:
space:
mode:
authorjunjiez <junjiez@codeaurora.org>2017-01-19 16:54:02 +0800
committerjunjiez <junjiez@codeaurora.org>2017-02-22 14:38:07 +0800
commit7b7247768e2c4c891329d60e965bbbc4853700d0 (patch)
tree87fd58aa3fff7fe1e4c3dcf05d5ea66d6626df95 /src/com/android/camera/VideoMenu.java
parent3196565b3091f36a00428c0509c2bfd959c84b85 (diff)
downloadandroid_packages_apps_Snap-7b7247768e2c4c891329d60e965bbbc4853700d0.tar.gz
android_packages_apps_Snap-7b7247768e2c4c891329d60e965bbbc4853700d0.tar.bz2
android_packages_apps_Snap-7b7247768e2c4c891329d60e965bbbc4853700d0.zip
napdragonCamera: Fix crash when swith to fisheye
Add judgement to avoid crash when preference of CameraSettings.KEY_VIDEO_HIGH_FRAME_RATE is null. Change-Id: Ifb8ffd585b6bc802d2252d63709da5d178bbd55d CRs-Fixed: 1111662
Diffstat (limited to 'src/com/android/camera/VideoMenu.java')
-rwxr-xr-x[-rw-r--r--]src/com/android/camera/VideoMenu.java32
1 files changed, 18 insertions, 14 deletions
diff --git a/src/com/android/camera/VideoMenu.java b/src/com/android/camera/VideoMenu.java
index ea4415fe6..a5107a27a 100644..100755
--- a/src/com/android/camera/VideoMenu.java
+++ b/src/com/android/camera/VideoMenu.java
@@ -776,21 +776,25 @@ public class VideoMenu extends MenuController
.getInt("persist.camcorder.eis.maxfps", 30);
ListPreference hfrPref = mPreferenceGroup
.findPreference(CameraSettings.KEY_VIDEO_HIGH_FRAME_RATE);
- if (hfrPref != null) {
- String highFrameRate = hfrPref.getValue();
- boolean isHFR = "hfr".equals(highFrameRate.substring(0,3));
- boolean isHSR = "hsr".equals(highFrameRate.substring(0,3));
- int rate = 0;
- if ( isHFR || isHSR ) {
- String hfrRate = highFrameRate.substring(3);
- rate = Integer.parseInt(hfrRate);
- }
+ String highFrameRate;
+ if (hfrPref == null) {
+ //If hfrPref is null, use whitespace instead.
+ highFrameRate = " ";
+ } else {
+ highFrameRate = hfrPref.getValue();
+ }
+ boolean isHFR = "hfr".equals(highFrameRate.substring(0,3));
+ boolean isHSR = "hsr".equals(highFrameRate.substring(0,3));
+ int rate = 0;
+ if ( isHFR || isHSR ) {
+ String hfrRate = highFrameRate.substring(3);
+ rate = Integer.parseInt(hfrRate);
+ }
- if ((disMode.equals("enable") && rate > PERSIST_EIS_MAX_FPS)
- || !videoHDR.equals("off")
- || timeLapseInterval != 0) {
- mListMenu.setPreferenceEnabled(CameraSettings.KEY_VIDEO_HIGH_FRAME_RATE, false);
- }
+ if ((disMode.equals("enable") && rate > PERSIST_EIS_MAX_FPS)
+ || !videoHDR.equals("off")
+ || timeLapseInterval != 0) {
+ mListMenu.setPreferenceEnabled(CameraSettings.KEY_VIDEO_HIGH_FRAME_RATE, false);
}
}