summaryrefslogtreecommitdiffstats
path: root/src/com/android/camera/CameraActivity.java
diff options
context:
space:
mode:
authorJay Wang <jaywang@codeaurora.org>2016-08-22 20:17:37 -0700
committerGerrit - the friendly Code Review server <code-review@localhost>2016-09-15 15:06:57 -0700
commit1e35ddbc3328515c0bd4c370f6829a3acf1b35cd (patch)
tree8be55e3d438a0ea291b7c7121892833a5cce14d5 /src/com/android/camera/CameraActivity.java
parentca9a3f991cb2f18f64c36ab6f4e870cbade6c6b1 (diff)
downloadandroid_packages_apps_Snap-1e35ddbc3328515c0bd4c370f6829a3acf1b35cd.tar.gz
android_packages_apps_Snap-1e35ddbc3328515c0bd4c370f6829a3acf1b35cd.tar.bz2
android_packages_apps_Snap-1e35ddbc3328515c0bd4c370f6829a3acf1b35cd.zip
SnapdragonCamera: Fix memory leak when updating thumbnails.
Fix a memory leak with jpeg data buffers saved for updating thumbnails. Ensure that all references are freed and released when exiting. CRs-Fixed: 1054441 Change-Id: Idc79f51f0e70b0b3e39d614ff3dd7f5d1f85aaad
Diffstat (limited to 'src/com/android/camera/CameraActivity.java')
-rw-r--r--src/com/android/camera/CameraActivity.java15
1 files changed, 13 insertions, 2 deletions
diff --git a/src/com/android/camera/CameraActivity.java b/src/com/android/camera/CameraActivity.java
index e7c55dfab..4a56e447e 100644
--- a/src/com/android/camera/CameraActivity.java
+++ b/src/com/android/camera/CameraActivity.java
@@ -761,8 +761,8 @@ public class CameraActivity extends Activity
}
private class UpdateThumbnailTask extends AsyncTask<Void, Void, Bitmap> {
- private final byte[] mJpegData;
- private final boolean mCheckOrientation;
+ private byte[] mJpegData;
+ private boolean mCheckOrientation;
public UpdateThumbnailTask(final byte[] jpegData, boolean checkOrientation) {
mJpegData = jpegData;
@@ -805,6 +805,17 @@ public class CameraActivity extends Activity
} else {
updateThumbnail(bitmap);
}
+
+ mJpegData = null;
+ }
+
+ @Override
+ protected void onCancelled(Bitmap bitmap) {
+ if(bitmap != null)
+ bitmap.recycle();
+
+ bitmap = null;
+ mJpegData = null;
}
private Bitmap decodeImageCenter(final String path) {