summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRomain Guy <romainguy@google.com>2012-10-03 18:47:21 -0700
committerTeng-Hui Zhu <ztenghui@google.com>2012-10-30 14:18:16 -0700
commit6af05206f0b71f7a09ed7d9f8763535723796d75 (patch)
treeb7620b270ffb0ea00235724e1d0bebcb79d5fe91
parent883295bc3643c5d3e0520fa317bec9919cc4ff7c (diff)
downloadandroid_packages_apps_Snap-6af05206f0b71f7a09ed7d9f8763535723796d75.tar.gz
android_packages_apps_Snap-6af05206f0b71f7a09ed7d9f8763535723796d75.tar.bz2
android_packages_apps_Snap-6af05206f0b71f7a09ed7d9f8763535723796d75.zip
DO NOT MERGE: Do not set the background to null for video.
Bug #7275145 Bug 7405595 Removing the window background when it's not visible is a good idea to save on performance. Removing *all* the backgrounds is just a silly idea that leads to weird looking results that drive graphics engineers mad for a day until they figure out that everything is working properly and that the app is simply asking the system to draw whatever garbage is left in the GPU's graphics buffers. Cherry pick the Romain's change from jb-mr1-dev: https://googleplex-android-review.googlesource.com/#/c/234571/ Change-Id: Ief88821319989add5fda57ae7b69cdb01f6ccdf4
-rw-r--r--src/com/android/gallery3d/app/MoviePlayer.java22
1 files changed, 1 insertions, 21 deletions
diff --git a/src/com/android/gallery3d/app/MoviePlayer.java b/src/com/android/gallery3d/app/MoviePlayer.java
index 9d229f088..85dc4427e 100644
--- a/src/com/android/gallery3d/app/MoviePlayer.java
+++ b/src/com/android/gallery3d/app/MoviePlayer.java
@@ -74,8 +74,8 @@ public class MoviePlayer implements
private static final long RESUMEABLE_TIMEOUT = 3 * 60 * 1000; // 3 mins
private Context mContext;
- private final VideoView mVideoView;
private final View mRootView;
+ private final VideoView mVideoView;
private final Bookmarker mBookmarker;
private final Uri mUri;
private final Handler mHandler = new Handler();
@@ -104,14 +104,6 @@ public class MoviePlayer implements
}
};
- private final Runnable mRemoveBackground = new Runnable() {
- @SuppressWarnings("deprecation")
- @Override
- public void run() {
- mRootView.setBackgroundDrawable(null);
- }
- };
-
private final Runnable mProgressChecker = new Runnable() {
@Override
public void run() {
@@ -199,19 +191,7 @@ public class MoviePlayer implements
if ((diff & View.SYSTEM_UI_FLAG_HIDE_NAVIGATION) != 0
&& (visibility & View.SYSTEM_UI_FLAG_HIDE_NAVIGATION) == 0) {
mController.show();
-
- // We need to set the background to clear ghosting images
- // when ActionBar slides in. However, if we keep the background,
- // there will be one additional layer in HW composer, which is bad
- // to battery. As a solution, we remove the background when we
- // hide the action bar
- mHandler.removeCallbacks(mRemoveBackground);
mRootView.setBackgroundColor(Color.BLACK);
- } else {
- mHandler.removeCallbacks(mRemoveBackground);
-
- // Wait for the slide out animation, one second should be enough
- mHandler.postDelayed(mRemoveBackground, 1000);
}
}
});