diff options
| author | George Mount <mount@google.com> | 2012-10-23 15:03:14 -0700 |
|---|---|---|
| committer | Android (Google) Code Review <android-gerrit@google.com> | 2012-10-23 15:03:15 -0700 |
| commit | 52863a17f1e0aab3d47a6b98b72812187620ee84 (patch) | |
| tree | 502fa73d294e6dc9d4f682a6b0d88a083945b311 | |
| parent | 1b5ec22976ca5182a16228bc5ca1b12130923856 (diff) | |
| parent | 4588b65ebb1aacef2a991d5da6659d69f791e571 (diff) | |
| download | android_packages_apps_Snap-52863a17f1e0aab3d47a6b98b72812187620ee84.tar.gz android_packages_apps_Snap-52863a17f1e0aab3d47a6b98b72812187620ee84.tar.bz2 android_packages_apps_Snap-52863a17f1e0aab3d47a6b98b72812187620ee84.zip | |
Merge "Fix NPE in detecting panoramas." into gb-ub-photos-arches
| -rw-r--r-- | src/com/android/gallery3d/app/PanoramaMetadataSupport.java | 10 | ||||
| -rw-r--r-- | src_pd/com/android/gallery3d/util/LightCycleHelper.java | 2 |
2 files changed, 8 insertions, 4 deletions
diff --git a/src/com/android/gallery3d/app/PanoramaMetadataSupport.java b/src/com/android/gallery3d/app/PanoramaMetadataSupport.java index d40422582..ba0c9e71a 100644 --- a/src/com/android/gallery3d/app/PanoramaMetadataSupport.java +++ b/src/com/android/gallery3d/app/PanoramaMetadataSupport.java @@ -20,6 +20,7 @@ import com.android.gallery3d.data.MediaObject.PanoramaSupportCallback; import com.android.gallery3d.data.PanoramaMetadataJob; import com.android.gallery3d.util.Future; import com.android.gallery3d.util.FutureListener; +import com.android.gallery3d.util.LightCycleHelper; import com.android.gallery3d.util.LightCycleHelper.PanoramaMetadata; import java.util.ArrayList; @@ -77,13 +78,16 @@ public class PanoramaMetadataSupport implements FutureListener<PanoramaMetadata> public void onFutureDone(Future<PanoramaMetadata> future) { synchronized (mLock) { mPanoramaMetadata = future.get(); + if (mPanoramaMetadata == null) { + // Error getting panorama data from file. Treat as not panorama. + mPanoramaMetadata = LightCycleHelper.NOT_PANORAMA; + } for (PanoramaSupportCallback cb : mCallbacksWaiting) { - cb.panoramaInfoAvailable(mMediaObject, - mPanoramaMetadata.mUsePanoramaViewer, + cb.panoramaInfoAvailable(mMediaObject, mPanoramaMetadata.mUsePanoramaViewer, mPanoramaMetadata.mIsPanorama360); } mGetPanoMetadataTask = null; mCallbacksWaiting = null; } - } + } } diff --git a/src_pd/com/android/gallery3d/util/LightCycleHelper.java b/src_pd/com/android/gallery3d/util/LightCycleHelper.java index 68c019567..bceeea6b4 100644 --- a/src_pd/com/android/gallery3d/util/LightCycleHelper.java +++ b/src_pd/com/android/gallery3d/util/LightCycleHelper.java @@ -61,7 +61,7 @@ public class LightCycleHelper { } } - private static final PanoramaMetadata NOT_PANORAMA = new PanoramaMetadata(false, false); + public static final PanoramaMetadata NOT_PANORAMA = new PanoramaMetadata(false, false); public static void setupCaptureIntent(Context context, Intent it, String outputDir) { /* Do nothing */ |