diff options
author | ztenghui <ztenghui@google.com> | 2013-10-28 18:09:51 +0000 |
---|---|---|
committer | Android (Google) Code Review <android-gerrit@google.com> | 2013-10-28 18:09:51 +0000 |
commit | 5250fb28143d45c41673a572b4c5b350e6563eb0 (patch) | |
tree | 008c68f4ec3f68faf50ff9a761610c8079512afc | |
parent | d053a5b2aa8cd9cb09bd40962b305ef34e7d404b (diff) | |
parent | e1aa59ba7b3a9fb578995ee8ffcd232c11a97842 (diff) | |
download | android_packages_apps_Snap-5250fb28143d45c41673a572b4c5b350e6563eb0.tar.gz android_packages_apps_Snap-5250fb28143d45c41673a572b4c5b350e6563eb0.tar.bz2 android_packages_apps_Snap-5250fb28143d45c41673a572b4c5b350e6563eb0.zip |
Merge "Fix memory leak due to inner class for handler." into gb-ub-photos-carlsbad
-rw-r--r-- | src/com/android/camera/AndroidCameraManagerImpl.java | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/com/android/camera/AndroidCameraManagerImpl.java b/src/com/android/camera/AndroidCameraManagerImpl.java index d9e21fdd0..ac9b7eb4e 100644 --- a/src/com/android/camera/AndroidCameraManagerImpl.java +++ b/src/com/android/camera/AndroidCameraManagerImpl.java @@ -814,7 +814,10 @@ class AndroidCameraManagerImpl implements CameraManager { private CameraOpenErrorCallbackForward( Handler h, CameraOpenErrorCallback cb) { - mHandler = h; + // Given that we are using the main thread handler, we can create it + // here instead of holding onto the PhotoModule objects. In this + // way, we can avoid memory leak. + mHandler = new Handler(Looper.getMainLooper()); mCallback = cb; } |