summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJay Wang <jaywang@codeaurora.org>2016-07-05 13:51:01 -0700
committerJay Wang <jaywang@codeaurora.org>2016-07-05 13:51:01 -0700
commit98c87f001e0593183237404e73460c43130bf47f (patch)
treeda1d5197e288de424eb4273d0d54054d319f6eb9
parentde98a47425d6f9b1ee017829f99d61ad0620266f (diff)
downloadandroid_packages_apps_Snap-98c87f001e0593183237404e73460c43130bf47f.tar.gz
android_packages_apps_Snap-98c87f001e0593183237404e73460c43130bf47f.tar.bz2
android_packages_apps_Snap-98c87f001e0593183237404e73460c43130bf47f.zip
SnapdragonCamera: Resolve integer overflow issue
The video bit rate calculation can cause integer overflow due to multiplying two huge numbers. To resolve the issue, do the division before the multiplication. Change-Id: I8b077fd68ed3e4f22cc5a2f9cb2a1490d0ed3376 CRs-Fixed: 1030274
-rw-r--r--src/com/android/camera/VideoModule.java2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/com/android/camera/VideoModule.java b/src/com/android/camera/VideoModule.java
index 9cb48eb0f..0f40702ce 100644
--- a/src/com/android/camera/VideoModule.java
+++ b/src/com/android/camera/VideoModule.java
@@ -1548,7 +1548,7 @@ public class VideoModule implements CameraModule,
// Profiles advertizes bitrate corresponding to published framerate.
// In case framerate is different, scale the bitrate
- int scaledBitrate = mProfile.videoBitRate * targetFrameRate / mProfile.videoFrameRate;
+ int scaledBitrate = mProfile.videoBitRate * (targetFrameRate / mProfile.videoFrameRate);
Log.i(TAG, "Scaled Video bitrate : " + scaledBitrate);
mMediaRecorder.setVideoEncodingBitRate(scaledBitrate);
}