summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorByunghun Jeon <bjeon@codeaurora.org>2015-10-06 14:42:58 -0700
committerJaimin Bhise <jbhise@codeaurora.org>2015-10-29 14:04:57 -0700
commit2a76300ad29835b8a04e2f890f7fd41476d6ee1b (patch)
treeca55a36164b3688e84ab2f8833d5d41984f1d2a7
parentc070d626428a3c28596207675ef185199bd5ff77 (diff)
downloadandroid_packages_apps_Snap-2a76300ad29835b8a04e2f890f7fd41476d6ee1b.tar.gz
android_packages_apps_Snap-2a76300ad29835b8a04e2f890f7fd41476d6ee1b.tar.bz2
android_packages_apps_Snap-2a76300ad29835b8a04e2f890f7fd41476d6ee1b.zip
SnapdragonCamera: Fix crash issue with enable FD with TruePortrait
Fixes ui operation on background thread issue with always enabling FD with TruePortrait on. Change-Id: I976d206c2114aba1e1c5ae4b53959093c2836942
-rw-r--r--src/com/android/camera/PhotoModule.java15
1 files changed, 13 insertions, 2 deletions
diff --git a/src/com/android/camera/PhotoModule.java b/src/com/android/camera/PhotoModule.java
index 3117a2e52..c9454228a 100644
--- a/src/com/android/camera/PhotoModule.java
+++ b/src/com/android/camera/PhotoModule.java
@@ -3150,7 +3150,13 @@ public class PhotoModule
.equals(advancedFeature)) {
// face detection must always be on for truePortrait
if (CameraUtil.isSupported(Parameters.FACE_DETECTION_ON, mParameters.getSupportedFaceDetectionModes())) {
- mUI.overrideSettings(CameraSettings.KEY_FACE_DETECTION, Parameters.FACE_DETECTION_ON);
+ mActivity.runOnUiThread(new Runnable() {
+ @Override
+ public void run() {
+ mUI.overrideSettings(CameraSettings.KEY_FACE_DETECTION, Parameters.FACE_DETECTION_ON);
+ }
+ });
+
mParameters.setFaceDetectionMode(Parameters.FACE_DETECTION_ON);
if(mFaceDetectionEnabled == false) {
mFaceDetectionEnabled = true;
@@ -3160,7 +3166,12 @@ public class PhotoModule
} else {
// Set face detetction parameter.
// clear override to re-enable setting if true portrait is off.
- mUI.overrideSettings(CameraSettings.KEY_FACE_DETECTION, null);
+ mActivity.runOnUiThread(new Runnable() {
+ @Override
+ public void run() {
+ mUI.overrideSettings(CameraSettings.KEY_FACE_DETECTION, null);
+ }
+ });
String faceDetection = mPreferences.getString(
CameraSettings.KEY_FACE_DETECTION,