summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArne Coucheron <arco68@gmail.com>2018-05-18 05:10:12 +0200
committerBruno Martins <bgcngm@gmail.com>2018-11-20 12:32:17 +0000
commit9eac1650f2883f814c86b307dd1b3841fd1389a3 (patch)
tree4a52e4a8d15dd07d145c2bd8e499128614ee3703
parentd76d0a0bac483fe91942787ccde6b78c983f037b (diff)
downloadandroid_packages_apps_Snap-9eac1650f2883f814c86b307dd1b3841fd1389a3.tar.gz
android_packages_apps_Snap-9eac1650f2883f814c86b307dd1b3841fd1389a3.tar.bz2
android_packages_apps_Snap-9eac1650f2883f814c86b307dd1b3841fd1389a3.zip
Snap: Check for ACCESS_FINE_LOCATION instead of ACCESS_COARSE_LOCATION
ACCESS_FINE_LOCATION is now required for GPS location feature to work. | LocationManager: java.lang.SecurityException: "gps" location provider requires ACCESS_FINE_LOCATION permission. Change-Id: I6b2f11bdab719cb9fc74a67a8e91ad558269d579
-rw-r--r--AndroidManifest.xml2
-rwxr-xr-xsrc/com/android/camera/CameraActivity.java10
-rwxr-xr-xsrc/com/android/camera/LocationManager.java2
-rwxr-xr-xsrc/com/android/camera/PermissionsActivity.java4
-rw-r--r--src/com/android/camera/PhotoModule.java2
5 files changed, 9 insertions, 11 deletions
diff --git a/AndroidManifest.xml b/AndroidManifest.xml
index ce931460d..67ae8216b 100644
--- a/AndroidManifest.xml
+++ b/AndroidManifest.xml
@@ -7,8 +7,6 @@
android:minSdkVersion="23"
android:targetSdkVersion="26" />
-
- <uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" />
<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
<uses-permission android:name="android.permission.ACCESS_WIFI_STATE" />
diff --git a/src/com/android/camera/CameraActivity.java b/src/com/android/camera/CameraActivity.java
index acd524e4d..2d776c758 100755
--- a/src/com/android/camera/CameraActivity.java
+++ b/src/com/android/camera/CameraActivity.java
@@ -172,7 +172,7 @@ public class CameraActivity extends Activity
private static final int SWITCH_SAVE_PATH = 2;
/** Permission request code */
- private static final int PERMISSIONS_REQUEST_ACCESS_COARSE_LOCATION = 1;
+ private static final int PERMISSIONS_REQUEST_ACCESS_FINE_LOCATION = 1;
/** Whether onResume should reset the view to the preview. */
private boolean mResetToPreviewOnResume = true;
@@ -2128,13 +2128,13 @@ public class CameraActivity extends Activity
}
public void requestLocationPermission() {
- if (checkSelfPermission(Manifest.permission.ACCESS_COARSE_LOCATION)
+ if (checkSelfPermission(Manifest.permission.ACCESS_FINE_LOCATION)
!= PackageManager.PERMISSION_GRANTED) {
Log.v(TAG, "Request Location permission");
mCurrentModule.waitingLocationPermissionResult(true);
requestPermissions(
- new String[]{Manifest.permission.ACCESS_COARSE_LOCATION},
- PERMISSIONS_REQUEST_ACCESS_COARSE_LOCATION);
+ new String[]{Manifest.permission.ACCESS_FINE_LOCATION},
+ PERMISSIONS_REQUEST_ACCESS_FINE_LOCATION);
}
}
@@ -2142,7 +2142,7 @@ public class CameraActivity extends Activity
public void onRequestPermissionsResult(int requestCode,
String permissions[], int[] grantResults) {
switch (requestCode) {
- case PERMISSIONS_REQUEST_ACCESS_COARSE_LOCATION: {
+ case PERMISSIONS_REQUEST_ACCESS_FINE_LOCATION: {
// If request is cancelled, the result arrays are empty.
mCurrentModule.waitingLocationPermissionResult(false);
if (grantResults.length > 0
diff --git a/src/com/android/camera/LocationManager.java b/src/com/android/camera/LocationManager.java
index 5aedf060e..2ae901aed 100755
--- a/src/com/android/camera/LocationManager.java
+++ b/src/com/android/camera/LocationManager.java
@@ -79,7 +79,7 @@ public class LocationManager {
}
private boolean hasLoationPermission() {
- return mContext.checkSelfPermission(Manifest.permission.ACCESS_COARSE_LOCATION)
+ return mContext.checkSelfPermission(Manifest.permission.ACCESS_FINE_LOCATION)
== PackageManager.PERMISSION_GRANTED;
}
diff --git a/src/com/android/camera/PermissionsActivity.java b/src/com/android/camera/PermissionsActivity.java
index 91699c34f..fb0c080db 100755
--- a/src/com/android/camera/PermissionsActivity.java
+++ b/src/com/android/camera/PermissionsActivity.java
@@ -79,7 +79,7 @@ public class PermissionsActivity extends Activity {
mFlagHasStoragePermission = true;
}
- if (checkSelfPermission(Manifest.permission.ACCESS_COARSE_LOCATION)
+ if (checkSelfPermission(Manifest.permission.ACCESS_FINE_LOCATION)
!= PackageManager.PERMISSION_GRANTED) {
mNumPermissionsToRequest++;
mShouldRequestLocationPermission = true;
@@ -119,7 +119,7 @@ public class PermissionsActivity extends Activity {
}
if (mShouldRequestLocationPermission) {
permissionsToRequest[permissionsRequestIndex] =
- Manifest.permission.ACCESS_COARSE_LOCATION;
+ Manifest.permission.ACCESS_FINE_LOCATION;
mIndexPermissionRequestLocation = permissionsRequestIndex;
}
requestPermissions(permissionsToRequest, PERMISSION_REQUEST_CODE);
diff --git a/src/com/android/camera/PhotoModule.java b/src/com/android/camera/PhotoModule.java
index e1cf6ba76..97b57c27e 100644
--- a/src/com/android/camera/PhotoModule.java
+++ b/src/com/android/camera/PhotoModule.java
@@ -649,7 +649,7 @@ public class PhotoModule
// camera only
private void locationFirstRun() {
boolean enableRecordingLocation = false;
- if (mActivity.checkSelfPermission(Manifest.permission.ACCESS_COARSE_LOCATION)
+ if (mActivity.checkSelfPermission(Manifest.permission.ACCESS_FINE_LOCATION)
== PackageManager.PERMISSION_GRANTED) {
enableRecordingLocation = true;
}