summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEmilian Peev <epeevs@codeaurora.org>2015-06-03 16:34:59 +0300
committerBruno Martins <bgcngm@gmail.com>2018-11-20 12:32:17 +0000
commit47d271752d54d16195606b78925dde7cbe66b5c9 (patch)
tree161dc40463325245e964ff41fc34d10da450871e
parent859fac2ee97e63cf6a51a112e7eed7045887de0e (diff)
downloadandroid_packages_apps_Snap-47d271752d54d16195606b78925dde7cbe66b5c9.tar.gz
android_packages_apps_Snap-47d271752d54d16195606b78925dde7cbe66b5c9.tar.bz2
android_packages_apps_Snap-47d271752d54d16195606b78925dde7cbe66b5c9.zip
Snapdragon Camera: Use consistent API for preview fps reset
Instead of using preview fps range API during preview framerate reset use the fixed fps API. This is to avoid any inconsistent behavior that can be triggered when using both APIs from MediaRecorder and Snapdragon application side. Change-Id: Ib5251d8ea4d697db9bdea4e5ebf20606b286f54f
-rw-r--r--src/com/android/camera/VideoModule.java8
-rwxr-xr-xsrc/com/android/camera/util/CameraUtil.java9
2 files changed, 12 insertions, 5 deletions
diff --git a/src/com/android/camera/VideoModule.java b/src/com/android/camera/VideoModule.java
index b6f1531af..1968ca870 100644
--- a/src/com/android/camera/VideoModule.java
+++ b/src/com/android/camera/VideoModule.java
@@ -2261,11 +2261,9 @@ public class VideoModule implements CameraModule,
startPreview();
} else {
if (is4KEnabled()) {
- int[] fpsRange = CameraUtil.getMaxPreviewFpsRange(mParameters);
- if (fpsRange.length > 0) {
- mParameters.setPreviewFpsRange(
- fpsRange[Parameters.PREVIEW_FPS_MIN_INDEX],
- fpsRange[Parameters.PREVIEW_FPS_MAX_INDEX]);
+ int fps = CameraUtil.getMaxPreviewFps(mParameters);
+ if (fps > 0) {
+ mParameters.setPreviewFrameRate(fps);
} else {
mParameters.setPreviewFrameRate(30);
}
diff --git a/src/com/android/camera/util/CameraUtil.java b/src/com/android/camera/util/CameraUtil.java
index 1813b11a7..490087537 100755
--- a/src/com/android/camera/util/CameraUtil.java
+++ b/src/com/android/camera/util/CameraUtil.java
@@ -1226,6 +1226,15 @@ public class CameraUtil {
return new int[0];
}
+ public static int getMaxPreviewFps(Parameters params) {
+ List<Integer> frameRates = params.getSupportedPreviewFrameRates();
+ if (frameRates != null && frameRates.size() > 0) {
+ // The list is sorted. Return the last element.
+ return frameRates.get(frameRates.size() - 1).intValue();
+ }
+ return -1;
+ }
+
private static class ImageFileNamer {
private final SimpleDateFormat mFormat;