diff options
author | Michael Bestas <mikeioannina@gmail.com> | 2014-10-24 11:26:25 +0300 |
---|---|---|
committer | Steve Kondik <steve@cyngn.com> | 2016-11-02 12:22:26 -0700 |
commit | 22ca2c39e37e0efd2a20417e25c3e0495ac5432e (patch) | |
tree | b3095e468450f26b70c665bc75f48ab753dc34b7 | |
parent | 482ad154c89278b963e5eb6c537347129ef6af8b (diff) | |
download | android_packages_apps_Snap-22ca2c39e37e0efd2a20417e25c3e0495ac5432e.tar.gz android_packages_apps_Snap-22ca2c39e37e0efd2a20417e25c3e0495ac5432e.tar.bz2 android_packages_apps_Snap-22ca2c39e37e0efd2a20417e25c3e0495ac5432e.zip |
Camera2: Remove CAF video duration code
Change-Id: I583e212f3c43a5ddf80fdb16557b3ddd9e3161c2
-rw-r--r-- | res/values/camera2arrays.xml | 15 | ||||
-rw-r--r-- | res/values/qcomarrays.xml | 16 | ||||
-rw-r--r-- | res/values/qcomstrings.xml | 9 | ||||
-rw-r--r-- | res/xml/video_preferences.xml | 7 | ||||
-rw-r--r-- | src/com/android/camera/CameraSettings.java | 20 | ||||
-rw-r--r-- | src/com/android/camera/CaptureModule.java | 4 | ||||
-rw-r--r-- | src/com/android/camera/VideoMenu.java | 2 | ||||
-rw-r--r-- | src/com/android/camera/VideoModule.java | 21 |
8 files changed, 5 insertions, 89 deletions
diff --git a/res/values/camera2arrays.xml b/res/values/camera2arrays.xml index 1f590fc32..063ea292d 100644 --- a/res/values/camera2arrays.xml +++ b/res/values/camera2arrays.xml @@ -623,21 +623,6 @@ <item>176x144</item> </string-array> - <string-array name="pref_camera2_video_duration_entries" translatable="false"> - <item>@string/pref_camera_video_duration_entry_mms</item> - <item>@string/pref_camera_video_duration_entry_10</item> - <item>@string/pref_camera_video_duration_entry_30</item> - <item>@string/pref_camera_video_duration_entry_nolimit</item> - </string-array> - - <!-- The numbers are in minutes, except -1 means the duration suitable for mms. --> - <string-array name="pref_camera2_video_duration_entryvalues" translatable="false"> - <item>-1</item> - <item>10</item> - <item>30</item> - <item>0</item> - </string-array> - <string-array name="pref_camera2_videoencoder_entries" translatable="false"> <item>@string/pref_camera_videoencoder_entry_0</item> <item>@string/pref_camera_videoencoder_entry_1</item> diff --git a/res/values/qcomarrays.xml b/res/values/qcomarrays.xml index 57005ba08..1f8ef09d0 100644 --- a/res/values/qcomarrays.xml +++ b/res/values/qcomarrays.xml @@ -563,22 +563,6 @@ <item>aac</item> </string-array> - <!-- Camera Preferences Video Duration dialog box entries --> - <string-array name="pref_camera_video_duration_entries" translatable="false"> - <item>@string/pref_camera_video_duration_entry_mms</item> - <item>@string/pref_camera_video_duration_entry_10</item> - <item>@string/pref_camera_video_duration_entry_30</item> - <item>@string/pref_camera_video_duration_entry_nolimit</item> - </string-array> - - <!-- The numbers are in minutes, except -1 means the duration suitable for mms. --> - <string-array name="pref_camera_video_duration_entryvalues" translatable="false"> - <item>-1</item> - <item>10</item> - <item>30</item> - <item>0</item> - </string-array> - <!-- Camera Preferences Skin Tone Enhancement dialog box entries --> <string-array name="pref_camera_skinToneEnhancement_entries"> <item>@string/pref_camera_skinToneEnhancement_entry_enable</item> diff --git a/res/values/qcomstrings.xml b/res/values/qcomstrings.xml index 6a58be524..00048b0e9 100644 --- a/res/values/qcomstrings.xml +++ b/res/values/qcomstrings.xml @@ -84,15 +84,6 @@ <!-- Default video duration setting. A numerical value.--> <string name="pref_camera_video_duration_default" translatable="false">10</string> - <!-- Settings screen, Video duration title --> - <string name="pref_camera_video_duration_title">Video duration</string> - - <!-- Settings screen, Video duration dialog radio button choices --> - <string name="pref_camera_video_duration_entry_mms">30 seconds(MMS)</string> - <string name="pref_camera_video_duration_entry_10">10 minutes</string> - <string name="pref_camera_video_duration_entry_30">30 minutes</string> - <string name="pref_camera_video_duration_entry_nolimit">no limit</string> - <!-- Default Skin Tone Enhancement setting. Do not translate. --> <string name="pref_camera_skinToneEnhancement_default">disable</string> diff --git a/res/xml/video_preferences.xml b/res/xml/video_preferences.xml index 2d9e2fbc8..0c239d14c 100644 --- a/res/xml/video_preferences.xml +++ b/res/xml/video_preferences.xml @@ -48,13 +48,6 @@ camera:entries="@array/pref_camera_video_tnr_entries" camera:entryValues="@array/pref_camera_video_tnr_entryvalues" /> <IconListPreference - camera:key="pref_camera_video_duration_key" - camera:defaultValue="@string/pref_camera_video_duration_default" - camera:title="@string/pref_camera_video_duration_title" - camera:singleIcon="@drawable/ic_settings_duration" - camera:entries="@array/pref_camera_video_duration_entries" - camera:entryValues="@array/pref_camera_video_duration_entryvalues" /> - <IconListPreference camera:key="pref_video_time_lapse_frame_interval_key" camera:defaultValue="@string/pref_video_time_lapse_frame_interval_default" camera:title="@string/pref_video_time_lapse_frame_interval_title" diff --git a/src/com/android/camera/CameraSettings.java b/src/com/android/camera/CameraSettings.java index 7ce556f78..11a69cbf8 100644 --- a/src/com/android/camera/CameraSettings.java +++ b/src/com/android/camera/CameraSettings.java @@ -79,7 +79,6 @@ public class CameraSettings { public static final String KEY_VIDEO_ENCODER = "pref_camera_videoencoder_key"; public static final String KEY_AUDIO_ENCODER = "pref_camera_audioencoder_key"; - public static final String KEY_VIDEO_DURATION = "pref_camera_video_duration_key"; public static final String KEY_POWER_MODE = "pref_camera_powermode_key"; public static final String KEY_PICTURE_FORMAT = "pref_camera_pictureformat_key"; public static final String KEY_ZSL = "pref_camera_zsl_key"; @@ -192,10 +191,6 @@ public class CameraSettings { private static final String KEY_QC_PICTURE_FORMAT = "picture-format-values"; public static final String KEY_VIDEO_ROTATION = "pref_camera_video_rotation_key"; - private static final String VIDEO_QUALITY_HIGH = "high"; - private static final String VIDEO_QUALITY_MMS = "mms"; - private static final String VIDEO_QUALITY_YOUTUBE = "youtube"; - //manual 3A keys and parameter strings public static final String KEY_MANUAL_EXPOSURE = "pref_camera_manual_exp_key"; @@ -262,11 +257,6 @@ public class CameraSettings { public static final int CURRENT_VERSION = 5; public static final int CURRENT_LOCAL_VERSION = 2; - public static final int DEFAULT_VIDEO_DURATION = 0; // no limit - private static final int MMS_VIDEO_DURATION = (CamcorderProfile.get(CamcorderProfile.QUALITY_LOW) != null) ? - CamcorderProfile.get(CamcorderProfile.QUALITY_LOW).duration :30; - private static final int YOUTUBE_VIDEO_DURATION = 15 * 60; // 15 mins - private static final String TAG = "CameraSettings"; private final Context mContext; @@ -1162,7 +1152,6 @@ public class CameraSettings { // Just use video quality to replace it and // ignore the current settings. editor.remove("pref_camera_videoquality_key"); - editor.remove("pref_camera_video_duration_key"); } editor.putInt(KEY_VERSION, CURRENT_VERSION); @@ -1340,7 +1329,6 @@ public class CameraSettings { supported.add(Integer.toString(CamcorderProfile.QUALITY_QCIF)); } } - } public static ArrayList<String> getSupportedVideoQualities(int cameraId,Parameters parameters) { @@ -1356,14 +1344,6 @@ public class CameraSettings { } return supported; } - public static int getVideoDurationInMillis(String quality) { - if (VIDEO_QUALITY_MMS.equals(quality)) { - return MMS_VIDEO_DURATION * 1000; - } else if (VIDEO_QUALITY_YOUTUBE.equals(quality)) { - return YOUTUBE_VIDEO_DURATION * 1000; - } - return DEFAULT_VIDEO_DURATION * 1000; - } public static boolean isInternalPreviewSupported(Parameters params) { boolean ret = false; diff --git a/src/com/android/camera/CaptureModule.java b/src/com/android/camera/CaptureModule.java index 45b47e2d1..6bd333e1e 100644 --- a/src/com/android/camera/CaptureModule.java +++ b/src/com/android/camera/CaptureModule.java @@ -2303,6 +2303,10 @@ public class CaptureModule implements CameraModule, PhotoController, private void updateMaxVideoDuration() { String minutesStr = mSettingsManager.getValue(SettingsManager.KEY_VIDEO_DURATION); + if (minutesStr == null) { + mMaxVideoDurationInMs = 0; + return; + } int minutes = Integer.parseInt(minutesStr); if (minutes == -1) { // User wants lowest, set 30s */ diff --git a/src/com/android/camera/VideoMenu.java b/src/com/android/camera/VideoMenu.java index a482a919d..a10045ba0 100644 --- a/src/com/android/camera/VideoMenu.java +++ b/src/com/android/camera/VideoMenu.java @@ -112,7 +112,6 @@ public class VideoMenu extends MenuController mOtherKeys1 = new String[] { CameraSettings.KEY_VIDEOCAMERA_FLASH_MODE, CameraSettings.KEY_VIDEO_QUALITY, - CameraSettings.KEY_VIDEO_DURATION, CameraSettings.KEY_RECORD_LOCATION, CameraSettings.KEY_CAMERA_SAVEPATH, CameraSettings.KEY_WHITE_BALANCE, @@ -122,7 +121,6 @@ public class VideoMenu extends MenuController mOtherKeys2 = new String[] { CameraSettings.KEY_VIDEOCAMERA_FLASH_MODE, CameraSettings.KEY_VIDEO_QUALITY, - CameraSettings.KEY_VIDEO_DURATION, CameraSettings.KEY_RECORD_LOCATION, CameraSettings.KEY_CAMERA_SAVEPATH, CameraSettings.KEY_WHITE_BALANCE, diff --git a/src/com/android/camera/VideoModule.java b/src/com/android/camera/VideoModule.java index 63d863d1f..888d29572 100644 --- a/src/com/android/camera/VideoModule.java +++ b/src/com/android/camera/VideoModule.java @@ -826,25 +826,6 @@ public class VideoModule implements CameraModule, Log.v(TAG, "Audio Encoder selected = " +mAudioEncoder); - String minutesStr = mPreferences.getString( - CameraSettings.KEY_VIDEO_DURATION, - mActivity.getString(R.string.pref_camera_video_duration_default)); - int minutes = -1; - try { - minutes = Integer.parseInt(minutesStr); - } catch(NumberFormatException npe) { - // use default value continue - minutes = Integer.parseInt(mActivity.getString( - R.string.pref_camera_video_duration_default)); - } - if (minutes == -1) { - // User wants lowest, set 30s */ - mMaxVideoDurationInMs = 30000; - } else { - // 1 minute = 60000ms - mMaxVideoDurationInMs = 60000 * minutes; - } - if(mParameters.isPowerModeSupported()) { String powermode = mPreferences.getString( CameraSettings.KEY_POWER_MODE, @@ -863,7 +844,7 @@ public class VideoModule implements CameraModule, mActivity.getString(R.string.pref_camera_denoise_default)); mParameters.setDenoise(denoise); } - } + } private void readVideoPreferences() { // The preference stores values from ListPreference and is thus string type for all values. |