summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* DO NOT MERGE Reworked additional permissions fragment for each appKeyvan Amiri2016-11-241-30/+45
|\ | | | | | | | | | | am: 6dfb1f6553 Change-Id: I78ed7c841680ed3d82835bca2394384311e6d8b1
| * DO NOT MERGE Reworked additional permissions fragment for each appKeyvan Amiri2016-11-231-30/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixed packageinstaller crash when selecting additional permissions for an app e.g. "Live Channels". setHeader should not be called in onCreate since it will update title UI which is initialized in onCreateView in SettingsWithHeader.java. Also, updated the UI for AdditionalPermissionsFragment for each individual app to include the app banner and title in the heading. Change-Id: Idfc12a28b38b84fcc5d97de4f85ada968e122d40 Fixes: 32338150 Test: Visual inspection of the permission UI (cherry picked from commit c6d15a867dbbf9cb730e409a7b7426baeb64ac9f)
| * Hide toast windows when permissions UI shownSvetoslav Ganov2016-07-201-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | When the permissions UI is showing we are hiding the system alrert windows that can overlay it in an attempt to redress the UI. It is however, also possible to use a toast window to overlay the permissions UI. This change makes sure we hide the toasts in addition to system alert windows when the permissions UI is showing. bug:30087538 Change-Id: Ifb9ecf4593ca24b628212f0737d574a537f0cccd (cherry picked from commit cc5e0323e83d6124f45ca75f55bc58793b550035)
* | Requested unused permissions reported as granted for app using none.Svet Ganov2016-08-111-0/+2
| | | | | | | | | | | | | | | | | | | | | | If the app uses no permissions and requested a runtime permission, the latter is reported granted while it is correctly not granted. Now we initialize everything as denied in case we exit eraly as the app does not use any permissions. bug:30747277 Change-Id: I08dbf086e7c3d5f66b6831c54910fbb4f0943388
* | Prevent "dont't ask again" being inpropoerly propagatedSvet Ganov2016-08-041-1/+1
| | | | | | | | | | | | | | | | | | | | | | If the first permission of a several permission request is denied with prejudice the rest of the denied permissions in the sequence are also incorrectly denied with prejudice even if the user didn't select "don't ask again". bug:30653785 Change-Id: Ib942dd3c692d1c3a09dc1a64f2947ded0f193923
* | Remove lefover secure buttonSvetoslav Ganov2016-07-181-56/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | An incorrect fix for a security bug where apps with overlay access can redress the permission message added a secure button implementation that refuses interaction if the window is covered. While this was fixed in M branches we did not merge the change in NYC because we now hide all overlays. However, the app op which controls overlays allows privileged apps to bypass the app op. It is fine to have priv apps overlay stuff on top of the permissions UI except that the allow button show be clickable. This change removes the offending code. bug:29879858 Change-Id: I9d0b5e62b5ef029069e37f34dbcd90d4909d966b
* | Merge "Trigger transparency dialog only if restriction is set by admin." ↵TreeHugger Robot2016-07-141-5/+11
|\ \ | | | | | | | | | into nyc-mr1-dev
| * | Trigger transparency dialog only if restriction is set by admin.Sudheer Shanka2016-07-121-5/+11
| | | | | | | | | | | | | | | Bug: 30104199 Change-Id: I97a16938c36b4dadc9167652f6297acf829366e9
* | | Hide toast windows when permissions UI shownSvetoslav Ganov2016-07-131-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the permissions UI is showing we are hiding the system alrert windows that can overlay it in an attempt to redress the UI. It is however, also possible to use a toast window to overlay the permissions UI. This change makes sure we hide the toasts in addition to system alert windows when the permissions UI is showing. bug:30087538 Change-Id: Ifb9ecf4593ca24b628212f0737d574a537f0cccd
* | | Read and apply 'installLocation'Philip P. Moltmann2016-07-111-0/+8
|/ / | | | | | | | | | | | | | | | | | | ... when installing app via packageInstaller. This allows the apk to have some limited control over where it will be installed. Change-Id: Id5140e7d2a2e3b8dd59815a0febf5c05cee08fbf Fixes: 30056625
* | Do not allow downgrades of embedded microappsVinod Krishnan2016-07-062-4/+20
| | | | | | | | | | | | | | | | - flag is passed in from https://critique.corp.google.com/#review/126666577 Bug: 29641183 Change-Id: I1becbb446d824331430eb37d99bdbc7a36dd13db
* | Don't offer menu items it they are no-opSvet Ganov2016-06-292-13/+37
| | | | | | | | | | | | | | | | | | | | | | In the permission apps screen we have a menu item to show/hide system apps. It is possible that no system app uses the permission making the menu item do nothing. We don't add the menu item if no system app uses the permission. bug:29395895 Change-Id: I1756981b2f711fc7a886bd4227196fef1a3cea03
* | Only log (not crash) when activity is not found.Philip P. Moltmann2016-06-171-1/+6
|\| | | | | | | | | | | am: 87ec609c14 Change-Id: I07c7e57630269d9d37d8e10dfa49e59e88cec022
| * Only log (not crash) when activity is not found.Philip P. Moltmann2016-06-161-1/+6
| | | | | | | | | | Fixes: 29260288 Change-Id: Iaa309f362ae6a296f7ba365e418d4a6f55b23f0c
* | Merge \"Hide Status and Navigation Bar when uninstalling\" into nyc-devPhilip P. Moltmann2016-06-101-0/+8
|\| | | | | | | | | | | am: 9c177f8d28 Change-Id: Ieac52df39c5481ea8c964be61d3a5a5c9bc024e3
| * Merge "Hide Status and Navigation Bar when uninstalling" into nyc-devPhilip P. Moltmann2016-06-101-0/+8
| |\
| | * Hide Status and Navigation Bar when uninstallingPhilip P. Moltmann2016-06-021-0/+8
| | | | | | | | | | | | | | | | | | | | | ... at least unless we want to show a progress dialog. Fixes: 29094372 Change-Id: I45e0bbf32355a93635c773c526151b849bc1e8a3
* | | Fix a crash in package installerSvet Ganov2016-06-092-2/+1
|\| | | | | | | | | | | | | | | | | am: 869786e3e4 Change-Id: Ic1d8d6221194731a6c967f736a1352a905bba8b0
| * | Fix a crash in package installerSvet Ganov2016-06-082-2/+1
| |/ | | | | | | | | | | | | | | | | | | | | | | The first bug was that we were starting the install before having the package info for the installed app. The second was that we were calling the permission review UI despite we were there before the user selected to install. i.e. the user already reviewed the permissions. bug:29197887 Change-Id: I2fac4d014dde7f7744a6b831c2b0ff510e29e8e8
* | Merge "Show installer UI for user to confirm side-loading" into nyc-devSvetoslav Ganov2016-06-011-7/+1
|\| | | | | | | | | | | | | | | | | am: 6622140841 * commit '662214084178a687a32823decd4f42ba82313def': Show installer UI for user to confirm side-loading Change-Id: I017268c1d12c5fdfaea099e9428c3def1b728bdd
| * Show installer UI for user to confirm side-loadingSvetoslav Ganov2016-06-011-7/+1
| | | | | | | | | | | | | | | | | | This change fixes a regression where we stopped showing a confirmation UI for an app side-loading. bug:28551937 Change-Id: Ia2114d273473d6e00696f9de8c523190a1b444ad
* | Merge "Format the template using HTML tags." into nyc-devPhilip P. Moltmann2016-05-251-11/+4
|\| | | | | | | | | | | | | | | | | am: e071d11592 * commit 'e071d1159277a00e0484dbf43899bc90ea27176c': Format the template using HTML tags. Change-Id: I1858bc3c1e6d6fb5f4b37a2ef4a287de635045ae
| * Format the template using HTML tags.Philip P. Moltmann2016-05-231-11/+4
| | | | | | | | | | | | | | Manual formatting is to complicated to do. Fixes: 28852429 Change-Id: Ibab723b82a2b14ad94a3038dffccc96f86ba8ee4
* | Finish package installer activity on a cancel resultSvetoslav Ganov2016-05-181-0/+3
|\| | | | | | | | | | | | | | | | | am: 6fdd93b339 * commit '6fdd93b33927675a6a062f0b8fd00ef3866ac2f7': Finish package installer activity on a cancel result Change-Id: If34ab52b7c25cdbf69a06db5b4cf7e87b62e12bd
| * Finish package installer activity on a cancel resultSvetoslav Ganov2016-05-181-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | We made a change to the PackageInstaller to start settings for a result to allow partners to return OK to continue the install flow, otherwise requiring the user to start install again (the desired behavior on Nexus). This change finishes the package installer activity if settings does not return success to continue the install flow. bug:28838075 Change-Id: I4ff1b1a713d46a8584baf66f379ab070226c125f
* | Merge "Add missing else statement" into nyc-devSvet Ganov2016-05-181-2/+2
|\| | | | | | | | | | | | | | | | | am: 622c5b563e * commit '622c5b563e1f2e7a78e64129f350387613161153': Add missing else statement Change-Id: I0e6e13bf0bbd368375bd924c496d1b8e011cbf19
| * Merge "Add missing else statement" into nyc-devSvetoslav Ganov2016-05-181-2/+2
| |\
| | * Add missing else statementSvet Ganov2016-05-181-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | This change fixes a regression where we endup installing apps even if unknown sources is disabled - missing else statement. bug:28551937 Change-Id: I05dd28a28eb9ffd9eda8a6ee2fdccd501d2e08d1
* | | Merge "Take advantage of new MotionEvent flag to prevent tapjacking." into ↵Michael Wright2016-05-161-0/+56
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | nyc-dev am: 1be5a77aaa * commit '1be5a77aaa3bfba81063cbba38422dfe30c4ce40': Take advantage of new MotionEvent flag to prevent tapjacking. Change-Id: I416339e7bb12371480432699499871cf3c43bcab
| * | Merge "Take advantage of new MotionEvent flag to prevent tapjacking." into ↵TreeHugger Robot2016-05-161-0/+56
| |\ \ | | | | | | | | | | | | nyc-dev
| | * | Take advantage of new MotionEvent flag to prevent tapjacking.Michael Wright2016-03-311-0/+56
| | | | | | | | | | | | | | | | | | | | Bug: 26677796 Change-Id: I563541f0a42564b854af0f8037c1d4741c79a2ac
* | | | Merge "Ensure app label properly bolded" into nyc-devSvetoslav Ganov2016-05-141-2/+2
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | am: 55dbb25ae3 * commit '55dbb25ae341353ef10312d89a248d4e658be9ee': Ensure app label properly bolded Change-Id: If437d0944f8dc45107d67252ccf1f17e8c748ca3
| * | | Merge "Ensure app label properly bolded" into nyc-devSvetoslav Ganov2016-05-141-2/+2
| |\ \ \
| | * | | Ensure app label properly boldedSvetoslav Ganov2016-05-131-2/+2
| | | |/ | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change ensures the app name is properly bolded in the premissions request UI even if it is a substring of "Allow" :) bug:28719607 Change-Id: I5a313f67c19a2d882732b1c97f0dbee5782b22f5
* | | | Merge "Use badged icons for permissions." into nyc-devPhilip P. Moltmann2016-05-131-10/+12
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | am: 988f3bcb21 * commit '988f3bcb21b7026cfab89d22ef912f98c9c9f8a2': Use badged icons for permissions. Change-Id: I922e3df467d31be00c80128c91330b381853ce70
| * | | Merge "Use badged icons for permissions." into nyc-devPhilip P. Moltmann2016-05-131-10/+12
| |\ \ \
| | * | | Use badged icons for permissions.Philip P. Moltmann2016-05-111-10/+12
| | |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | Please note that the labels stay unbadged. I.e. The label will always be "Contacts" instead of "Work Contacts". Fixes: 28403737 Change-Id: Ib994db946b07098a8c0f95eab5787fb30532fe62
* | | | Merge "Finish whole installation on cancel dialog." into nyc-devPhilip P. Moltmann2016-05-131-1/+1
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | am: f682d8970c * commit 'f682d8970cc10e9943232cde1888d214637e610e': Finish whole installation on cancel dialog. Change-Id: I785f39748871178c428330c70428d2a8b4979f78
| * | | Merge "Finish whole installation on cancel dialog." into nyc-devPhilip P. Moltmann2016-05-131-1/+1
| |\ \ \
| | * | | Finish whole installation on cancel dialog.Philip P. Moltmann2016-05-111-1/+1
| | |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the user does not want to enable "unknown sources" and clicks "cancel" the whole installation should finish. Fixes: 28683865 Change-Id: I2582141ea777e5b2e14dd690b3c3fb8039cff2d4
* | | | Merge "Fine tune UI of package installer." into nyc-devPhilip P. Moltmann2016-05-121-1/+3
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | am: 51b7ac8dc1 * commit '51b7ac8dc1b2e6ccb2d3af2f1c1d84b529977e3a': Fine tune UI of package installer. Change-Id: I0b2407e42d74ac3c15b3926f202b327de5561c9a
| * | | Merge "Fine tune UI of package installer." into nyc-devPhilip P. Moltmann2016-05-121-1/+3
| |\ \ \
| | * | | Fine tune UI of package installer.Philip P. Moltmann2016-05-121-1/+3
| | |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes two screens in the case no permissions are required. - Do not remove tabs, just make them invisible. This is required to push the "OK" and "CANCEL" button to the bottom - Show spacer under text as this looks prettier. Fixes: 28746145 Change-Id: Ia312b476c7e3944709ed3f8fd71d12268559257f
* | | | Fix app install flowSvetoslav Ganov2016-05-122-9/+25
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | am: f63739bb3f * commit 'f63739bb3f5de9927171b84630ec5872ba85fa6c': Fix app install flow Change-Id: I37bdfd9f7e005d57eb90e46f87f4cabcfaa6519c
| * | | Fix app install flowSvetoslav Ganov2016-05-102-9/+25
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A regression was introduced when we added support for installing apps from content URIs. Since we stage the APK in the cache folder we changed the flow to wipe the cached version when the PackageInstallerActivity finishes or gets an installation result, so we started the InstallAppProgress activity for result but the latter may be called with the forward result flag which is incompatible with start activity for result. This change delegates clearing the staging file in the cache folder to the InstallAppProgress activity. bug:28551937 Change-Id: I0d9978aff60b7fab6b64fe7bf889ef30f9b2fd7c
* / / Update Wearable install logic to use stream APIAnthony Hugh2016-05-095-32/+624
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The default directory for PackageInstaller moved from /data/user/foo to /data/user_de/foo. Not sure on the exact reason why, but it has something to do with the file based encryption changes in N. This was causing the temp APK file that we were passing to PackageManager for installs to be in an invalid location. This resulted in failed installations. This is OK though because we never really wanted to use a temporary file. We were using it due to limitations in the PackageInstaller APIs. Since implementation, new APIs have been added to allow us to pass a stream through instead. This CL updates the install logic to use the stream API instead. Because this code path is being deprecated and replaced, I've opted to do the bare minimum needed to keep this code operational. I've also borrowed installation code from Wearsky/Finsky codebase to make it easier and more reliable. BUG: 28021618 Change-Id: Ia245abf56649e350e99cf48d2b503906d3cd855c
* | Mend up onDestroy->onCreate for N.Philip P. Moltmann2016-05-051-1/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This does not implement correct onDestroy->onCreate behavior but mends it for the common case. We now handle all configurations changes, hence onDestroy->onCreate is very rare. We also just abort quickly if we actually had a onDestroy->onCreate instead of crashing. This is a temporary fix. Bug: 28588511 Change-Id: Ief56c8b866f2561b13253f66a7f79517fc2132cb
* | Merge "Revert "Grant only the requested permissions"" into nyc-devSvetoslav Ganov2016-05-032-59/+9
|\ \
| * | Revert "Grant only the requested permissions"Svetoslav Ganov2016-05-032-59/+9
| | | | | | | | | | | | | | | | | | This reverts commit 294b6406798c59e9db5ffa99d042f9b8c6ca6f90. Change-Id: Ifb48eb1fbdb0499743f4ca88adbd5ed77cfa4cf8
* | | Merge "Grant only the requested permissions" into nyc-devSvetoslav Ganov2016-04-292-9/+59
|\| |