summaryrefslogtreecommitdiffstats
path: root/src/com/android/packageinstaller/permission/ui
Commit message (Collapse)AuthorAgeFilesLines
* Format the template using HTML tags.Philip P. Moltmann2016-05-231-11/+4
| | | | | | | Manual formatting is to complicated to do. Fixes: 28852429 Change-Id: Ibab723b82a2b14ad94a3038dffccc96f86ba8ee4
* Merge "Take advantage of new MotionEvent flag to prevent tapjacking." into ↵TreeHugger Robot2016-05-161-0/+56
|\ | | | | | | nyc-dev
| * Take advantage of new MotionEvent flag to prevent tapjacking.Michael Wright2016-03-311-0/+56
| | | | | | | | | | Bug: 26677796 Change-Id: I563541f0a42564b854af0f8037c1d4741c79a2ac
* | Ensure app label properly boldedSvetoslav Ganov2016-05-131-2/+2
| | | | | | | | | | | | | | | | | | | | This change ensures the app name is properly bolded in the premissions request UI even if it is a substring of "Allow" :) bug:28719607 Change-Id: I5a313f67c19a2d882732b1c97f0dbee5782b22f5
* | Merge "Revert "Grant only the requested permissions"" into nyc-devSvetoslav Ganov2016-05-031-41/+9
|\ \
| * | Revert "Grant only the requested permissions"Svetoslav Ganov2016-05-031-41/+9
| | | | | | | | | | | | | | | | | | This reverts commit 294b6406798c59e9db5ffa99d042f9b8c6ca6f90. Change-Id: Ifb48eb1fbdb0499743f4ca88adbd5ed77cfa4cf8
* | | Merge "Grant only the requested permissions" into nyc-devSvetoslav Ganov2016-04-291-9/+41
|\| |
| * | Grant only the requested permissionsSvet Ganov2016-04-271-9/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If an app requests a permission in a group we were auto granting it all permissions from the group declared as used by the app. The intended behavior is that we grant only the requested permission and requesting a permission from a group where a permission is already granted results in an auto-grant. The intended behavior was to prevent coding around permission groups which a volatile by design. Now if apps target SDK above M we provide the intended behavior, otherwise for apps targeting M we provide an unchenged behavior. bug:28347872 Change-Id: I493714b2c2581340b01b12ce6fedf80f9d3deec5
* | | Only platform defined permissions need a review.Svet Ganov2016-04-291-2/+2
|/ / | | | | | | | | | | | | | | | | | | | | The only permissions a user can control for a legacy app in runtime style without crashing the app are the ones defined by the platform because we have app ops only for these and also we contorl the access to data guarded by them. bug:27102458 Change-Id: I63d02e169dc82e9f3638b8e8f99ed8d95ae7d325
* | Cleanup of the PackageInstaller API - PackageInstallerSvet Ganov2016-04-2112-35/+25
| | | | | | | | | | | | | | | | | | The PackageInstaller app manages side-loading apps as well as permission management. It should be updatable, hence should rely on system APIs to talk to the platform. This is the first step of defining an API boundary. Change-Id: I37aea1e5cc3195b8b636af6790af45fe5a9765cd
* | Reworked permission UI on TV into the new side-panel leanback styleKeyvan Amiri2016-04-149-160/+103
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Reworked all the permission UIs on TV to mesh with the rest of the settings rendered as leanback-styled side panels with title bars. The permissions consist of the following components: * Each individual app permission listing ** Listing of all the permissions together with the apps using those permissions Bug: 27344882 Bug: 22481180 Change-Id: I4ab05efd9a4ea6fab7971b89f13d65591a2be8ee
* | Merge "Adding help link to apps permissions page" into nyc-devSuprabh Shukla2016-04-082-0/+6
|\ \
| * | Adding help link to apps permissions pageSuprabh Shukla2016-04-072-0/+6
| |/ | | | | | | | | | | | | | | Added a menu item to link for the help center article for app permissions. Bug: b/22096093 Change-Id: Ic810bbcc64b20ab6ee21140f0bb3ea055c10813a
* / Refresh permissions UI on resumeSvet Ganov2016-04-072-0/+2
|/ | | | | | bug:21891813 Change-Id: Id9a694d14ecd80c8c04dc28b34cdda3e9119bfb3
* Merge "Update deny button in permission warning dialogs" into nyc-devSvetoslav Ganov2016-03-236-6/+6
|\
| * Update deny button in permission warning dialogsSvet Ganov2016-03-226-6/+6
| | | | | | | | | | | | bug:23899558 Change-Id: I37bf080d54fc4fff5dfcc9f8240b95c82fed56d2
* | Respect past user choices in permisson review UISvetoslav Ganov2016-03-231-13/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In a permission review mode we show UI for the user to review new permissions for apps that do not support the new runtime permission model. The review is shown on an app launch. It is possible for the user to modify permissions in the settings UI before launching an app. This change ensures that the default value in the review UI reflects the user choice in settings. Specifically, the review UI shows the permission toggle in a granted state if the user expressed no opinion or granted the pemrission in settings (initially permissions are shown as revoked in settings as a review is pending - granting a permission from settings doesn't void the pending review). However, if the user grants and then revokes a permission in settings, (expresses an opinion the pemrission should be revoked) the default state of the permission toggle is off. bug:26741436 Change-Id: I021175df00e334e73aa01363d2c5645e2fe16b90
* | Merge "Revert "Respect past user choices in permisson review UI"" into nyc-devSvetoslav Ganov2016-03-231-18/+5
|\ \
| * | Revert "Respect past user choices in permisson review UI"Svetoslav Ganov2016-03-231-18/+5
| | | | | | | | | | | | | | | | | | This reverts commit 437a6bfedb33daf66592bbed8595025f3e707850. Change-Id: I5a46f94aadb0ab6dcbe85761f3b1390749b8b1cf
* | | Merge "Respect past user choices in permisson review UI" into nyc-devSvetoslav Ganov2016-03-231-5/+18
|\| |
| * | Respect past user choices in permisson review UISvetoslav Ganov2016-03-231-5/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In a permission review mode we show UI for the user to review new permissions for apps that do not support the new runtime permission model. The review is shown on an app launch. It is possible for the user to modify permissions in the settings UI before launching an app. This change ensures that the default value in the review UI reflects the user choice in settings. Specifically, the review UI shows the permission toggle in a granted state if the user expressed no opinion or granted the pemrission in settings (initially permissions are shown as revoked in settings as a review is pending - granting a permission from settings doesn't void the pending review). However, if the user grants and then revokes a permission in settings, (expresses an opinion the pemrission should be revoked) the default state of the permission toggle is off. bug:26741436 Change-Id: Iae6ae497dfba46ba1399fbf66fb60e70c37f0420
* | | Merge "Don't show app defined permissions in the review UI" into nyc-devSvetoslav Ganov2016-03-221-6/+17
|\ \ \
| * | | Don't show app defined permissions in the review UISvetoslav Ganov2016-03-211-6/+17
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Only platform defined runtime permissions have corresponding app ops, hence there is no way to disable functionality guarded by app defined permissions. Therefore, app defined permissions should not show in the review UI. bug:27102458 Change-Id: Iedc7c4de9216007176b87cfecaeed69dbadc2068
* / / Show No permissions, if there are no permissionsVinod Krishnan2016-03-182-15/+24
|/ / | | | | | | Change-Id: I285e326994268fc5b561e4a445ac2af326a64397
* | Merge "Support app install from a content URI" into nyc-devSvetoslav Ganov2016-03-0613-18/+10
|\ \
| * | Support app install from a content URISvet Ganov2016-03-0513-18/+10
| |/ | | | | | | | | | | bug:24079113 Change-Id: Ide1aa1667370f6b8d00ff269ef28992589656e9a
* / Update restricted icon position in RestrictedSwitchPreference.Sudheer Shanka2016-03-022-6/+14
|/ | | | | | | | | And fixed a bug where the admin disabled summary is shown even if the admin has not set a permission policy. Bug: 25603665 Bug: 27263775 Change-Id: I8cbbc4c326669a656ad5aef53896b388d556a74f
* Merge "Expose removed permissions flag as system API - installer" into nyc-devSvetoslav Ganov2016-02-232-2/+2
|\
| * Expose removed permissions flag as system API - installerSvet Ganov2016-02-222-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are some permissions that were removed from the platform and guard nothing but legacy apps may be checking them before calling APIs. Hence, these apps should get the permissions as expected despite them being a no-op. To address this the platform declares removed permissions as normal permissions that are hidden such that legacy apps can always get them. These permissions are not shown in the UI. Play needs a way to filter out these permissions like the platform as they have permissions UI too. bug:23361760 Change-Id: Ieecf69f70551d987f5fac1f128b7f7a0c242c378
* | Merge "Show permissions grant UI in requested order" into nyc-devSvetoslav Ganov2016-02-231-6/+6
|\ \
| * | Show permissions grant UI in requested orderSvet Ganov2016-02-221-6/+6
| |/ | | | | | | | | | | bug:23314383 Change-Id: I4b41b9941f147eefc5f3fc2c520aba7afabd26a0
* | No overlay when permissions shown - package installerSvet Ganov2016-02-207-46/+17
| | | | | | | | | | | | bug:26973205 Change-Id: Ibae1b971ceb1ea0d831435b9d5166482199e9184
* | Fix a NPE in GrantPermissionsActivitySvet Ganov2016-02-201-5/+6
|/ | | | | | | | | We get an NPE if an app that delcates no permissions as used requests runtime permissions. bug:21011604 Change-Id: Id0cac6dcbd78ef849a1eafa522b8a06e61b21a1b
* Use the correct userId when checking if disabled by admin.Sudheer Shanka2016-02-012-8/+9
| | | | Change-Id: I0fbe8ac8670b9fa4eb1fa35693856b47fdc974a4
* Update the summary used when permission is fixed by admin.Sudheer Shanka2016-01-262-4/+7
| | | | Change-Id: I427fd1e1c99153484944ee9955ae79ee9e2c23ef
* Merge "Add a padlock to options when disabled by admin."Sudheer Shanka2016-01-213-8/+110
|\
| * Add a padlock to options when disabled by admin.Sudheer Shanka2016-01-203-8/+110
| | | | | | | | | | | | | | | | Currently, if admin has enforced setPermissionGrantState to denied or granted, we disable the option and add a summary that the option is disabled by admin. With this change, a padlock will also be added in this case. Change-Id: I58080c914fabab045282eb3cc491901676fffaed
| * Merge "Revert "Make request permissions dialog layout robost"" am: 41d260fe98Svetoslav Ganov2016-01-153-35/+6
| |\ | | | | | | | | | | | | | | | | | | am: eccff95e32 * commit 'eccff95e32dbf09f0fe6df033daf09e8d3c4212e': Revert "Make request permissions dialog layout robost"
* | \ resolve merge conflicts of 9199155a7f to master.Svetoslav Ganov2016-01-203-250/+130
|\ \ \ | |/ / |/| | | | | Change-Id: I325541269f5a0f7c1fde7a57042543e769bed218
| * | Make the permission request dialog's layout robustSvetoslav Ganov2016-01-213-243/+151
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The old implementation was relying on a fixed window size where the content is positioned by a custom layout manager. It is possible however that subsequent permissions requests do not fit in the window as its size is computed based on the content of the first permissions request. There were also cases where the content is chopped after a rotation as the dialog size width was not re-evaluated while it should be. Further, animation from one permission request state to another was not properly done resulting in content being chopped off in some cases. The current approach is to have a dialog width for the content activity but the height is as tall as the screen allowing us to fit arbitrary large permission request content. Also we are resetting the fixed width on a configuration change so the dialog is robust to adjust size as needed. bug:24679384 bug:25755378 Change-Id: I4d23f81d8e59ce23bf9a27155ebb5ec6e2e6752c (cherry picked from commit c6dc4bb52b07886346b02b326c5c32a8299ed73e)
| * Merge "Revert "Make request permissions dialog layout robost""Svetoslav Ganov2016-01-153-35/+6
| |\ | | | | | | | | | | | | | | | | | | am: 41d260fe98 * commit '41d260fe9854819ca04a3b5908e6ab889bf3ffc4': Revert "Make request permissions dialog layout robost"
| | * Revert "Make request permissions dialog layout robost"Brian Carlstrom2016-01-143-35/+6
| | | | | | | | | | | | This reverts commit ecaeae17f52d6562d23dfec91e44bc3c0b4a6d13.
* | | Merge "Make request permissions dialog layout robost" am: 816baf3566Svetoslav Ganov2016-01-153-6/+35
|\| | | | | | | | | | | | | | | | | | | | am: b0a98d2e47 * commit 'b0a98d2e4778e39b62b3731cbc27cf6fdb541e24': Make request permissions dialog layout robost
| * | Merge "Make request permissions dialog layout robost"Svetoslav Ganov2016-01-153-6/+35
| |\| | | | | | | | | | | | | | | | | | | am: 816baf3566 * commit '816baf35660c3c46ffcb9be7ec72d343fb0e1400': Make request permissions dialog layout robost
| | * Make request permissions dialog layout robostSvet Ganov2016-01-133-6/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the min width of a dialog changes in portrait vs landscape it was possible that a part of the request permissions dialog is chopped off. The custom content layout manager was using a fixed width and changing orientation may lead to a dialog width lesser than the fixed width of the layout manager. Another problem was that if the above occurs and the window width changes then the window may not be tall enough to fit the content. To address this we have to do a gross move and re-add the window to the window manager, so it can be resized. Another issue was that if the "Don't ask again" checkbox is shown not for the first but say the second permission request (in the case of multi-permission request in one API call) the content was chopped off as the height measurement for how much the content needs to be was restricted by the parent measure spec. Now we measure with no restrictions to accommodate the whole content. The way reqeust permissions dialog is implemented is problematic as it is a dialog styled activity which means we may need to resize its window. It is better to implement it as a fullscreen activity that has a custom content layout mangar that makes the content look like a dialog. Since this is risky at this point we do targeted fixes to address the above issues. bug:24679384 Change-Id: If51a360ba17dfb71b66dcf841ea47c17606eba27
* | | Legacy apps shouldn't be able to request permissionsSvetoslav2015-12-041-0/+11
| | | | | | | | | | | | | | | | | | bug:26032074 Change-Id: If6566411e08b3a27eecc2ca559c2b902dc8c1e65
* | | Add some things missing in the previous CL.Svet Ganov2015-12-012-0/+2
| | | | | | | | | | | | Change-Id: I17ae37d84c0d78bcfcaa848efb17f46c7f7c915a
* | | Add optional permission review for legacy apps - installerSvet Ganov2015-12-015-65/+632
| | | | | | | | | | | | Change-Id: Ifc88b2fa259d2d22bea6b5500cded2714ad4da85
* | | Fix build am: 0937012335Svetoslav2015-11-215-11/+11
|\| | | | | | | | | | | | | | | | | | | | am: 2a6f5d0fc6 * commit '2a6f5d0fc6b3fc65120ba7ed13f81af2d59eb11f': Fix build
| * | Fix buildSvetoslav2015-11-205-11/+11
| | | | | | | | | | | | Change-Id: I2a3e235bb13f1920c14f6776ee3a1ef7285ea548