| Commit message (Collapse) | Author | Age | Files | Lines |
|\ |
|
| |
| |
| |
| |
| |
| | |
bug:23899558
Change-Id: I37bf080d54fc4fff5dfcc9f8240b95c82fed56d2
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In a permission review mode we show UI for the user to review
new permissions for apps that do not support the new runtime
permission model. The review is shown on an app launch. It is
possible for the user to modify permissions in the settings
UI before launching an app.
This change ensures that the default value in the review UI
reflects the user choice in settings. Specifically, the review
UI shows the permission toggle in a granted state if the user
expressed no opinion or granted the pemrission in settings
(initially permissions are shown as revoked in settings as a
review is pending - granting a permission from settings doesn't
void the pending review). However, if the user grants and then
revokes a permission in settings, (expresses an opinion the
pemrission should be revoked) the default state of the
permission
toggle is off.
bug:26741436
Change-Id: I021175df00e334e73aa01363d2c5645e2fe16b90
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit 437a6bfedb33daf66592bbed8595025f3e707850.
Change-Id: I5a46f94aadb0ab6dcbe85761f3b1390749b8b1cf
|
|\| | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In a permission review mode we show UI for the user to review
new permissions for apps that do not support the new runtime
permission model. The review is shown on an app launch. It is
possible for the user to modify permissions in the settings
UI before launching an app.
This change ensures that the default value in the review UI
reflects the user choice in settings. Specifically, the review
UI shows the permission toggle in a granted state if the user
expressed no opinion or granted the pemrission in settings
(initially permissions are shown as revoked in settings as a
review is pending - granting a permission from settings doesn't
void the pending review). However, if the user grants and then
revokes a permission in settings, (expresses an opinion the
pemrission should be revoked) the default state of the permission
toggle is off.
bug:26741436
Change-Id: Iae6ae497dfba46ba1399fbf66fb60e70c37f0420
|
|\ \ \ |
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Only platform defined runtime permissions have corresponding
app ops, hence there is no way to disable functionality guarded
by app defined permissions. Therefore, app defined permissions
should not show in the review UI.
bug:27102458
Change-Id: Iedc7c4de9216007176b87cfecaeed69dbadc2068
|
|/ /
| |
| |
| | |
Change-Id: I285e326994268fc5b561e4a445ac2af326a64397
|
|\ \ |
|
| |/
| |
| |
| |
| |
| | |
bug:24079113
Change-Id: Ide1aa1667370f6b8d00ff269ef28992589656e9a
|
|/
|
|
|
|
|
|
|
| |
And fixed a bug where the admin disabled summary is shown even
if the admin has not set a permission policy.
Bug: 25603665
Bug: 27263775
Change-Id: I8cbbc4c326669a656ad5aef53896b388d556a74f
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
There are some permissions that were removed from the platform
and guard nothing but legacy apps may be checking them before
calling APIs. Hence, these apps should get the permissions as
expected despite them being a no-op. To address this the platform
declares removed permissions as normal permissions that are hidden
such that legacy apps can always get them. These permissions are
not shown in the UI. Play needs a way to filter out these
permissions like the platform as they have permissions UI too.
bug:23361760
Change-Id: Ieecf69f70551d987f5fac1f128b7f7a0c242c378
|
|\ \ |
|
| |/
| |
| |
| |
| |
| | |
bug:23314383
Change-Id: I4b41b9941f147eefc5f3fc2c520aba7afabd26a0
|
| |
| |
| |
| |
| |
| | |
bug:26973205
Change-Id: Ibae1b971ceb1ea0d831435b9d5166482199e9184
|
|/
|
|
|
|
|
|
|
| |
We get an NPE if an app that delcates no permissions as used
requests runtime permissions.
bug:21011604
Change-Id: Id0cac6dcbd78ef849a1eafa522b8a06e61b21a1b
|
|
|
|
| |
Change-Id: I0fbe8ac8670b9fa4eb1fa35693856b47fdc974a4
|
|
|
|
| |
Change-Id: I427fd1e1c99153484944ee9955ae79ee9e2c23ef
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Currently, if admin has enforced setPermissionGrantState to denied or granted,
we disable the option and add a summary that the option is disabled by
admin. With this change, a padlock will also be added in this case.
Change-Id: I58080c914fabab045282eb3cc491901676fffaed
|
| |\
| | |
| | |
| | |
| | |
| | |
| | | |
am: eccff95e32
* commit 'eccff95e32dbf09f0fe6df033daf09e8d3c4212e':
Revert "Make request permissions dialog layout robost"
|
|\ \ \
| |/ /
|/| |
| | | |
Change-Id: I325541269f5a0f7c1fde7a57042543e769bed218
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The old implementation was relying on a fixed window size
where the content is positioned by a custom layout manager.
It is possible however that subsequent permissions requests
do not fit in the window as its size is computed based on
the content of the first permissions request. There were
also cases where the content is chopped after a rotation
as the dialog size width was not re-evaluated while it should
be. Further, animation from one permission request state
to another was not properly done resulting in content
being chopped off in some cases.
The current approach is to have a dialog width for the
content activity but the height is as tall as the screen
allowing us to fit arbitrary large permission request
content. Also we are resetting the fixed width on a
configuration change so the dialog is robust to adjust
size as needed.
bug:24679384
bug:25755378
Change-Id: I4d23f81d8e59ce23bf9a27155ebb5ec6e2e6752c
(cherry picked from commit c6dc4bb52b07886346b02b326c5c32a8299ed73e)
|
| |\
| | |
| | |
| | |
| | |
| | |
| | | |
am: 41d260fe98
* commit '41d260fe9854819ca04a3b5908e6ab889bf3ffc4':
Revert "Make request permissions dialog layout robost"
|
| | |
| | |
| | |
| | | |
This reverts commit ecaeae17f52d6562d23dfec91e44bc3c0b4a6d13.
|
|\| |
| | |
| | |
| | |
| | |
| | |
| | | |
am: b0a98d2e47
* commit 'b0a98d2e4778e39b62b3731cbc27cf6fdb541e24':
Make request permissions dialog layout robost
|
| |\|
| | |
| | |
| | |
| | |
| | |
| | | |
am: 816baf3566
* commit '816baf35660c3c46ffcb9be7ec72d343fb0e1400':
Make request permissions dialog layout robost
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If the min width of a dialog changes in portrait vs landscape
it was possible that a part of the request permissions dialog
is chopped off. The custom content layout manager was using a
fixed width and changing orientation may lead to a dialog
width lesser than the fixed width of the layout manager.
Another problem was that if the above occurs and the window
width changes then the window may not be tall enough to fit
the content. To address this we have to do a gross move and
re-add the window to the window manager, so it can be resized.
Another issue was that if the "Don't ask again" checkbox is
shown not for the first but say the second permission request
(in the case of multi-permission request in one API call) the
content was chopped off as the height measurement for how much
the content needs to be was restricted by the parent measure
spec. Now we measure with no restrictions to accommodate the
whole content.
The way reqeust permissions dialog is implemented is problematic
as it is a dialog styled activity which means we may need to
resize its window. It is better to implement it as a fullscreen
activity that has a custom content layout mangar that makes
the content look like a dialog. Since this is risky at this
point we do targeted fixes to address the above issues.
bug:24679384
Change-Id: If51a360ba17dfb71b66dcf841ea47c17606eba27
|
| | |
| | |
| | |
| | |
| | |
| | | |
bug:26032074
Change-Id: If6566411e08b3a27eecc2ca559c2b902dc8c1e65
|
| | |
| | |
| | |
| | | |
Change-Id: I17ae37d84c0d78bcfcaa848efb17f46c7f7c915a
|
| | |
| | |
| | |
| | | |
Change-Id: Ifc88b2fa259d2d22bea6b5500cded2714ad4da85
|
|\| |
| | |
| | |
| | |
| | |
| | |
| | | |
am: 2a6f5d0fc6
* commit '2a6f5d0fc6b3fc65120ba7ed13f81af2d59eb11f':
Fix build
|
| | |
| | |
| | |
| | | |
Change-Id: I2a3e235bb13f1920c14f6776ee3a1ef7285ea548
|
|\| |
| | |
| | |
| | |
| | |
| | |
| | | |
am: b44b5380b4
* commit 'b44b5380b41ea7a0337709494f6e63eea60c522e':
Clean up package installer styling
|
| |\ \
| | | |
| | | |
| | | | |
Change-Id: I965fb579e2730fa1cdb182bc18e134f262929328
|
| | |\ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
am: 2cf17ddcef
* commit '2cf17ddcef3c8dd260bd3d174123842c81a7d025':
Clean up package installer styling
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Package installer should be using exclusively the device
defaut themes on handhelds (phones and tables) to allow
OEMs customize its look and feel. Also for handhelds the
installer should use the same preference framework as the
settings app to ensure it looks like the settings app on
an OEMs device.
This change needs to be picked up by a GMS build to deliver
to partners ensuring the installer UI is consistent with
the device UI.
bug:24286616
Change-Id: I92e39fd1488e76b0b23b7f1efa13e04ed5bbc7ba
|
|\| | | |
| | | | |
| | | | |
| | | | | |
Change-Id: I1439964d551cdc6b829fc99edd8b2c138dc1abf5
|
| | | | |
| | | | |
| | | | |
| | | | | |
Change-Id: I3fe38a9ac62466b38efec834dceb712d2782c518
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We are trying to remove as many size thresholds as possible for the
multi window support. This value will be now calculated in code during
the creation of the view.
Bug: 25394588
Change-Id: I7dfaa23c491fbab9a320c52877deff8a26ddb91e
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
There was an incorrect calculation for determining when
the content was occluded by the button bar or not.
BUG: 25164689
Change-Id: I121f6e0232da2d1536e0fbbf697e00a4f9c1841f
|
| |_|/
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
It looks like the cached index had become invalid at some
point. It's unclear why, but the logs suggest that a
bunch of Home services crashed.
Rather than cache the index within the Activity, I have
changed the code to send the index along with the
dialog activity launch. This way when the dialog returns,
the index will be saved within the callback.
The index should be enough because the permission set
should not change for the app between screens and the
permission set is alphabetized.
BUG: 25334674
Change-Id: I8f9189960aa7fc9b09cc25f594397523550ac626
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Make handler run on UI thread to avoid race conditions.
Update some logic to prevent animation from running when it
shouldn't be.
BUG: 24954323
Change-Id: Ia1635cbb3c9128080a8e4a9c3ce6ee935c4d957e
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If either the page number or an icon is shown above the message,
reduce the top padding on round screens.
Bug: 24961379
Change-Id: Iec9193e3bbdd8ac607743cd0010f2331edbebc81
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Add top padding to the content inside the scroll view for the grant
permission dialog so that you can read the beginning of the text on
round watches.
Bug: 24961379
Change-Id: I9311fbaabd72bd8f8aee4f71845c1ae11bfeab8c
|
|\| |
| | |
| | |
| | |
| | | |
* commit '6986f29bb93a6aaaeaaddcab081d0e0afd7082e8':
Auto grant permissions in an already granted group.
|
| | |
| | |
| | |
| | |
| | |
| | | |
bug:24074183
Change-Id: Iad6f9b7d5b83d0b0121796891bcd069658995a47
|