summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorTreeHugger Robot <treehugger-gerrit@google.com>2019-05-21 15:11:12 +0000
committerAndroid (Google) Code Review <android-gerrit@google.com>2019-05-21 15:11:12 +0000
commit6d5e1f3db713e0575c6b88433700e2b2adcb41d5 (patch)
tree8f0efe60719db131d6bd718f0e9a48f7071e6149 /src
parent14ad8ec849a5e69a9d33f3670ad2dcba81859ef2 (diff)
parent52f2c51e6a2494cbee76202dfa9ae00eb5f4384d (diff)
downloadandroid_packages_apps_PackageInstaller-6d5e1f3db713e0575c6b88433700e2b2adcb41d5.tar.gz
android_packages_apps_PackageInstaller-6d5e1f3db713e0575c6b88433700e2b2adcb41d5.tar.bz2
android_packages_apps_PackageInstaller-6d5e1f3db713e0575c6b88433700e2b2adcb41d5.zip
Merge "Fix crash in permission grant screen." into qt-dev
Diffstat (limited to 'src')
-rw-r--r--src/com/android/packageinstaller/permission/ui/GrantPermissionsActivity.java42
1 files changed, 21 insertions, 21 deletions
diff --git a/src/com/android/packageinstaller/permission/ui/GrantPermissionsActivity.java b/src/com/android/packageinstaller/permission/ui/GrantPermissionsActivity.java
index 1132308e..e8d60f01 100644
--- a/src/com/android/packageinstaller/permission/ui/GrantPermissionsActivity.java
+++ b/src/com/android/packageinstaller/permission/ui/GrantPermissionsActivity.java
@@ -265,6 +265,19 @@ public class GrantPermissionsActivity extends Activity
setTitle(R.string.permission_request_title);
+ mRequestedPermissions = getIntent().getStringArrayExtra(
+ PackageManager.EXTRA_REQUEST_PERMISSIONS_NAMES);
+ if (mRequestedPermissions == null) {
+ mRequestedPermissions = new String[0];
+ }
+
+ final int requestedPermCount = mRequestedPermissions.length;
+
+ if (requestedPermCount == 0) {
+ setResultAndFinish();
+ return;
+ }
+
PackageInfo callingPackageInfo = getCallingPackageInfo();
if (callingPackageInfo == null || callingPackageInfo.requestedPermissions == null
@@ -273,6 +286,14 @@ public class GrantPermissionsActivity extends Activity
return;
}
+ // Don't allow legacy apps to request runtime permissions.
+ if (callingPackageInfo.applicationInfo.targetSdkVersion < Build.VERSION_CODES.M) {
+ // Returning empty arrays means a cancellation.
+ mRequestedPermissions = new String[0];
+ setResultAndFinish();
+ return;
+ }
+
mCallingUid = callingPackageInfo.applicationInfo.uid;
UserHandle userHandle = UserHandle.getUserHandleForUid(mCallingUid);
@@ -292,27 +313,6 @@ public class GrantPermissionsActivity extends Activity
.setResultListener(this);
}
- mRequestedPermissions = getIntent().getStringArrayExtra(
- PackageManager.EXTRA_REQUEST_PERMISSIONS_NAMES);
- if (mRequestedPermissions == null) {
- mRequestedPermissions = new String[0];
- }
-
- final int requestedPermCount = mRequestedPermissions.length;
-
- if (requestedPermCount == 0) {
- setResultAndFinish();
- return;
- }
-
- // Don't allow legacy apps to request runtime permissions.
- if (callingPackageInfo.applicationInfo.targetSdkVersion < Build.VERSION_CODES.M) {
- // Returning empty arrays means a cancellation.
- mRequestedPermissions = new String[0];
- setResultAndFinish();
- return;
- }
-
mAppPermissions = new AppPermissions(this, callingPackageInfo, false,
new Runnable() {
@Override