Partial cherry-pick changes on permission model change.

am: b8e4193e57

Change-Id: I06ddf41de29c70df865434685ee7cb652cfddbbd

1 files changed, 18 insertions, 25 deletions

diff --git a/src/com/android/packageinstaller/permission/model/AppPermissions.java b/src/com/android/packageinstaller/permission/model/AppPermissions.java
index 38f35f96..099e5b07 100644
--- a/src/com/android/packageinstaller/permission/model/AppPermissions.java
+++ b/src/com/android/packageinstaller/permission/model/AppPermissions.java
@@ -48,11 +48,11 @@ public final class AppPermissions {
 
     private PackageInfo mPackageInfo;
 
-    public AppPermissions(Context context, PackageInfo packageInfo, String[] permissions,
+    public AppPermissions(Context context, PackageInfo packageInfo, String[] filterPermissions,
             boolean sortGroups, Runnable onErrorCallback) {
         mContext = context;
         mPackageInfo = packageInfo;
-        mFilterPermissions = permissions;
+        mFilterPermissions = filterPermissions;
         mAppLabel = BidiFormatter.getInstance().unicodeWrap(
                 packageInfo.applicationInfo.loadSafeLabel(
                 context.getPackageManager()).toString());
@@ -122,34 +122,13 @@ public final class AppPermissions {
                     if (!filterPermission.equals(requestedPerm)) {
                         continue;
                     }
-
-                    if (hasGroupForPermission(requestedPerm)) {
-                        break;
-                    }
-
-                    AppPermissionGroup group = AppPermissionGroup.create(mContext,
-                            mPackageInfo, requestedPerm);
-                    if (group == null) {
-                        break;
-                    }
-
-                    mGroups.add(group);
+                    addPermissionGroupIfNeeded(requestedPerm);
                     break;
                 }
             }
         } else {
             for (String requestedPerm : mPackageInfo.requestedPermissions) {
-                if (hasGroupForPermission(requestedPerm)) {
-                    continue;
-                }
-
-                AppPermissionGroup group = AppPermissionGroup.create(mContext,
-                        mPackageInfo, requestedPerm);
-                if (group == null) {
-                    continue;
-                }
-
-                mGroups.add(group);
+                addPermissionGroupIfNeeded(requestedPerm);
             }
         }
 
@@ -163,6 +142,20 @@ public final class AppPermissions {
         }
     }
 
+    private void addPermissionGroupIfNeeded(String permission) {
+        if (hasGroupForPermission(permission)) {
+            return;
+        }
+
+        AppPermissionGroup group = AppPermissionGroup.create(mContext,
+                mPackageInfo, permission);
+        if (group == null) {
+            return;
+        }
+
+        mGroups.add(group);
+    }
+
     private boolean hasGroupForPermission(String permission) {
         for (AppPermissionGroup group : mGroups) {
             if (group.hasPermission(permission)) {