summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSvet Ganov <svetoslavganov@google.com>2016-06-08 15:56:29 -0700
committerSvet Ganov <svetoslavganov@google.com>2016-06-08 15:56:32 -0700
commit869786e3e44a4ef9ce54c7208e97490b1cdb2608 (patch)
tree0560b5f382cb4c22c187626089ac542d96d141f3
parentcc5cd738730e26e464b24beb76288b994787d748 (diff)
downloadandroid_packages_apps_PackageInstaller-869786e3e44a4ef9ce54c7208e97490b1cdb2608.tar.gz
android_packages_apps_PackageInstaller-869786e3e44a4ef9ce54c7208e97490b1cdb2608.tar.bz2
android_packages_apps_PackageInstaller-869786e3e44a4ef9ce54c7208e97490b1cdb2608.zip
Fix a crash in package installer
The first bug was that we were starting the install before having the package info for the installed app. The second was that we were calling the permission review UI despite we were there before the user selected to install. i.e. the user already reviewed the permissions. bug:29197887 Change-Id: I2fac4d014dde7f7744a6b831c2b0ff510e29e8e8
-rwxr-xr-xsrc/com/android/packageinstaller/InstallAppProgress.java1
-rw-r--r--src/com/android/packageinstaller/PackageInstallerActivity.java2
2 files changed, 1 insertions, 2 deletions
diff --git a/src/com/android/packageinstaller/InstallAppProgress.java b/src/com/android/packageinstaller/InstallAppProgress.java
index e93c93c7..c6e3a46c 100755
--- a/src/com/android/packageinstaller/InstallAppProgress.java
+++ b/src/com/android/packageinstaller/InstallAppProgress.java
@@ -351,7 +351,6 @@ public class InstallAppProgress extends Activity implements View.OnClickListener
params.originatingUri = getIntent().getParcelableExtra(Intent.EXTRA_ORIGINATING_URI);
params.originatingUid = getIntent().getIntExtra(Intent.EXTRA_ORIGINATING_UID,
UID_UNKNOWN);
- params.setInstallFlagsForcePermissionPrompt();
mInstallHandler.post(new Runnable() {
@Override
diff --git a/src/com/android/packageinstaller/PackageInstallerActivity.java b/src/com/android/packageinstaller/PackageInstallerActivity.java
index 6692d66a..1903f917 100644
--- a/src/com/android/packageinstaller/PackageInstallerActivity.java
+++ b/src/com/android/packageinstaller/PackageInstallerActivity.java
@@ -456,7 +456,7 @@ public class PackageInstallerActivity extends Activity implements OnCancelListen
// Block the install attempt on the Unknown Sources setting if necessary.
final boolean requestFromUnknownSource = isInstallRequestFromUnknownSource(intent);
if (!requestFromUnknownSource) {
- initiateInstall();
+ processPackageUri(packageUri);
return;
}