summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristopher Dombroski <cdombroski@google.com>2019-04-16 13:18:58 -0700
committerChristopher Dombroski <cdombroski@google.com>2019-04-24 20:04:09 +0000
commit217f31fb5da6a08b2172d292fa5b8f440c02ae3a (patch)
tree1378c4260e1a3da9dfc69585a87f8a1899ca6c2c
parentb5302e6789b7a0b8f5625e054fbb21d5916652be (diff)
downloadandroid_packages_apps_PackageInstaller-217f31fb5da6a08b2172d292fa5b8f440c02ae3a.tar.gz
android_packages_apps_PackageInstaller-217f31fb5da6a08b2172d292fa5b8f440c02ae3a.tar.bz2
android_packages_apps_PackageInstaller-217f31fb5da6a08b2172d292fa5b8f440c02ae3a.zip
[RESTRICT AUTOMERGE]: OP_REQUEST_INSTALL_PACKAGES denied by default
Some system apps may download unknown content and the user should be explicitly asked whether they trust these files. System apps should explicitly use the extra NOT_UNKNOWN_SOURCE to bypass this check. Test: Builds, boots, existing tests pass: atest CtsPackageInstallTestCases Locally verified they pass if CtsPackageInstallTestCases.apk was signed by the platform cert. Bug: 123700348 Change-Id: I962217e8736f1f62e91fd968ba7dc7fda46d67db
-rw-r--r--src/com/android/packageinstaller/PackageInstallerActivity.java11
1 files changed, 0 insertions, 11 deletions
diff --git a/src/com/android/packageinstaller/PackageInstallerActivity.java b/src/com/android/packageinstaller/PackageInstallerActivity.java
index 48f2f901..0f41c982 100644
--- a/src/com/android/packageinstaller/PackageInstallerActivity.java
+++ b/src/com/android/packageinstaller/PackageInstallerActivity.java
@@ -40,7 +40,6 @@ import android.net.Uri;
import android.os.Build;
import android.os.Bundle;
import android.os.Process;
-import android.os.RemoteException;
import android.os.UserManager;
import android.provider.Settings;
import android.support.annotation.NonNull;
@@ -521,16 +520,6 @@ public class PackageInstallerActivity extends OverlayTouchActivity implements On
mOriginatingUid, mOriginatingPackage);
switch (appOpMode) {
case AppOpsManager.MODE_DEFAULT:
- try {
- int result = mIpm.checkUidPermission(
- Manifest.permission.REQUEST_INSTALL_PACKAGES, mOriginatingUid);
- if (result == PackageManager.PERMISSION_GRANTED) {
- initiateInstall();
- break;
- }
- } catch (RemoteException exc) {
- Log.e(TAG, "Unable to talk to package manager");
- }
mAppOpsManager.setMode(AppOpsManager.OP_REQUEST_INSTALL_PACKAGES, mOriginatingUid,
mOriginatingPackage, AppOpsManager.MODE_ERRORED);
// fall through