summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVictoria Lease <violets@google.com>2012-03-29 10:33:39 -0700
committerVictoria Lease <violets@google.com>2012-03-29 11:03:21 -0700
commite5ce1bc4792003844b2ad60fbe2078f2ab8e1ebe (patch)
treede54ec00a857b033044acedaf03700c1a6340542
parentf7e65c83cef1c10ffe099f96bdf399f30aa5c79a (diff)
downloadandroid_packages_apps_Gello-e5ce1bc4792003844b2ad60fbe2078f2ab8e1ebe.tar.gz
android_packages_apps_Gello-e5ce1bc4792003844b2ad60fbe2078f2ab8e1ebe.tar.bz2
android_packages_apps_Gello-e5ce1bc4792003844b2ad60fbe2078f2ab8e1ebe.zip
Remove "hl=" parameter from incognito-mode GWS searches.
It prevents GWS from honoring Accept-language: headers, and can result in degraded search result quality. Bug: 5777487 Change-Id: Ifee726bc0b3e79be628d288606777969e72c11a0
-rw-r--r--res/values/all_search_engines.xml4
-rwxr-xr-xtools/get_search_engines.py4
2 files changed, 4 insertions, 4 deletions
diff --git a/res/values/all_search_engines.xml b/res/values/all_search_engines.xml
index 58992a42..da8d3b2e 100644
--- a/res/values/all_search_engines.xml
+++ b/res/values/all_search_engines.xml
@@ -208,9 +208,9 @@ http://www.opensearch.org/Specifications/OpenSearch/1.1/Draft_4#OpenSearch_1.1_p
<item>Google</item>
<item>google.com</item>
<item>http://www.google.com/favicon.ico</item>
- <item>http://www.google.com/search?hl={language}&amp;ie={inputEncoding}&amp;source=android-browser&amp;q={searchTerms}</item>
+ <item>http://www.google.com/search?ie={inputEncoding}&amp;source=android-browser&amp;q={searchTerms}</item>
<item>UTF-8</item>
- <item>http://www.google.com/complete/search?hl={language}&amp;client=android&amp;q={searchTerms}</item>
+ <item>http://www.google.com/complete/search?client=android&amp;q={searchTerms}</item>
</string-array>
<string-array name="bing_en_NZ" translatable="false">
<item>Bing</item>
diff --git a/tools/get_search_engines.py b/tools/get_search_engines.py
index 86393f1b..17916c80 100755
--- a/tools/get_search_engines.py
+++ b/tools/get_search_engines.py
@@ -39,9 +39,9 @@ locales = ["cs-CZ", "da-DK", "de-AT", "de-CH", "de-DE", "el-GR", "en-AU",
google_data = ["google", "Google", "google.com",
"http://www.google.com/favicon.ico",
- "http://www.google.com/search?hl={language}&amp;ie={inputEncoding}&amp;source=android-browser&amp;q={searchTerms}",
+ "http://www.google.com/search?ie={inputEncoding}&amp;source=android-browser&amp;q={searchTerms}",
"UTF-8",
- "http://www.google.com/complete/search?hl={language}&amp;client=android&amp;q={searchTerms}"]
+ "http://www.google.com/complete/search?client=android&amp;q={searchTerms}"]
class SearchEngineManager(object):
"""Manages list of search engines and creates locale specific lists.