summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorLikai Ding <likaid@codeaurora.org>2016-05-05 14:52:52 +0800
committerSteve Kondik <steve@cyngn.com>2016-09-26 04:54:49 -0700
commit0f34582709227dd5c2e0d26d59bc6dd8e6f4f6a2 (patch)
tree4187256246e1a8e9ca8bd6587e544dc273119368 /src
parent693644a222bd842e9143020eaf5e732a7f3945c8 (diff)
downloadandroid_packages_apps_Gallery2-0f34582709227dd5c2e0d26d59bc6dd8e6f4f6a2.tar.gz
android_packages_apps_Gallery2-0f34582709227dd5c2e0d26d59bc6dd8e6f4f6a2.tar.bz2
android_packages_apps_Gallery2-0f34582709227dd5c2e0d26d59bc6dd8e6f4f6a2.zip
Gallery: fix a memory leak
If video playing is completed, not paused or cancelled, the Runnables posted are not removed from the Handler. Make sure they are removed. Change-Id: I4c27583e4305398b35188c494b6da15f809439b9 CRs-Fixed: 999702
Diffstat (limited to 'src')
-rwxr-xr-xsrc/com/android/gallery3d/app/MoviePlayer.java2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/com/android/gallery3d/app/MoviePlayer.java b/src/com/android/gallery3d/app/MoviePlayer.java
index 4b1e8686e..3a17b8c25 100755
--- a/src/com/android/gallery3d/app/MoviePlayer.java
+++ b/src/com/android/gallery3d/app/MoviePlayer.java
@@ -691,12 +691,14 @@ public class MoviePlayer implements
}
if (mMovieItem.getError()) {
Log.w(TAG, "error occured, exit the video player!");
+ mHandler.removeCallbacksAndMessages(null);
mActivityContext.finish();
return;
}
if (mPlayerExt.getLoop()) {
onReplay();
} else { //original logic
+ mHandler.removeCallbacksAndMessages(null);
mTState = TState.COMPELTED;
if (mCanReplay) {
mController.showEnded();