summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorkaiyiz <kaiyiz@codeaurora.org>2014-02-25 17:37:14 +0800
committeremancebo <emancebo@cyngn.com>2014-09-04 10:40:18 -0700
commit9b59b8e3937b7fd91a9f0367cf69d93c57de2d65 (patch)
tree81299e5c4c473073a7c2d02ed2d4a66a10f4528c /src
parent3942d2beece88cd0c4a9129702063be722f83db8 (diff)
downloadandroid_packages_apps_Gallery2-9b59b8e3937b7fd91a9f0367cf69d93c57de2d65.tar.gz
android_packages_apps_Gallery2-9b59b8e3937b7fd91a9f0367cf69d93c57de2d65.tar.bz2
android_packages_apps_Gallery2-9b59b8e3937b7fd91a9f0367cf69d93c57de2d65.zip
Gallery2: Fix Gallery Crash when click Information menu.
In UpdatePreviewTask,the condition in the doInBackground is not correct which cause the NullPointerException happened. Only judge the buffer.getProducer() before it is used. CRs-Fixed: 619081 Conflicts: src/com/android/gallery3d/filtershow/pipeline/UpdatePreviewTask.java Change-Id: Iac3152328abeb72002785cfa2eb28830ea87f439
Diffstat (limited to 'src')
-rw-r--r--src/com/android/gallery3d/filtershow/pipeline/UpdatePreviewTask.java8
1 files changed, 5 insertions, 3 deletions
diff --git a/src/com/android/gallery3d/filtershow/pipeline/UpdatePreviewTask.java b/src/com/android/gallery3d/filtershow/pipeline/UpdatePreviewTask.java
index a55abca3d..8fcf7539f 100644
--- a/src/com/android/gallery3d/filtershow/pipeline/UpdatePreviewTask.java
+++ b/src/com/android/gallery3d/filtershow/pipeline/UpdatePreviewTask.java
@@ -57,14 +57,16 @@ public class UpdatePreviewTask extends ProcessingTask {
SharedBuffer buffer = MasterImage.getImage().getPreviewBuffer();
SharedPreset preset = MasterImage.getImage().getPreviewPreset();
ImagePreset renderingPreset = preset.dequeuePreset();
- if ( (buffer != null) && (renderingPreset != null)) {
+ if ((buffer != null) && (renderingPreset != null)) {
mPreviewPipeline.compute(buffer, renderingPreset, 0);
if ( buffer.getProducer() == null) {
return null;
}
// set the preset we used in the buffer for later inspection UI-side
- buffer.getProducer().setPreset(renderingPreset);
- buffer.getProducer().sync();
+ if (buffer.getProducer() != null) {
+ buffer.getProducer().setPreset(renderingPreset);
+ buffer.getProducer().sync();
+ }
buffer.swapProducer(); // push back the result
}
return null;