summaryrefslogtreecommitdiffstats
path: root/jni
diff options
context:
space:
mode:
authorChih-Hung Hsieh <chh@google.com>2016-06-29 11:42:46 -0700
committerArne Coucheron <arco68@gmail.com>2018-11-10 23:57:25 +0100
commit8dfa3a7cc79cf04769e57b1e997afade7799a966 (patch)
tree8c581058b9898231c9d58411f80b121d2485d068 /jni
parent02de8aafc2bcdd82d95193c801fdd5792c2da3c0 (diff)
downloadandroid_packages_apps_Gallery2-8dfa3a7cc79cf04769e57b1e997afade7799a966.tar.gz
android_packages_apps_Gallery2-8dfa3a7cc79cf04769e57b1e997afade7799a966.tar.bz2
android_packages_apps_Gallery2-8dfa3a7cc79cf04769e57b1e997afade7799a966.zip
Fix misc-macro-parentheses warnings in Gallery2.
Add parentheses around negative literals and parameters beside operators. Bug: 28705665 Test: build with clang-tidy Change-Id: Icdb2d003e77f6b0dfac7d9c30dec0ee80c13e3cd
Diffstat (limited to 'jni')
-rw-r--r--jni/filters/filters.h12
1 files changed, 6 insertions, 6 deletions
diff --git a/jni/filters/filters.h b/jni/filters/filters.h
index 55c260f06..a46b3cedc 100644
--- a/jni/filters/filters.h
+++ b/jni/filters/filters.h
@@ -25,23 +25,23 @@
typedef unsigned int Color;
-#define SetColor(a, r, g, b) ((a << 24) | (b << 16) | (g << 8) | (r << 0));
+#define SetColor(a, r, g, b) (((a) << 24) | ((b) << 16) | ((g) << 8) | ((r) << 0));
#define GetA(color) (((color) >> 24) & 0xFF)
#define GetB(color) (((color) >> 16) & 0xFF)
#define GetG(color) (((color) >> 8) & 0xFF)
#define GetR(color) (((color) >> 0) & 0xFF)
-#define MIN(a, b) (a < b ? a : b)
-#define MAX(a, b) (a > b ? a : b)
+#define MIN(a, b) ((a) < (b) ? (a) : (b))
+#define MAX(a, b) ((a) > (b) ? (a) : (b))
#define LOG(msg...) __android_log_print(ANDROID_LOG_VERBOSE, "NativeFilters", msg)
#define JNIFUNCF(cls, name, vars...) Java_com_android_gallery3d_filtershow_filters_ ## cls ## _ ## name(JNIEnv* env, jobject obj, vars)
#define RED i
-#define GREEN i+1
-#define BLUE i+2
-#define ALPHA i+3
+#define GREEN (i+1)
+#define BLUE (i+2)
+#define ALPHA (i+3)
#define CLAMP(c) (MAX(0, MIN(255, c)))
__inline__ unsigned char clamp(int c)