summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorkayiz <kaiyiz@codeaurora.org>2013-12-03 15:04:01 +0800
committerSteve Kondik <shade@chemlab.org>2013-12-10 03:49:22 -0800
commit0b9e20a63f96830080897fef45de3e424e70c2af (patch)
treea1c24ae012ae72975e460cb7f5771c02bb53ed31
parent11fe965b923ce94f64c456134141394d3f8cb63c (diff)
downloadandroid_packages_apps_Gallery2-0b9e20a63f96830080897fef45de3e424e70c2af.tar.gz
android_packages_apps_Gallery2-0b9e20a63f96830080897fef45de3e424e70c2af.tar.bz2
android_packages_apps_Gallery2-0b9e20a63f96830080897fef45de3e424e70c2af.zip
Gallery2: fix FC when view the details of some pictures
Pictures captured by some devices seems didn't comply with the standards, it will get null when set details, then it will throw out an exception. If it can not get a detail value, do not display it, and print error log. CRs-Fixed: 583463 Change-Id: I69be48cb25a4413ae7ddbe301891c94e88671c0f
-rw-r--r--src/com/android/gallery3d/ui/DialogDetailsView.java5
1 files changed, 3 insertions, 2 deletions
diff --git a/src/com/android/gallery3d/ui/DialogDetailsView.java b/src/com/android/gallery3d/ui/DialogDetailsView.java
index 41753f6ea..b507407f9 100644
--- a/src/com/android/gallery3d/ui/DialogDetailsView.java
+++ b/src/com/android/gallery3d/ui/DialogDetailsView.java
@@ -201,8 +201,9 @@ public class DialogDetailsView implements DetailsViewContainer {
Object valueObj = detail.getValue();
// This shouldn't happen, log its key to help us diagnose the problem.
if (valueObj == null) {
- Utils.fail("%s's value is Null",
- DetailsHelper.getDetailsName(context, detail.getKey()));
+ Log.e(TAG, DetailsHelper.getDetailsName(
+ context, detail.getKey()) + "'s value is Null");
+ continue;
}
value = valueObj.toString();
}