summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSteve Kondik <shade@chemlab.org>2013-10-14 12:25:08 -0700
committerSteve Kondik <shade@chemlab.org>2013-10-16 09:13:57 -0700
commit2af78fdfb4a069481cc895259e44977b2844258e (patch)
treed00e20bbf8031f058f58e26945b60f3511d7cf32
parent8759aa27470e20634d5771269df950106a7d4ade (diff)
downloadandroid_packages_apps_Gallery2-2af78fdfb4a069481cc895259e44977b2844258e.tar.gz
android_packages_apps_Gallery2-2af78fdfb4a069481cc895259e44977b2844258e.tar.bz2
android_packages_apps_Gallery2-2af78fdfb4a069481cc895259e44977b2844258e.zip
camera: Add parameter debugging support
Change-Id: Ifc1653f0046af169ba36d94796b4d9a3055c6798
-rw-r--r--src/com/android/camera/PhotoModule.java1
-rw-r--r--src/com/android/camera/Util.java28
-rw-r--r--src/com/android/camera/VideoModule.java2
3 files changed, 25 insertions, 6 deletions
diff --git a/src/com/android/camera/PhotoModule.java b/src/com/android/camera/PhotoModule.java
index 1f33f4b43..70846f134 100644
--- a/src/com/android/camera/PhotoModule.java
+++ b/src/com/android/camera/PhotoModule.java
@@ -1993,6 +1993,7 @@ public class PhotoModule
updateCameraParametersPreference();
}
+ Util.dumpParameters(mParameters);
mCameraDevice.setParameters(mParameters);
}
diff --git a/src/com/android/camera/Util.java b/src/com/android/camera/Util.java
index 8726870f9..dece75379 100644
--- a/src/com/android/camera/Util.java
+++ b/src/com/android/camera/Util.java
@@ -60,9 +60,13 @@ import java.io.Closeable;
import java.io.IOException;
import java.lang.reflect.Method;
import java.text.SimpleDateFormat;
+import java.util.Arrays;
import java.util.Date;
+import java.util.Iterator;
import java.util.List;
+import java.util.Set;
import java.util.StringTokenizer;
+import java.util.TreeSet;
/**
* Collection of utility functions used in this package.
@@ -629,13 +633,25 @@ public class Util {
return optimalSize;
}
- public static void dumpParameters(Parameters parameters) {
- String flattened = parameters.flatten();
- StringTokenizer tokenizer = new StringTokenizer(flattened, ";");
- Log.d(TAG, "Dump all camera parameters:");
- while (tokenizer.hasMoreElements()) {
- Log.d(TAG, tokenizer.nextToken());
+ public static void dumpParameters(Parameters params) {
+ Set<String> sortedParams = new TreeSet<String>();
+ sortedParams.addAll(Arrays.asList(params.flatten().split(";")));
+ StringBuilder sb = new StringBuilder();
+ sb.append("[");
+ Iterator<String> i = sortedParams.iterator();
+ while (i.hasNext()) {
+ String nextParam = i.next();
+ if ((sb.length() + nextParam.length()) > 2044) {
+ Log.d(TAG, "Parameters: " + sb.toString());
+ sb = new StringBuilder();
+ }
+ sb.append(nextParam);
+ if (i.hasNext()) {
+ sb.append(", ");
+ }
}
+ sb.append("]");
+ Log.d(TAG, "Parameters: " + sb.toString());
}
/**
diff --git a/src/com/android/camera/VideoModule.java b/src/com/android/camera/VideoModule.java
index 98bb78ac7..0cef4677c 100644
--- a/src/com/android/camera/VideoModule.java
+++ b/src/com/android/camera/VideoModule.java
@@ -1936,6 +1936,8 @@ public class VideoModule implements CameraModule,
CameraProfile.QUALITY_HIGH);
mParameters.setJpegQuality(jpegQuality);
+ Util.dumpParameters(mParameters);
+
mActivity.mCameraDevice.setParameters(mParameters);
// Keep preview size up to date.
mParameters = mActivity.mCameraDevice.getParameters();