diff options
| author | Michael W <baddaemon87@gmail.com> | 2016-06-07 21:05:00 +0200 |
|---|---|---|
| committer | Arne Coucheron <arco68@gmail.com> | 2017-07-31 00:38:34 +0200 |
| commit | 9c69a829b6140b19135a3448bc525fa5e9c47008 (patch) | |
| tree | cd1f6a517652f7e735e9fe4e9bd003f460d4384a | |
| parent | 4288cf9e0e1dd1e394af8670bd3e6dee3d75f6be (diff) | |
| download | android_packages_apps_Gallery2-9c69a829b6140b19135a3448bc525fa5e9c47008.tar.gz android_packages_apps_Gallery2-9c69a829b6140b19135a3448bc525fa5e9c47008.tar.bz2 android_packages_apps_Gallery2-9c69a829b6140b19135a3448bc525fa5e9c47008.zip | |
Gallery2: Remove more possible NPEs
getCache can return null ->
check this before proceeding
Change-Id: I834780a4dafbe22f2d345fe5571cb20f3f3e5e2e
| -rw-r--r-- | src/com/android/gallery3d/app/MoviePlayer.java | 1 | ||||
| -rw-r--r-- | src/com/android/gallery3d/data/ImageCacheService.java | 6 |
2 files changed, 7 insertions, 0 deletions
diff --git a/src/com/android/gallery3d/app/MoviePlayer.java b/src/com/android/gallery3d/app/MoviePlayer.java index d156b792b..999107734 100644 --- a/src/com/android/gallery3d/app/MoviePlayer.java +++ b/src/com/android/gallery3d/app/MoviePlayer.java @@ -1694,6 +1694,7 @@ class Bookmarker { BlobCache cache = CacheManager.getCache(mContext, BOOKMARK_CACHE_FILE, BOOKMARK_CACHE_MAX_ENTRIES, BOOKMARK_CACHE_MAX_BYTES, BOOKMARK_CACHE_VERSION); + if (cache == null) return null; byte[] data = cache.lookup(uri.hashCode()); if (data == null) return null; diff --git a/src/com/android/gallery3d/data/ImageCacheService.java b/src/com/android/gallery3d/data/ImageCacheService.java index 129c113a6..861d4b766 100644 --- a/src/com/android/gallery3d/data/ImageCacheService.java +++ b/src/com/android/gallery3d/data/ImageCacheService.java @@ -56,6 +56,8 @@ public class ImageCacheService { * @return true if the image data is found; false if not found. */ public boolean getImageData(Path path, long timeModified, int type, BytesBuffer buffer) { + if (mCache == null) return false; + byte[] key = makeKey(path, timeModified, type); long cacheKey = Utils.crc64Long(key); try { @@ -81,6 +83,8 @@ public class ImageCacheService { } public void putImageData(Path path, long timeModified, int type, byte[] value) { + if (mCache == null) return; + byte[] key = makeKey(path, timeModified, type); long cacheKey = Utils.crc64Long(key); ByteBuffer buffer = ByteBuffer.allocate(key.length + value.length); @@ -99,6 +103,8 @@ public class ImageCacheService { } public void clearImageData(Path path, long timeModified, int type) { + if (mCache == null) return; + byte[] key = makeKey(path, timeModified, type); long cacheKey = Utils.crc64Long(key); if (mCache == null) { |
