| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
| |
Bug: 34134606
Test: manual - Talkback correctly pronounces "M minus"
Change-Id: I1f898fc9a96e685d80ba0c133e3c83fab5d94a71
|
| |
|
|
|
| |
Bug: 33533120
Change-Id: I8aebade6689ff6011d2019a9ff8c32f629defb9e
|
| |
|
|
|
|
|
|
|
| |
Fixes: 33071825
-Change "Clear history" menu option to "Clear"
-Add verification dialog before user clears history/memory.
Change-Id: I10db6c4f914fc3af0a525f1c22e719b6407dba9b
|
| |
|
|
|
|
|
|
| |
Bug: 31686717
Test: manual - long-press on result and formula and proper context
menus appear, as well as on results in history.
Change-Id: I88b25ed9d0402e03b420ab984a6b086dff6859e5
|
| |
|
|
|
|
|
|
|
|
|
| |
Bug: 31623549
Test: Use a one-element array in HistoryFragment.testArray
This view displays when there is only one element (the current
expression) in the Adapter.
Change-Id: I418559c6d6b742053861a0d7783fa5fd4c329c56
|
| |
|
|
|
|
|
| |
Bug: 31623549
Bug: 32584801
Change-Id: I07a54cad38c026357082b86ad026392f72693e22
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug: 31623549
Bug: 31686717
This version superficially works, but introduces a number of FIXME
comments that should be repaired before shipping. It may not stand
up well to monkey tests.
Add ExpressionDB.java that encapsulates a SQLite database to hold
the calculator history.
Change Evaluator to support simultaneous evaluation of many different
expressions, such as those in the history. In order to avoid UI thread
blocking, the evaluator now loads referenced subexpression on demand,
and multiple expressions can be evaluated simultaneously. We handle
the concurrency somewhat optimistically, arranging to have concurrent
evaluations not step on each other, at the expense of occasionally
throwing away a redundant result.
Change the expression serialization algorithm to make formulas more
compact. Do this now to minimize annoying database format changes.
Persist the saved clipboard and "memory" state.
Add two buttons in landscape mode to allow minimal access to "memory".
Since this involved a substantial rewrite of Evaluator.java, it
includes some drive-by cleanups and minor bug fixes.
Notably:
mMsdIndex was apparently always recomputed, but never actually
saved. Oops. This no doubt added a small amount of overhead.
We updated the decimal conversion size limits, hopefully addressing
b/30200325, possibly at some expense of slightly worse behavior
on old 32-bit devices.
Tests: Tested manually with a bit of added instrumentation.
Ran existing automated tests.
Change-Id: Ifae408d7b4b6cacd19f0e8f5aca146e9c653927e
|
| |
|
|
|
|
|
|
| |
Bug: 26857695
Test: manual - view all four dialog types. 1) Display as fraction,
2) Display leading digits, 3) Timeout and 4) cancellation of a
long calculation.
Change-Id: I3454ae843a5e265b64d5c1b092e655a6e13180ad
|
| |
|
|
|
|
| |
Bug: 31623549
Test: Manually verified history fragment can be added / removed.
Change-Id: Ib3ae8d976811f057d9b99dd503abcaa47ac92ae7
|
| |
|
|
|
|
|
|
|
|
|
| |
Bug: 30630099
Test: Manually tested 1) tapping the result box on cold start, 2)
tapping the result box on warm start, 3) tapping the result box when a
formula is entered but no result, 4) tapping the result box when there
is a result, 5) scrolling the result, and 6) after an existing result is
deleted, both with delete and clear. Unit tests also still pass.
Change-Id: Ief31dc0417592b17ea9a8c6c64a35928aead1ea7
|
| |
|
|
|
|
|
|
|
|
| |
Bug: 22594900
TalkBack now behaves sanely when interacting with the
CalculatorPadViewPager. Each page is now labeled and focusable so that
a11y users can easily identify and interact with the current page.
Change-Id: I03acc62a8630df72955d6e7af08358045f412d51
|
| |
|
|
|
| |
Bug: 27473064
Change-Id: I52715e4833e5a97cf6cf214d0e4da69b603720cc
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug: 23224425
Bug: 23695835
This adds a "cleared" announcement when last token/character is deleted.
Also change the existing "clear" announcements to "cleared".
Improve the comments for desc_clr and desc_del to address prior
misunderstandings.
Improve xml comment formatting consistency.
Change-Id: Ibe5197ceac132b73d72f8ace3982238249f5e82b
|
| |
|
|
|
|
|
|
|
|
| |
Bug: 21623405
Bug: 21603293
Make comments more descriptive for transalation. The attached bugs
requested this for "10 to the power of".
Change-Id: I75da9fcfb076cf74d095d3abef5312571607f0fe
|
| |
|
|
|
| |
Bug: 21688370
Change-Id: I59b05d038f261f40893a025824355b19b0a2b249
|
| |
|
|
|
| |
Bug: 21692303
Change-Id: I5db0e28a60e4daa40117fee899037ac198de859e
|
| |
|
|
|
|
| |
Bug: 20497138
Bug: 20648856
Change-Id: Id71e2c1922447957b61e3c06b205f991f01eea27
|
| |
|
|
|
| |
Bug: 19186434
Change-Id: I0e4793c2ea1fa06bcf0ddee9d642d4732aa8ce84
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug: 21493470
Add x^2 10^x and e^x functions, to make the recently added INV key
work as expected.
Implement % functionality.
10^x is essentially just macro expansions for now.
% and x^2 need trivial evaluator support to provide reasonable display
syntax.
We decided to add evaluator support for exp() as well.
Add corresponding exp() support to BoundedRational and its tests.
Tiny incidental changes for problems uncovered in the process:
Fix bug in tests/README.txt
Evaluate the constant e only once.
Add one more power test along with the exp() test.
Fix proguard.flags so BRTest runs again.
Change-Id: I26cfcaf6d99aeec11387297cc5586e2ddcab6add
|
| |
|
|
|
|
|
|
|
|
| |
Bug: 7263319
Bug: 20841915
- Switch to using GridLayout instead of custom ViewGroup.
- Added '%' operator button (Note: evaluation support WIP).
Change-Id: I0d07f01fe4224c43e53c916b034362d906bea405
|
| |
|
|
|
|
|
| |
Bug: 20973349
Bug: 20980152
Bug: 21024589
Change-Id: I5566d8d94abdc97c52740c97ed57cea98ddc9462
|
| |
|
|
|
|
|
|
|
|
|
| |
Bug: 20877857
Bug: 20815563
- Condensed strings to one string.xml with translatable="false".
- Made functions and digits NOT localized.
- Switched to U+2007 character for unknown digits.
Change-Id: I51a108309ccfa9c40edd6f87f9e052ba7ee25e3a
|
| |
|
|
|
|
|
|
|
|
| |
Bug: 20503109
- Open source licenses are now displayed as a standalone Licenses
activity.
- Show/hide result options instead of enabling/disabling them.
Change-Id: I7e1e43ac83d2417b2f59f90e6a1fc3e491c6ddc7
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug: 20625562
Bug: 20649711
Bug: 20561890
Bug: 20561528
Bug: 20442590
Bug: 15473140
Bug: 20503008
Bug: 20503007
- Improve timeout text.
- Recalculate when Calculator is rotated, e.g. in error state, thus
reproducing message. It's unclear this is good enough, but it's
better.
- Fix square root parsing.
- Fix concatenation of numbers when pasting by adding explicit
multiplication.
- Display divide by zero error differently from other domain errors.
- Improved advanced keypad layout of portrait-mode tablet calculator.
- Improved overflow menu order. (More to be done.)
- Report zero division as zero division when we can recognize it.
- Switch to floating menus for copy/paste.
Change-Id: I3875414f293e62a59b0e41f0de822f29bd5ac6a6
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes issues with inappropriate keyboard popups and cleans
up the code.
This substantially rewrites the result formatting code;
it intentionally removes a heuristic to avoid conventional scientific
notation for short results, which only seemed to confuse things.
There are some other tweaks and simplifications. Transitions
to and from conventional scientific notation should be smoother,
though there is still an issue with numbers like 10^-30.
The formatting code is completely extracted from Evaluator, cutting
off various tentacles, and moved to CalculatorResult.
Fixes a bug that resulted in digits being inappropriately
displayed without an exponent if the decimal point was just off
the left edge of the screen.
It's still not clear that we should always be integrating the
exponent into the result window.
Bug: 20483801
Bug: 20480081
Change-Id: I1bb777b871e9fa8b6cd510c533e4b94bde6d4a20
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change layout to make the result display use a fixed font
size and limit the number of characters when it appears below the
formula. This allows us to always get the proper expansion effect
and prevents scrolling from affecting the font size.
Add copy support for result display.
Add paste support for the formula.
Add keyboard input support.
Copy/paste can be used to remember old results in the calculator.
We save an identifying tag URI in the clip, in addition to text,
allowing us to paste old calculator results without precision
loss.
Copy/paste currently does not rely on selection at all.
I had trouble making it work that way in the formula. It's
unclear that would be better, since we only allow copy of the
entire text and paste at the end.
Add a couple of alternate result display options to the
overflow menu. (These appear quite useful, were trivial to
implement, and give us a better excuse for the overflow menu.)
Changed the behavior of the delete key in error state.
Changing it to CLEAR seemed unfriendly, since it prevents
corrections. This is a change from L.
Made it clear that the CalculatorHitSomeButtons test is
currently 95% worthless. It was apparentlly failing (due to test
infrastructure issues) but throwing an exception in a thread from
which it was not getting reported. Decided to keep it, since I
would like a place to continue collecting regression tests, even
if we can't actually run them yet.
Includes some easy drive-by fixes for expression evaluation:
a) 2 / 2 * 3 was mis-parsed as 2 / (2 * 3).
b) Cosine evaluation had the sense of the test for a rational result reversed.
c) Constants without leading digits, like .1, are now handled correctly,
and decimal points in the formula are now internationalized.
(That's not yet true for the result.)
Change-Id: Ic24466b444b4a4633cfb036c67622c7f4fd644ec
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Add a button for switching between degree and radian mode.
Handle display updates in response to mode switching in a reasonoble way.
Improve the button layout so that it is usable on tablets.
Add DEG/RAD mode display at the top.
Fiddle with some of the layout parameters so they make more sense
to me.
This may need further tuning.
Change-Id: I8d04b235cfcb1f0a0d8f4a0ad6a0dc6e5eac8c5d
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace the arity library with a new evaluation engine based on
an open source "constructive reals" library. This provides answers
that are correct to the last displayed digit, and can be scrolled to
get more precision, with evaluation to additional precision
proceeding on demand.
This uses pieces of an old prototype calculator with a
pre-Material-Design UI. Since the code structure of the KitKat and
Lollipop calculators is quite different, this merge required major
changes to make the pieces fit again. An egregious bug in the
prototype related to the evaluation of the power operator was
fixed. Many new UI bugs are introduced to compensate :-)
Add separate buttons for inverse trig functions.
Add long TODO lists for various missing pieces.
This is really designed to get something up and running
that looks like it has a Material Design UI.
This version kind of works, though with many UI deficiencies.
This addresses external issues 63368, 81089, and 80990. It
partially address the degree vs radian (80330) issue as well,
though we're still missing the UI for that.
This fixes
Bug:15284587
(More work is needed to make this interact correctly with keyboard support.)
Degree/Radian mode is also internal
Bug:17059768
This provides much more robust solutions to the following, which were
previously fixed by favoring round numbers over precise solutions:
Bug:15747298
Bug:15332726
Change-Id: Ib64ffcee9760a3195ae2a48302308eeb09a156bd
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug: 14418545
Bug: 14419084
Bug: 14419142
Bug: 14420277
Bug: 14466652
Bug: 14564559
Bug: 14564608
Bug: 14846724
Bug: 15090154
Bug: 15287699
Bug: 15289526
Bug: 15289616
Change-Id: I93e1530446d5bd6a4c3189f751c88ece1abc7767
|
| |
|
|
|
|
|
|
|
| |
Also renames some assets, removes the stationary button style, and
restores the default clear / delete icon switching.
BUG: 13322842
BUG: 13321800
Change-Id: I43ccf7a7eb40a670289ca61c3582f0914a4bacee
|
| |
|
|
| |
Change-Id: Ic79777951621c42f03e7da9dd73c350f5182f48e
|
| |
|
|
|
|
| |
Fixes b/6339309 Accessibility:- Calculator doesn't talk back any number or operation correctly.
Change-Id: I36da0604d9b743a91b085fa5f4b471e7e3a42aeb
|
| |
|
|
|
|
| |
Fixes b/6116353 Calculator doesn't calculate sin(0) when language is set to Spanish
Change-Id: Id8c65ba8aa0403f3e7988e05cde8ccb2f6624fbc
|
| |
|
|
|
|
| |
Fixes b/6116353 Calculator doesn't calculate sin(0) when language is set to Spanish
Change-Id: I40ecf66e8021e914eaee9c603191d022d0b757ff
|
| |
|
|
|
|
|
| |
Previously: 7x9 would be read as "7EX9" when you really want
"7 multiplied by 9"
Change-Id: I6fd3c1e3d0a40ca8700c10227edbdb445dbb7743
|
| |
|
|
|
|
|
|
| |
Initial set of changes for:
b/5710687 Math operation symbols are spoken poorly - need better contentDescriptions
I think we can still do better, but this is a great start.
Change-Id: Ifa7ad4958c7dc09b467f559c6f5ebfdaa94fcdae
|
| |
|
|
|
|
| |
Bug: 5163232
Change-Id: I0cc7c971c860ad00699c15aba73aa29a1028893c
|
| |
|
|
| |
Change-Id: I258918e6db10ca89626d4b3228e579121f7495d1
|
| |
|
|
|
|
| |
Also, bug: 3361241
Change-Id: I222368104ca47af3200e08db668e3f324106d7a7
|
| |
|
|
| |
Change-Id: I81e58a5a47324d536ff61aae647f5cc53822ef27
|
| | |
|
| | |
|
| | |
|
| |
|
