summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Bestas <mkbestas@lineageos.org>2018-01-22 21:13:17 +0200
committerMichael Bestas <mkbestas@lineageos.org>2018-01-23 23:02:51 +0200
commit7dec4be42c9d21466bbac007eb6b06b49db0433d (patch)
tree5e4a2aa2f17293f4048bd8b946faf89933a41313
parentaa26288828f562e874b428ac15a5e373ea7d22d9 (diff)
downloadandroid_packages_apps_Eleven-7dec4be42c9d21466bbac007eb6b06b49db0433d.tar.gz
android_packages_apps_Eleven-7dec4be42c9d21466bbac007eb6b06b49db0433d.tar.bz2
android_packages_apps_Eleven-7dec4be42c9d21466bbac007eb6b06b49db0433d.zip
Eleven: Remove obsolete references to cyngn jira tickets
Change-Id: Iaaf59d22665920a9fc30c88bf5fb1387f350de81
-rw-r--r--src/org/lineageos/eleven/MusicPlaybackService.java8
-rw-r--r--src/org/lineageos/eleven/utils/MusicUtils.java9
2 files changed, 4 insertions, 13 deletions
diff --git a/src/org/lineageos/eleven/MusicPlaybackService.java b/src/org/lineageos/eleven/MusicPlaybackService.java
index 4b3dcc9..312b788 100644
--- a/src/org/lineageos/eleven/MusicPlaybackService.java
+++ b/src/org/lineageos/eleven/MusicPlaybackService.java
@@ -334,8 +334,6 @@ public class MusicPlaybackService extends Service {
/**
* The max size allowed for the track history
* TODO: Comeback and rewrite/fix all the whole queue code bugs after demo
- * https://cyanogen.atlassian.net/browse/MUSIC-175
- * https://cyanogen.atlassian.net/browse/MUSIC-44
*/
public static final int MAX_HISTORY_SIZE = 1000;
@@ -1098,9 +1096,7 @@ public class MusicPlaybackService extends Service {
// remove the items from the history
// this is not ideal as the history shouldn't be impacted by this
// but since we are removing items from the array, it will throw
- // an exception if we keep it around. Idealistically with the queue
- // rewrite this should be all be fixed
- // https://cyanogen.atlassian.net/browse/MUSIC-44
+ // an exception if we keep it around.
ListIterator<Integer> positionIterator = mHistory.listIterator();
while (positionIterator.hasNext()) {
int pos = positionIterator.next();
@@ -1541,8 +1537,6 @@ public class MusicPlaybackService extends Service {
// if we are in shuffle mode and our next track is still valid,
// try to re-use the track
// We need to reimplement the queue to prevent hacky solutions like this
- // https://cyanogen.atlassian.net/browse/MUSIC-175
- // https://cyanogen.atlassian.net/browse/MUSIC-44
if (mNextPlayPos >= 0 && mNextPlayPos < mPlaylist.size()
&& getShuffleMode() != SHUFFLE_NONE) {
setNextTrack(mNextPlayPos);
diff --git a/src/org/lineageos/eleven/utils/MusicUtils.java b/src/org/lineageos/eleven/utils/MusicUtils.java
index 2d129f8..a460558 100644
--- a/src/org/lineageos/eleven/utils/MusicUtils.java
+++ b/src/org/lineageos/eleven/utils/MusicUtils.java
@@ -1499,8 +1499,7 @@ public final class MusicUtils {
} catch (final IllegalStateException ignored) {
// Illegal State Exception message is empty so logging will actually throw an
// exception. We should come back and figure out why we get an exception in the
- // first place and make sure we understand it completely. I will use
- // https://cyanogen.atlassian.net/browse/MUSIC-125 to track investigating this more
+ // first place and make sure we understand it completely.
}
}
}
@@ -1516,8 +1515,7 @@ public final class MusicUtils {
} catch (final IllegalStateException ex) {
// Illegal State Exception message is empty so logging will actually throw an
// exception. We should come back and figure out why we get an exception in the
- // first place and make sure we understand it completely. I will use
- // https://cyanogen.atlassian.net/browse/MUSIC-125 to track investigating this more
+ // first place and make sure we understand it completely.
}
}
return 0;
@@ -1534,8 +1532,7 @@ public final class MusicUtils {
} catch (final IllegalStateException ignored) {
// Illegal State Exception message is empty so logging will actually throw an
// exception. We should come back and figure out why we get an exception in the
- // first place and make sure we understand it completely. I will use
- // https://cyanogen.atlassian.net/browse/MUSIC-125 to track investigating this more
+ // first place and make sure we understand it completely.
}
}
return 0;